Avalonia

Commit Graph

Author	SHA1	Message	Date
Benedikt Stebner	2e7d2c5c60	Fix infinite loop when a text run shapes to no glyphs (#22119 ) * Add failing tests for runs that shape to no glyphs A shaper hides the default ignorables it substitutes for line breaks behind the font's space glyph, and deletes them when the font has no such glyph. A run holding nothing but a line break then shapes to an empty glyph buffer while still owning its characters. - TextFormatter drops that run today, so the line covers no text and the layout loop never advances past it - measuring a wrapping TextBlock whose text starts with a newline never returns. - GlyphRun indexes its glyph list without checking it is non-empty, so hit-testing such a run throws IndexOutOfRangeException. Covers all three layers: GlyphRun hit-testing, the formatted line, and the TextLayout repro from the issue. The layout test bounds maxLines so a regression fails instead of hanging the test run. The Skia tests embed the headless platform's BareMinimum.ttf, which has four glyphs and no space, rather than a copy of it. * Keep text runs that shape to no glyphs ShapeTogether split the shaped buffer by glyph count, so a run whose glyphs were all deleted by the shaper was skipped and its characters rolled into previousLength for a following run to absorb. When no such run follows, the characters are lost: the line reports a length of 0 and TextLayout formats the same line forever. Splitting by text length preserves the case the accumulation exists for - a run whose glyphs merged into a neighbouring cluster splits off no text either - and stops discarding characters that shaped to nothing. That makes zero-glyph glyph runs reachable for the first time, so: - GetDistanceFromCharacterHit, FindGlyphIndex and FindNearestCharacterHit handle an empty glyph list. There is no cluster to snap to and the run sits at a single position, so it degenerates to one zero-width cluster. - InkBounds answers empty directly instead of building a platform glyph run. TextLineImpl reads it for every shaped run in a line, and the Skia implementation creates an SKFont and measures glyph widths in its constructor - wasted on a run that marks nothing. Fixes #22004 * Adjust GlyphRun.InkBounds xml comment	1 month ago
Benedikt Stebner	e8424283fe	Universal GlyphTypeface implementation (#19852 ) * Introduce a universal IGlyphTypeface implementation that does not rely on any platform implementation * Revert changes * Fix Android * Make the test happy * Fix build * Update baseline * Fix naming * Fix headless * Move interfaces to dedicated files Make GlyphTypeface.GlyphCount an integer * Fix GlyphCount * Make IGlyphTypeface NotClientImplementable * Make sure we cache platform typefaces by their desired name, style, weight and stretch * Update baseline * Only use IGlyphTypeface * Fix Android * Try to clear the buffer before we encode somethimg * Add needed test font * Add more unit tests * Reduce allocations * Remove Direct2D1 test files * More tests * More complete table implementations * More adjustments * Use batch APIs * Handle invalid timestamps * Update baseline * Introduce a CharacterToGlyphMap struct for faster access * Remove AggressiveInlining * Remove AggressiveInlining * Make the head table optional for legacy fonts * Remove Load method. Fix TextBlockTests * Fix nullables * Remove redundant folder * Update Api baseline * revert diff helper changes * revert changes * Use bare minimum font for Headless platform and introduce a test font manager that uses the Inter font for testing. * Add missing font file for Headless platform --------- Co-authored-by: Gillibald <stebner@avaloniaui.net> Co-authored-by: Julien Lebosquain <julien@lebosquain.net>	9 months ago
Benedikt Stebner	27859b9e54	Rework TextLineImpl.GetTextBounds (#19576 ) * Rework TextLineImpl.GetTextBounds * Minor adjustments * Fix GlyphRun.GetDistanceFromCharacterHit in cluster hit	1 year ago
Benedikt Stebner	22231f5b91	FontManager adjustments (#15819 ) * Remove Regex usage from font family name normalization Fix font loading issues * Move implicit typeface resolution to the font collection	2 years ago
Benedikt Stebner	250743d786	Rework GetNext/PreviousCharacterHit	3 years ago
Max Katz	4aa6035ec3	Reuse text and geometry related headless mocks in Avalonia unit tests and benchmarks	3 years ago
Steven Kirk	668fa942b7	Don't leak IPlatformRenderInterface.	4 years ago
Benedikt Stebner	cb884c6e9e	Reintroduce customizable GlyphRun.BaselineOrigin Reintroduce Brush IBrush inheritance	4 years ago
Benedikt Stebner	07c11c75e7	Use IGlyphRunImpl in the IDrawingContextImpl	4 years ago
Julien Lebosquain	4144be11fe	Pass GlyphInfo directly to GlyphRun	4 years ago
Benedikt Stebner	895d85aa89	Implement CharacterBufferReference and related classes	4 years ago
Benedikt Stebner	a4a24c2fa5	Remove GlyphTypeface.PlatformImpl	4 years ago
Steven Kirk	fb0da85ad3	Merge core libraries. (#5831 ) * Merge core libraries. Everything below `Avalonia.Controls` into `Avalonia.Base`. * Move new files to correct place. * Removed unused dirs/projects, * Removed outdated references from theme assemblies. * Merge unit tests to match new assembly layout. * Fixup test namespaces. * Make directory match namespace. * Move files to match namespace. * Move files to match namespace. * Fix up incorrect namespace. `Avalonia.Visuals.Media.Imaging` -> `Avalonia.Media.Imaging`. * Fix resource URL. * Removed outdated dependencies. * Added missing project reference. * Update test namespaces. * Fix merge error. * Fix merge errors. * Fix bad merge in WindowsInteropTest.csproj. * Fix up merge errors in csprojs. * Remove merged tests from nuke. * Fix up namespace. * Fix compile error. * Fix failing tests. Now that more unit tests are present in Avalonia.Base.UnitTests, general `AvaloniaObject` properties are getting registered. Ignore those. Co-authored-by: Jumar Macato <16554748+jmacato@users.noreply.github.com>	5 years ago
Benedikt Stebner	b815a22d5a	Port WPF's FormattedText to Avalonia and rework TextPresenter	5 years ago
Benedikt Stebner	1855914717	Introduce HarfBuzz platform implementations for unit tests	5 years ago
Benedikt Schroeder	cde3c7227f	Add a test for GlyphRun.FindGlyphIndex	6 years ago
Benedikt Schroeder	2a181d9acb	Introduce TextRunProperties	6 years ago
Benedikt Schroeder	6b8f867006	Initialize the GlyphRun on render	6 years ago
Benedikt Schroeder	de93e8e969	Full Unicode support for TextBlock	7 years ago
Benedikt Schroeder	7901f6f09f	Fix some comments and GlyphRun.GetDistanceFromCharacterHit	7 years ago
Benedikt Schroeder	ab5e062deb	Add GlyphRun support	7 years ago

13 Commits (main)