Avalonia

Commit Graph

Author	SHA1	Message	Date
Steven Kirk	0082fc6b2a	Fix UIA selection never reaching the client on Windows (#22151 ) * Add failing tests for SAFEARRAY marshalling of COM providers SafeArrayRef.CreateFromObjects sizes the SAFEARRAY to the pooled buffer it rents rather than to the input, and only fills a slot when the object already has a live COM wrapper. Cover both with tests driven through SafeArrayMarshaller, which is how the UIA interop actually reaches this code. Two of the three tests fail: a two-element input produces a 16-element array of nulls. The string test passes and is the control. Each provider test checks the length before it reads the entries. A wrongly sized array holds slots that were never written, and dereferencing those takes down the test host with an access violation. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RYYMWsTkmkKjptFL88xjAg * Fix ISelectionProvider.GetSelection() never reaching the UIA client SafeArrayRef.CreateFromObjects had two defects, and between them every VT_UNKNOWN SAFEARRAY the automation interop produced was empty. It sized the array to the buffer it rented from ArrayPool rather than to the input, so a one-element selection became a 16-element array. The rented buffer isn't cleared, so stale pointers from an earlier rent could leak in and later be released by SafeArrayDestroy. It also filled a slot only when ComWrappers.TryGetComInstance succeeded. That call resolves a managed object that wraps a native COM instance; for a purely managed object it always fails, so no slot was ever filled and UIA received an array of nulls. Wrappers now come from ComInterfaceMarshaller<T>, which is what the rest of the interop uses. Sharing the instance matters: UI Automation identifies elements by IUnknown pointer, so a wrapper from a second ComWrappers would read as a different element. The element type isn't recoverable from the values, so SafeArrayMarshaller<T> passes it through a new generic TryCreate<T> overload. The object branch of the non-generic TryCreate is gone with it. Nothing reached it: the only other caller is ComVariant.Create, and no property value is an array of providers. This fixes ISelectionProvider.GetSelection() and, by the same route, ITableProvider.GetRowHeaders/GetColumnHeaders, ITableItemProvider, and ITextProvider.GetSelection/GetVisibleRanges. Fixes #22150 Claude-Session: https://claude.ai/code/session_01RYYMWsTkmkKjptFL88xjAg Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>	2 weeks ago
Yoshihiro Ito	4ec9cbb7b8	Support Windows shell virtual files in drag and drop (#21907 ) * Add Win32 virtual file drop support * Potential fix for pull request finding Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> * docs(win32): clarify virtual file disposal * fix(win32): handle empty virtual file reads * Address virtual file data review feedback * Address virtual stream review feedback * Address final virtual stream review nits --------- Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Co-authored-by: Julien Lebosquain <julien@lebosquain.net>	2 weeks ago
Julien Lebosquain	dd9217ee9d	Win32: fix BorderOnly maximized position on secondary screens in more cases (#21229 ) * Update IntegrationTests.Win32 to test all screens * Win32: use GetWindowPlacement to determine the screen to maximize to	5 months ago
Nikita Tsukanov	ba43523daf	Rename SystemDecorations to WindowDecorations since they aren't necessary "system". (#20796 ) * Rename SystemDecorations to WindowDecorations since they aren't necessary system. * Apply suggestions from code review Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>	7 months ago
Nikita Tsukanov	3553eda8ae	Themeable Client Window Decorations (#20770 ) * Implemented new drawn window decorations API TODO: check if it works on Win32, bring back titlebar automation peer * Adjusting naming a bit * Naming / configuration changes * Various fixes * popover fix? * wip * Address review * Extra window roles * WIP * Fixed drawn titlebar automation * Purge ExtendClientAreaChromeHints. * Fixed dynamically enabling drawn decorations * api diff * Add automation IDs for drawn decorations buttons * Resolved the issues * build * Retry a few times when Pager isn't available after test is finished * Only do faulty test detection if asked * duplicate package reference * Try disabling faulty tests on appium1 * Fix ExtendClientAreaWindowTests * Apply initial button states * Enable CSD shadow for X11 * net8? * Address review * more review comments * Moar review comments * Extra hit-test checks * Moar review * Prefix integration test app exitfullscreen to avoid clashes * Disable drawn decorations if parts = None * Respect SystemDecorations value on mac in extend-client-area mode * Tidy up logic a bit * Adjust win32 tests to titlebar not being in the tree when CSD are not enabled --------- Co-authored-by: Julien Lebosquain <julien@lebosquain.net>	7 months ago
Julien Lebosquain	a2b1149227	Add AppBuilder.UseTextShapingSubsystem (#20761 ) * Add AppBuilder.UseTextShapingSubsystem * Add subsystem defaults to error messages * Use HarfBuzz in IntegrationTests.Win32	7 months ago
Julien Lebosquain	ff0a61486d	Update headless xUnit support to v3 (#20481 ) * Update headless xUnit support to v3 * Update API suppressions	8 months ago
Youssef Victor	c9e210eb70	Update to xunit.v3 (#20331 ) * Update to xunit.v3 * Little more progress * More fixes * Keep VSTest supported * Adjust Nuke * Few fixes * Fix for xunit 2 * Fix GetData override * Adjust * Use MTP for xunit 2 * Fix test * Better fix * --no-progress * Few more fixes * no progress * Fix test * Better fix * TRX * Move to Directory.Build.props * Unify on MTP v2 * Update * Update to stable * 1.0.1 * 1.0.2 * Fix some warnings * Fix more warnings * Fix more warnings	8 months ago
Julien Lebosquain	884051ed10	Fix several issues with ExtendClientAreaToDecorationsHint on Windows (#20217 ) * Add extended client area Win32 integration tests * Fix Win32 extended client areas * Run Win32 integration tests in pipelines * Add extra tests and fixes when CanResize=false * Use WM_GETMINMAXINFO to maximize captionless windows * Use dotnet run on CI for IntegrationTests.Win32 * Address review	10 months ago
Steven Kirk	8250131e10	Rename integration tests now they're not win32-only.	5 years ago
Steven Kirk	812bf2665e	Get CheckBox automation tests passing on macOS.	5 years ago
Steven Kirk	cab21b6084	Start making automation tests work on macOS.	5 years ago
Steven Kirk	77f535f49d	Trying to use a shared project for win32/mac integration tests.	5 years ago
Steven Kirk	e0d3799887	Update IntegrationTestApp to net6.0.	5 years ago
Steven Kirk	06ed896317	Added access/accelerator key support. And start adding integration tests for menu items.	6 years ago
Steven Kirk	8b642a9141	Implemented LabeledBy.	6 years ago
Steven Kirk	651106aed3	Use Name for AutomationId.	6 years ago
Steven Kirk	2e23333996	Add CheckBox tests.	6 years ago
Steven Kirk	5f551a2dd9	Make integration tests ordered.	6 years ago
Steven Kirk	e8801c2aca	Started adding ComboBox integration tests. And fixed some issues with ComboBox/popups.	6 years ago
Steven Kirk	c1dfc1f963	Started adding integration tests.	6 years ago

9 Commits (main)