Avalonia

Tree: c3f02518e5

Commit Graph

Author	SHA1	Message	Date
Steven Kirk	b272283e50	Make popup focus stealing configurable. (#16642 ) * Show Avalonia context menu and toolip... In native text box in integration test app. Only implemented for win32 right now. This is to test the two popup behaviors required for native controls: - The context menu needs focus to be transferred to Avalonia - The ToolTip must not transfer focus to Avalonia * Added Popup.TakesFocusFromNativeControl. By default, if a popup is shown when a native control is focused, focus is transferred back to Avalonia in order for the popup to receive input. If this property is set to false, then the shown popup will not receive input until it receives an interaction which explicitly focuses the popup, such as a mouse click. The effect of this property can be seen in the Embedding tag of the IntegrationTestApp: hovering over the native text box shows an Avalonia `ToolTip` which does not steal focus from the native text box. Right-clicking to open an Avalonia `ContextMenu` does steal focus so the menu items can be selected using the arrow keys. Currently only implemented on a win32. * Show tooltip and context menu on macOS. * Implement TakeFocus on macOS. * Add integration tests. Only tested on win32 so far. * Integration tests won't work on macOS. As can be expected at this point, really. * Update API diff.	2 years ago
Steven Kirk	c6cdbfec3b	Add basic integration tests for NativeControlHost and improve its automation/a11y support. (#15542 ) * Added embedding page to IntegrationTestApp. Currently embeds a lone native text box, and only when running on Windows. * Win32 automation support for native control host. Allows native controls to appear in the Avalonia automation tree as a child of the `NativeControlHost`. They also appear in the _wrong_ place - as a direct child of the `Window` - but this appears to be expected behavior as it happens when hosting a win32 control in WPF as well. * Basic native control integration test on win32. * Test editing native win32 control in popup. * Add embedded text box on macOS. * macOS automation support for native control host. Implements special-casing of `InteropAutomationPeer`on macOS. * Make native control integration test work on macOS. The test for the native control in a popup is disabled on macOS because we have a bug there. * Add missing parts * Fix build error * Skip test to see if CI passes again. * Log more info about integration tests on win32. * Try to fix flaky test. * The tests won't yet work on macOS yet. Will require #16577. --------- Co-authored-by: Benedikt Stebner <Gillibald@users.noreply.github.com> Co-authored-by: Max Katz <maxkatz6@outlook.com>	2 years ago

Author

SHA1

Message

Date

Steven Kirk

b272283e50

Make popup focus stealing configurable. (#16642 )

* Show Avalonia context menu and toolip...

In native text box in integration test app. Only implemented for win32 right now.

This is to test the two popup behaviors required for native controls:

- The context menu needs focus to be transferred to Avalonia
- The ToolTip must not transfer focus to Avalonia

* Added Popup.TakesFocusFromNativeControl.

By default, if a popup is shown when a native control is focused, focus is transferred back to Avalonia in order for the popup to receive input. If this property is set to false, then the shown popup will not receive input until it receives an interaction which explicitly focuses the popup, such as a mouse click.

The effect of this property can be seen in the Embedding tag of the IntegrationTestApp: hovering over the native text box shows an Avalonia `ToolTip` which does not steal focus from the native text box. Right-clicking to open an Avalonia `ContextMenu` does steal focus so the menu items can be selected using the arrow keys.

Currently only implemented on a win32.

* Show tooltip and context menu on macOS.

* Implement TakeFocus on macOS.

* Add integration tests.

Only tested on win32 so far.

* Integration tests won't work on macOS.

As can be expected at this point, really.

* Update API diff.

2 years ago

Steven Kirk

c6cdbfec3b

Add basic integration tests for NativeControlHost and improve its automation/a11y support. (#15542 )

* Added embedding page to IntegrationTestApp.

Currently embeds a lone native text box, and only when running on Windows.

* Win32 automation support for native control host.

Allows native controls to appear in the Avalonia automation tree as a child of the `NativeControlHost`. They also appear in the _wrong_ place - as a direct child of the `Window` - but this appears to be expected behavior as it happens when hosting a win32 control in WPF as well.

* Basic native control integration test on win32.

* Test editing native win32 control in popup.

* Add embedded text box on macOS.

* macOS automation support for native control host.

Implements special-casing of `InteropAutomationPeer`on macOS.

* Make native control integration test work on macOS.

The test for the native control in a popup is disabled on macOS because we have a bug there.

* Add missing parts

* Fix build error

* Skip test to see if CI passes again.

* Log more info about integration tests on win32.

* Try to fix flaky test.

* The tests won't yet work on macOS yet.

Will require #16577.

---------

Co-authored-by: Benedikt Stebner <Gillibald@users.noreply.github.com>
Co-authored-by: Max Katz <maxkatz6@outlook.com>

2 years ago

2 Commits (c3f02518e5f01650dfeb133f7b36b4dc2214f69d)