Avalonia

26921 Commits

713 Branches

177 Tags

264 MiB

Tree: f4d28d5d45

Commit Graph

Author	SHA1	Message	Date
StefanKoell	b46126714b	Fixes and improves several access key (accelerator) related issues (#17292 ) * fix accelerator behavior for menu items and labels * add elements with matching accelerator to test cycling in sub menus * Add AccessKeyHandler tests for accelerators with more than one match * Implement accelerator behavior based on WPF handling * Remove commented code * Remove OnAccessKey override => handled by DefaultMenuInteractionHandler * remove obsolete test * handle OnAccessKeyPressed for selected tab item * fix unit tests * use AccessKeyEvent instead of AccessKeyPressedEvent in unit tests * navigate menu with and without ALT key * Revert formatting changes in Tests * Fix AccessKeyHandler comments * move private types to bottom * Remove lock statements, optimize removal of AccessKeyRegistrations * remove call to Dispatcher.UIThread.Post * simplifiy AccessKeyHandler.SortByHierarchy * remove unnecessary method AccessKeyHandler.GetTargetsForSender * regenerate API suppression file * revert unneeded changes in MenuPage.axaml * correct formatting changes * do not sort by hierarchy if too few targets * make AccessKeyEventArgs internal * make AccessKeyPressedEventArgs internal --------- Co-authored-by: Hans Docsek <hans.docsek@gmail.com>	2 years ago
Boyd Patterson	98acdd7c08	Do not match access keys on input elements that are not effectively enabled. (#13185 )	3 years ago
Steven Kirk	8e9532a580	Added tests for AccessKeyHandler. Some failing: tests are chosen to match UWP behavior, not WPF (which hides key press events for access keys).	3 years ago

Author

SHA1

Message

Date

StefanKoell

b46126714b

Fixes and improves several access key (accelerator) related issues (#17292 )

* fix accelerator behavior for menu items and labels

* add elements with matching accelerator to test cycling in sub menus

* Add AccessKeyHandler tests for accelerators with more than one match

* Implement accelerator behavior based on WPF handling

* Remove commented code

* Remove OnAccessKey override => handled by DefaultMenuInteractionHandler

* remove obsolete test

* handle OnAccessKeyPressed for selected tab item

* fix unit tests

* use AccessKeyEvent instead of AccessKeyPressedEvent in unit tests

* navigate menu with and without ALT key

* Revert formatting changes in Tests

* Fix AccessKeyHandler comments

* move private types to bottom

* Remove lock statements, optimize removal of AccessKeyRegistrations

* remove call to Dispatcher.UIThread.Post

* simplifiy AccessKeyHandler.SortByHierarchy

* remove unnecessary method AccessKeyHandler.GetTargetsForSender

* regenerate API suppression file

* revert unneeded changes in MenuPage.axaml

* correct formatting changes

* do not sort by hierarchy if too few targets

* make AccessKeyEventArgs internal

* make AccessKeyPressedEventArgs internal

---------

Co-authored-by: Hans Docsek <hans.docsek@gmail.com>

2 years ago

Boyd Patterson

98acdd7c08

Do not match access keys on input elements that are not effectively enabled. (#13185 )

3 years ago

Steven Kirk

8e9532a580

Added tests for AccessKeyHandler.

Some failing: tests are chosen to match UWP behavior, not WPF (which hides key press events for access keys).

3 years ago

3 Commits (f4d28d5d45a8bf198bfb571c935cf4c3ea8db001)