tsai/Avalonia: A cross-platform UI framework for .NET - Avalonia - Gitea: Git with a cup of tea

A cross-platform UI framework for .NET

csharp c-sharp dotnet xaml avaloniaui cross-platform cross-platform-xaml avalonia gui multi-platform user-interface dotnetcore

Branch: fix-mac-special-character-input

History

Benedikt Stebner aee3f68551 TextCollapsingProperties bidirectional-text (BiDi) correctness fixes (#21446 ) * Fix BiDi correctness across TextCollapsingProperties implementations Audit and fix logical-vs-visual ordering bugs in every text-collapsing implementation and the helpers they share, so trimming always operates in logical order (the consumer re-runs the BiDi reorderer in FinalizeLine, so pre-applying visual order would be reordered a second time). - LogicalTextRunEnumerator returned the first run on every MoveNext when _indexedTextRuns was null. - TextLeadingPrefixCharacterEllipsis: walked visual-order runs while splitting at logical offsets, guarded the wrong field in the ctor, hardcoded LeftToRight for the symbol, appended the suffix in reverse-logical order, and mis-tracked the width budget across multi-run lines. - TextPathSegmentEllipsis: crashed via Split(0) in the fallback path, and measured RTL segments as ~0 width (it assumed ascending cluster ids). - ShapedTextRun.TryMeasureCharacters/Backwards returned visual-order counts for RTL runs. ShapedBuffer gains logical-order, cluster-cache-backed width helpers (GetCharRangeWidth, FindLeading/FindTrailingCharCountWithinWidth) that are safe in the one-char-per-cluster simple mode (null _clusterStartChars). Adds a BiDi characterization test suite and documents the logical-order Collapse contract. * Align text width comparisons to epsilon-tolerant MathUtilities Several width-fit comparisons in the measure/collapse path used raw operators with no epsilon, while the cluster-cache hot path (MeasureCharactersThatFit) and the ShapedTextRun branch of MeasureLength already went through MathUtilities. Replace the raw float comparisons with their epsilon-aware equivalents (<= -> LessThanOrClose, < -> LessThan, > -> GreaterThan) in ShapedBuffer.FindLeading/FindTrailingCharCountWithinWidth, TextPathSegmentEllipsis, and TextLeadingPrefixCharacterEllipsis. Also unify the DrawableTextRun branch of TextFormatterImpl.MeasureLength with the ShapedTextRun branch (>= -> GreaterThan) so the "whole run fits" boundary is identical for both run types: a run fits when width <= remaining (tolerant) and overflows only when strictly greater. Integer char-offset/index comparisons and the availableWidth <= 0 positivity guards are intentionally left as raw comparisons. * Cleanup some comments * Fix Split(0) crash in TextLeadingPrefixCharacterEllipsis suffix collection When a logical-tail run fits entirely within the remaining suffix budget, TryMeasureCharactersBackwards returns suffixCount == run.Length, so Split(run.Length - suffixCount) evaluated to Split(0), which throws ArgumentOutOfRangeException. This was reachable on multi-run lines whose post-split tail contains a small later run that fully fits. Guard the split on splitAt > 0 and use the whole run as-is when it fully fits (dropping it only when suffixCount == 0) — the same boundary pattern already applied to TextPathSegmentEllipsis. Add a multi-run regression test. * Remove duplicate ShapedBuffer.MeasureCharactersThatFit MeasureCharactersThatFit and FindLeadingCharCountWithinWidth ran the identical cluster-prefix binary search; the only functional difference was the unused `out widthConsumed`. Drop the former and repoint its callers (TextFormatterImpl.MeasureLength and the benchmark) at FindLeadingCharCountWithinWidth, which also unifies the availableWidth<=0 guard. The one test that asserted the consumed width now recovers it via GetCharRangeWidth(0, fit). Also tidy GetCharRangeWidth's simple-mode bounds to use Math.Clamp.		4 months ago
..
CodepointBenchmark.cs	[Text] Unicode and text layout optimizations (#21400)	4 months ago
HugeTextLayout.cs	[Text] Unicode and text layout optimizations (#21400)	4 months ago
ShapedBufferOps.cs	TextCollapsingProperties bidirectional-text (BiDi) correctness fixes (#21446)	4 months ago
TextLayoutProfile.cs	[Text] Unicode and text layout optimizations (#21400)	4 months ago
TextRunCacheBenchmark.cs	Implement TextRunCache (#21030)	6 months ago
UnicodeBreakEnumeratorBenchmark.cs	[Text] Unicode and text layout optimizations (#21400)	4 months ago
UnicodeTrieBenchmark.cs	[Text] Unicode and text layout optimizations (#21400)	4 months ago