Avalonia

A cross-platform UI framework for .NET

csharp c-sharp dotnet xaml avaloniaui cross-platform cross-platform-xaml avalonia gui multi-platform user-interface dotnetcore

Branch: main

History

Steven Kirk 9d54818fd5 Fix memory leak when binding to observables (#5872 , #18176 ) (#22097 ) * Add failing leak tests for observable binding target retention (#5872) A binding to a long-lived observable via the `^` stream operator (or via `Observable.ToBinding()`, #18176) keeps the binding target alive for the lifetime of the observable. Every other binding type holds its target weakly so the target can be collected even while the binding is active; observable-sourced bindings break this invariant because the observable holds the observer (and therefore the whole expression/target chain) strongly. These tests currently fail and document the leak. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Wc2sczJ87MD2wVDjgQjDLB * Subscribe weakly to observable binding sources (#5872, #18176) Bindings hold their target weakly so that a control can be collected even while a binding to a long-lived source is active; normal property bindings preserve this by subscribing to their source via weak events. Observable sources broke the invariant: `observable.Subscribe(this)` let the observable hold the observer strongly, which transitively rooted the ValueStore and therefore the binding target, so a long-lived observable pinned the control for the observable's lifetime. Introduce WeakObserverSubscription, which subscribes an observer to an observable via a weak reference and disposes itself once the observer has been collected, and use it from StreamNode (the `^` stream operator) and UntypedObservableBindingExpression (Observable.ToBinding()). Claude-Session: https://claude.ai/code/session_01Wc2sczJ87MD2wVDjgQjDLB Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * Remove null-forgiving operator. * Remove unnecesary comments. It's plain from the code what's going on here. --------- Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>		3 weeks ago
..
Properties	Remove copyright headers.	7 years ago
Avalonia.LeakTests.csproj	Onboard onto Central Package Management (#20704)	7 months ago
AvaloniaObjectTests.cs	Fix memory leak when binding to observables (#5872, #18176) (#22097)	3 weeks ago
BindingExpressionExtensions.cs	Add CompiledBinding.Create factory methods from LINQ expressions (#20443)	8 months ago
BindingExpressionTests.cs	Add CompiledBinding.Create factory methods from LINQ expressions (#20443)	8 months ago
ControlTests.cs	Implement GetTemplateDescendants (#21245)	5 months ago
DataContextTests.cs	Rewrite leak tests without dotMemory Unit (#20095)	10 months ago
Readme.txt	Renamed Perspex -> Avalonia	11 years ago
ReleaseFact.cs	Update to xunit.v3 (#20331)	8 months ago
TransitionTests.cs	Rewrite leak tests without dotMemory Unit (#20095)	10 months ago
app.config	Stop assert dialogs popping up in leak tests.	4 years ago

Readme.txt

Memory Leak Tests
-----------------

These tests use JetBrains' dotMemory Unit. When run in a normal test runner, they will always pass.

To run the tests, you need to have dotMemory/ReSharper and install the XUnit plugin. You should 
then be able to run the tests using Resharper -> Unit Tests -> Run all tests from solution under
dotMemory Unit.