v3.1.1.0 Fixes #36

Permissions issues within the DotNetOpenAuth library when used in
conjunction with Mvc5 were causing a ReflectionTypeLoadException when
attempting to autoload all plugins. Behaviour is now changed so that if
this fails, plugins will load from the configuration instead.


Former-commit-id: c6b35c7f09bb26f75b030d0b3aadf909498bc6a9

src/ImageProcessor.Web/NET45/Config/ImageProcessorConfig.cs

@@ -17,6 +17,7 @@ namespace ImageProcessor.Web.Config
     using System.Linq;
     using System.Reflection;
     using System.Text;
+    using System.Web.Compilation;
 
     using ImageProcessor.Processors;
     #endregion
@@ -288,21 +289,20 @@ namespace ImageProcessor.Web.Config
         {
             if (this.GraphicsProcessors == null)
             {
-                try
+                if (GetImageProcessingSection().Plugins.AutoLoadPlugins)
                 {
-                    if (GetImageProcessingSection().Plugins.AutoLoadPlugins)
+                    Type type = typeof(IGraphicsProcessor);
+                    try
                     {
                         // Build a list of native IGraphicsProcessor instances.
-                        Type type = typeof(IGraphicsProcessor);
+                        List<Type> availableTypes = BuildManager.GetReferencedAssemblies()
-                        IEnumerable<Type> types =
+                                                                .Cast<Assembly>()
-                            AppDomain.CurrentDomain.GetAssemblies()
+                                                                .SelectMany(s => s.GetTypes())
-                                     .SelectMany(s => s.GetTypes())
+                                                                .Where(t => t != null && type.IsAssignableFrom(t) && t.IsClass && !t.IsAbstract)
-                                     .Where(p => type.IsAssignableFrom(p) && p.IsClass && !p.IsAbstract)
+                                                                .ToList();
-                                     .ToList();
+                        
-
                         // Create them and add.
-                        this.GraphicsProcessors =
+                        this.GraphicsProcessors = availableTypes.Select(x => (Activator.CreateInstance(x) as IGraphicsProcessor)).ToList();
-                            types.Select(x => (Activator.CreateInstance(x) as IGraphicsProcessor)).ToList();
 
                         // Add the available settings.
                         foreach (IGraphicsProcessor processor in this.GraphicsProcessors)
@@ -310,53 +310,44 @@ namespace ImageProcessor.Web.Config
                             processor.Settings = this.GetPluginSettings(processor.GetType().Name);
                         }
                     }
-                    else
+                    catch (ReflectionTypeLoadException ex)
                     {
-                        ImageProcessingSection.PluginElementCollection pluginConfigs = imageProcessingSection.Plugins;
+                        this.LoadGraphicsProcessorsFromConfiguration();
-                        this.GraphicsProcessors = new List<IGraphicsProcessor>();
-                        foreach (ImageProcessingSection.PluginElement pluginConfig in pluginConfigs)
-                        {
-                            Type type = Type.GetType(pluginConfig.Type);
-
-                            if (type == null)
-                            {
-                                throw new ArgumentException("Couldn't load IGraphicsProcessor: " + pluginConfig.Type);
-                            }
-
-                            this.GraphicsProcessors.Add(Activator.CreateInstance(type) as IGraphicsProcessor);
-                        }
-
-                        // Add the available settings.
-                        foreach (IGraphicsProcessor processor in this.GraphicsProcessors)
-                        {
-                            processor.Settings = this.GetPluginSettings(processor.GetType().Name);
-                        }
                     }
                 }
-                catch (ReflectionTypeLoadException ex)
+                else
                 {
-                    StringBuilder stringBuilder = new StringBuilder();
+                    this.LoadGraphicsProcessorsFromConfiguration();
-                    foreach (Exception exception in ex.LoaderExceptions)
+                }
-                    {
+            }
-                        stringBuilder.AppendLine(exception.Message);
+        }
-                        if (exception is FileNotFoundException)
-                        {
-                            FileNotFoundException fileNotFoundException = exception as FileNotFoundException;
-                            if (!string.IsNullOrEmpty(fileNotFoundException.FusionLog))
-                            {
-                                stringBuilder.AppendLine("Fusion Log:");
-                                stringBuilder.AppendLine(fileNotFoundException.FusionLog);
-                            }
-                        }
-
-                        stringBuilder.AppendLine();
-                    }
 
-                    string errorMessage = stringBuilder.ToString();
+        /// <summary>
+        /// Loads graphics processors from configuration.
+        /// </summary>
+        /// <exception cref="TypeLoadException">
+        /// Thrown when an <see cref="IGraphicsProcessor"/> cannot be loaded.
+        /// </exception>
+        private void LoadGraphicsProcessorsFromConfiguration()
+        {
+            ImageProcessingSection.PluginElementCollection pluginConfigs = imageProcessingSection.Plugins;
+            this.GraphicsProcessors = new List<IGraphicsProcessor>();
+            foreach (ImageProcessingSection.PluginElement pluginConfig in pluginConfigs)
+            {
+                Type type = Type.GetType(pluginConfig.Type);
 
-                    // Display or log the error based on your application.
+                if (type == null)
-                    throw new Exception(errorMessage);
+                {
+                    throw new TypeLoadException("Couldn't load IGraphicsProcessor: " + pluginConfig.Type);
                 }
+
+                this.GraphicsProcessors.Add(Activator.CreateInstance(type) as IGraphicsProcessor);
+            }
+
+            // Add the available settings.
+            foreach (IGraphicsProcessor processor in this.GraphicsProcessors)
+            {
+                processor.Settings = this.GetPluginSettings(processor.GetType().Name);
             }
         }
         #endregion

src/ImageProcessor.Web/NET45/Properties/AssemblyInfo.cs

@@ -31,6 +31,6 @@ using System.Runtime.InteropServices;
 //
 // You can specify all the values or you can default the Build and Revision Numbers 
 // by using the '*' as shown below:
-[assembly: AssemblyVersion("3.1.0.0")]
+[assembly: AssemblyVersion("3.1.1.0")]
-[assembly: AssemblyFileVersion("3.1.0.0")]
+[assembly: AssemblyFileVersion("3.1.1.0")]