From 210a3d6e67ff99a1fc43b75bfc43aa0aeaef9c7a Mon Sep 17 00:00:00 2001 From: Stefan Nikolei Date: Thu, 23 Mar 2023 13:50:57 +0100 Subject: [PATCH] Apply suggestions from code review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: Günther Foidl --- src/ImageSharp/Common/Helpers/SimdUtils.HwIntrinsics.cs | 6 +++--- .../ColorConverters/JpegColorConverter.GrayScaleArm.cs | 8 ++++---- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/src/ImageSharp/Common/Helpers/SimdUtils.HwIntrinsics.cs b/src/ImageSharp/Common/Helpers/SimdUtils.HwIntrinsics.cs index 819837be1..2cb205a7d 100644 --- a/src/ImageSharp/Common/Helpers/SimdUtils.HwIntrinsics.cs +++ b/src/ImageSharp/Common/Helpers/SimdUtils.HwIntrinsics.cs @@ -566,9 +566,9 @@ internal static partial class SimdUtils /// The . [MethodImpl(InliningOptions.AlwaysInline)] public static Vector128 MultiplyAdd( - in Vector128 va, - in Vector128 vm0, - in Vector128 vm1) + Vector128 va, + Vector128 vm0, + Vector128 vm1) { if (Fma.IsSupported) { diff --git a/src/ImageSharp/Formats/Jpeg/Components/ColorConverters/JpegColorConverter.GrayScaleArm.cs b/src/ImageSharp/Formats/Jpeg/Components/ColorConverters/JpegColorConverter.GrayScaleArm.cs index 56e51eb53..a8d5f49c2 100644 --- a/src/ImageSharp/Formats/Jpeg/Components/ColorConverters/JpegColorConverter.GrayScaleArm.cs +++ b/src/ImageSharp/Formats/Jpeg/Components/ColorConverters/JpegColorConverter.GrayScaleArm.cs @@ -27,8 +27,8 @@ internal abstract partial class JpegColorConverterBase // Used for the color conversion var scale = Vector128.Create(1 / this.MaximumValue); - nint n = values.Component0.Length / Vector128.Count; - for (nint i = 0; i < n; i++) + nuint n = (uint)values.Component0.Length / (uint)Vector128.Count; + for (nuint i = 0; i < n; i++) { ref Vector128 c0 = ref Unsafe.Add(ref c0Base, i); c0 = AdvSimd.Multiply(c0, scale); @@ -53,8 +53,8 @@ internal abstract partial class JpegColorConverterBase var f0587 = Vector128.Create(0.587f); var f0114 = Vector128.Create(0.114f); - nint n = values.Component0.Length / Vector128.Count; - for (nint i = 0; i < n; i++) + nuint n = (uint)values.Component0.Length / (uint)Vector128.Count; + for (nuint i = 0; i < n; i++) { ref Vector128 r = ref Unsafe.Add(ref srcRed, i); ref Vector128 g = ref Unsafe.Add(ref srcGreen, i);