From 454c5a1b48cbb0cf112578eb20ff882a90f4c48a Mon Sep 17 00:00:00 2001 From: Anton Firszov Date: Sun, 1 Apr 2018 02:03:02 +0200 Subject: [PATCH] trying to fine-tune tolerance values --- .../Processing/Processors/Filters/FilterTest.cs | 2 +- .../Processing/Transforms/AffineTransformTests.cs | 2 +- .../TestUtilities/ImageComparison/ImageComparer.cs | 5 +++-- 3 files changed, 5 insertions(+), 4 deletions(-) diff --git a/tests/ImageSharp.Tests/Processing/Processors/Filters/FilterTest.cs b/tests/ImageSharp.Tests/Processing/Processors/Filters/FilterTest.cs index 5c90b1334c..8a24046569 100644 --- a/tests/ImageSharp.Tests/Processing/Processors/Filters/FilterTest.cs +++ b/tests/ImageSharp.Tests/Processing/Processors/Filters/FilterTest.cs @@ -16,7 +16,7 @@ namespace SixLabors.ImageSharp.Tests.Processing.Processors.Filters [GroupOutput("Filters")] public class FilterTest { - private static readonly ImageComparer ValidatorComparer = ImageComparer.TolerantPercentage(0.02f); + private static readonly ImageComparer ValidatorComparer = ImageComparer.TolerantPercentage(0.005f, 3); // Testing the generic FilterProcessor with more than one pixel type intentionally. // There is no need to do this with the specialized ones. diff --git a/tests/ImageSharp.Tests/Processing/Transforms/AffineTransformTests.cs b/tests/ImageSharp.Tests/Processing/Transforms/AffineTransformTests.cs index 27e7efcc99..c4a8c9b2da 100644 --- a/tests/ImageSharp.Tests/Processing/Transforms/AffineTransformTests.cs +++ b/tests/ImageSharp.Tests/Processing/Transforms/AffineTransformTests.cs @@ -18,7 +18,7 @@ namespace SixLabors.ImageSharp.Tests.Processing.Transforms { private readonly ITestOutputHelper Output; - private static readonly ImageComparer ValidatorComparer = ImageComparer.TolerantPercentage(0.005f); + private static readonly ImageComparer ValidatorComparer = ImageComparer.TolerantPercentage(0.005f, 3); /// /// angleDeg, sx, sy, tx, ty diff --git a/tests/ImageSharp.Tests/TestUtilities/ImageComparison/ImageComparer.cs b/tests/ImageSharp.Tests/TestUtilities/ImageComparison/ImageComparer.cs index 7dbbe63112..b708673c70 100644 --- a/tests/ImageSharp.Tests/TestUtilities/ImageComparison/ImageComparer.cs +++ b/tests/ImageSharp.Tests/TestUtilities/ImageComparison/ImageComparer.cs @@ -28,8 +28,9 @@ namespace SixLabors.ImageSharp.Tests.TestUtilities.ImageComparison /// /// Returns Tolerant(imageThresholdInPercents/100) /// - public static ImageComparer TolerantPercentage(float imageThresholdInPercents) => - Tolerant(imageThresholdInPercents / 100f); + public static ImageComparer TolerantPercentage(float imageThresholdInPercents, + int perPixelManhattanThreshold = 0) => + Tolerant(imageThresholdInPercents / 100f, perPixelManhattanThreshold); public abstract ImageSimilarityReport CompareImagesOrFrames( ImageFrame expected,