From 4bd990e52deacd1511d2f7776eb43ad52a7bd452 Mon Sep 17 00:00:00 2001
From: Dirk Lemstra <dirk@git.imagemagick.org>
Date: Wed, 28 Dec 2016 14:48:05 +0100
Subject: [PATCH] Upgrade StyleCop to the latest beta.

---
 ImageSharp.ruleset                           |  6 +++
 ImageSharp.sln                               |  1 +
 src/ImageSharp/Formats/Gif/GifEncoderCore.cs |  1 +
 src/ImageSharp/Profiles/Exif/ExifTag.cs      | 50 ++++++++++----------
 4 files changed, 33 insertions(+), 25 deletions(-)
 create mode 100644 ImageSharp.ruleset

diff --git a/ImageSharp.ruleset b/ImageSharp.ruleset
new file mode 100644
index 000000000..554dc16dd
--- /dev/null
+++ b/ImageSharp.ruleset
@@ -0,0 +1,6 @@
+<?xml version="1.0" encoding="utf-8"?>
+<RuleSet Name="ImageSharp" ToolsVersion="14.0">
+  <Rules AnalyzerId="StyleCop.Analyzers" RuleNamespace="StyleCop.Analyzers">
+    <Rule Id="SA1413" Action="None" />
+  </Rules>
+</RuleSet>
diff --git a/ImageSharp.sln b/ImageSharp.sln
index fcf75a49a..afc7dce81 100644
--- a/ImageSharp.sln
+++ b/ImageSharp.sln
@@ -20,6 +20,7 @@ Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "SolutionItems", "SolutionIt
 		build\dotnet-latest.ps1 = build\dotnet-latest.ps1
 		features.md = features.md
 		global.json = global.json
+		ImageSharp.ruleset = ImageSharp.ruleset
 		NuGet.config = NuGet.config
 		build\package.json = build\package.json
 		README.md = README.md
diff --git a/src/ImageSharp/Formats/Gif/GifEncoderCore.cs b/src/ImageSharp/Formats/Gif/GifEncoderCore.cs
index d3e15d3bd..8a851fd68 100644
--- a/src/ImageSharp/Formats/Gif/GifEncoderCore.cs
+++ b/src/ImageSharp/Formats/Gif/GifEncoderCore.cs
@@ -282,6 +282,7 @@ namespace ImageSharp.Formats
             where TColor : struct, IPackedPixel, IEquatable<TColor>
         {
             writer.Write(GifConstants.ImageDescriptorLabel); // 2c
+
             // TODO: Can we capture this?
             writer.Write((ushort)0); // Left position
             writer.Write((ushort)0); // Top position
diff --git a/src/ImageSharp/Profiles/Exif/ExifTag.cs b/src/ImageSharp/Profiles/Exif/ExifTag.cs
index 894f5a064..6f4b49485 100644
--- a/src/ImageSharp/Profiles/Exif/ExifTag.cs
+++ b/src/ImageSharp/Profiles/Exif/ExifTag.cs
@@ -29,15 +29,15 @@ namespace ImageSharp
         /// <summary>
         /// SubfileType
         /// </summary>
-        [ExifTagDescription((uint)0, "Full-resolution Image")]
-        [ExifTagDescription((uint)1, "Reduced-resolution image")]
-        [ExifTagDescription((uint)2, "Single page of multi-page image")]
-        [ExifTagDescription((uint)3, "Single page of multi-page reduced-resolution image")]
-        [ExifTagDescription((uint)4, "Transparency mask")]
-        [ExifTagDescription((uint)5, "Transparency mask of reduced-resolution image")]
-        [ExifTagDescription((uint)6, "Transparency mask of multi-page image")]
-        [ExifTagDescription((uint)7, "Transparency mask of reduced-resolution multi-page image")]
-        [ExifTagDescription((uint)0x10001, "Alternate reduced-resolution image ")]
+        [ExifTagDescription(0U, "Full-resolution Image")]
+        [ExifTagDescription(1U, "Reduced-resolution image")]
+        [ExifTagDescription(2U, "Single page of multi-page image")]
+        [ExifTagDescription(3U, "Single page of multi-page reduced-resolution image")]
+        [ExifTagDescription(4U, "Transparency mask")]
+        [ExifTagDescription(5U, "Transparency mask of reduced-resolution image")]
+        [ExifTagDescription(6U, "Transparency mask of multi-page image")]
+        [ExifTagDescription(7U, "Transparency mask of reduced-resolution multi-page image")]
+        [ExifTagDescription(0x10001U, "Alternate reduced-resolution image ")]
         SubfileType = 0x00FE,
 
         /// <summary>
@@ -276,15 +276,15 @@ namespace ImageSharp
         /// <summary>
         /// T4Options
         /// </summary>
-        [ExifTagDescription((uint)0, "2-Dimensional encoding")]
-        [ExifTagDescription((uint)1, "Uncompressed")]
-        [ExifTagDescription((uint)2, "Fill bits added")]
+        [ExifTagDescription(0U, "2-Dimensional encoding")]
+        [ExifTagDescription(1U, "Uncompressed")]
+        [ExifTagDescription(2U, "Fill bits added")]
         T4Options = 0x0124,
 
         /// <summary>
         /// T6Options
         /// </summary>
-        [ExifTagDescription((uint)1, "Uncompressed")]
+        [ExifTagDescription(1U, "Uncompressed")]
         T6Options = 0x0125,
 
         /// <summary>
@@ -383,9 +383,9 @@ namespace ImageSharp
         /// <summary>
         /// CleanFaxData
         /// </summary>
-        [ExifTagDescription((uint)0, "Clean")]
-        [ExifTagDescription((uint)1, "Regenerated")]
-        [ExifTagDescription((uint)2, "Unclean")]
+        [ExifTagDescription(0U, "Clean")]
+        [ExifTagDescription(1U, "Regenerated")]
+        [ExifTagDescription(2U, "Unclean")]
         CleanFaxData = 0x0147,
 
         /// <summary>
@@ -491,8 +491,8 @@ namespace ImageSharp
         /// <summary>
         /// ProfileType
         /// </summary>
-        [ExifTagDescription((uint)0, "Unspecified")]
-        [ExifTagDescription((uint)1, "Group 3 FAX")]
+        [ExifTagDescription(0U, "Unspecified")]
+        [ExifTagDescription(1U, "Group 3 FAX")]
         ProfileType = 0x0191,
 
         /// <summary>
@@ -512,13 +512,13 @@ namespace ImageSharp
         /// <summary>
         /// CodingMethods
         /// </summary>
-        [ExifTagDescription((ulong)0, "Unspecified compression")]
-        [ExifTagDescription((ulong)1, "Modified Huffman")]
-        [ExifTagDescription((ulong)2, "Modified Read")]
-        [ExifTagDescription((ulong)4, "Modified MR")]
-        [ExifTagDescription((ulong)8, "JBIG")]
-        [ExifTagDescription((ulong)16, "Baseline JPEG")]
-        [ExifTagDescription((ulong)32, "JBIG color")]
+        [ExifTagDescription(0UL, "Unspecified compression")]
+        [ExifTagDescription(1UL, "Modified Huffman")]
+        [ExifTagDescription(2UL, "Modified Read")]
+        [ExifTagDescription(4UL, "Modified MR")]
+        [ExifTagDescription(8UL, "JBIG")]
+        [ExifTagDescription(16UL, "Baseline JPEG")]
+        [ExifTagDescription(32UL, "JBIG color")]
         CodingMethods = 0x0193,
 
         /// <summary>