Browse Source

Respond to feedback

pull/3070/head
James Jackson-South 2 months ago
parent
commit
4fc4d660fa
  1. 2
      src/ImageSharp/ColorProfiles/Icc/Calculators/LutABCalculator.cs
  2. 4
      src/ImageSharp/Metadata/Profiles/ICC/TagDataEntries/IccLutAToBTagDataEntry.cs
  3. 4
      src/ImageSharp/Metadata/Profiles/ICC/TagDataEntries/IccLutBToATagDataEntry.cs

2
src/ImageSharp/ColorProfiles/Icc/Calculators/LutABCalculator.cs

@ -127,7 +127,7 @@ internal partial class LutABCalculator : IVector4Calculator
Guard.IsTrue(
hasACurve || hasBCurve || hasMCurve || hasMatrix || hasClut,
nameof(curveB),
"entry",
"AToB or BToA tag must contain at least one processing element");
if (hasACurve)

4
src/ImageSharp/Metadata/Profiles/ICC/TagDataEntries/IccLutAToBTagDataEntry.cs

@ -128,7 +128,7 @@ internal sealed class IccLutAToBTagDataEntry : IccTagDataEntry, IEquatable<IccLu
&& this.OutputChannelCount == other.OutputChannelCount
&& this.Matrix3x3.Equals(other.Matrix3x3)
&& this.Matrix3x1.Equals(other.Matrix3x1)
&& this.ClutValues.Equals(other.ClutValues)
&& Equals(this.ClutValues, other.ClutValues)
&& EqualsCurve(this.CurveB, other.CurveB)
&& EqualsCurve(this.CurveM, other.CurveM)
&& EqualsCurve(this.CurveA, other.CurveA);
@ -168,7 +168,7 @@ internal sealed class IccLutAToBTagDataEntry : IccTagDataEntry, IEquatable<IccLu
return true;
}
if (entryNull)
if (thisNull || entryNull)
{
return false;
}

4
src/ImageSharp/Metadata/Profiles/ICC/TagDataEntries/IccLutBToATagDataEntry.cs

@ -128,7 +128,7 @@ internal sealed class IccLutBToATagDataEntry : IccTagDataEntry, IEquatable<IccLu
&& this.OutputChannelCount == other.OutputChannelCount
&& this.Matrix3x3.Equals(other.Matrix3x3)
&& this.Matrix3x1.Equals(other.Matrix3x1)
&& this.ClutValues.Equals(other.ClutValues)
&& Equals(this.ClutValues, other.ClutValues)
&& EqualsCurve(this.CurveB, other.CurveB)
&& EqualsCurve(this.CurveM, other.CurveM)
&& EqualsCurve(this.CurveA, other.CurveA);
@ -167,7 +167,7 @@ internal sealed class IccLutBToATagDataEntry : IccTagDataEntry, IEquatable<IccLu
return true;
}
if (entryNull)
if (thisNull || entryNull)
{
return false;
}

Loading…
Cancel
Save