From a8ea3e0f9e68ad9bdaf9246e9e9c9f9c0d312bea Mon Sep 17 00:00:00 2001
From: Stefan Nikolei <stefan@nikolei.eu>
Date: Tue, 5 Nov 2024 22:06:39 +0100
Subject: [PATCH] #2807 Add early return in InternalDetectFormat

---
 src/ImageSharp/Image.Decode.cs | 11 ++++-------
 1 file changed, 4 insertions(+), 7 deletions(-)

diff --git a/src/ImageSharp/Image.Decode.cs b/src/ImageSharp/Image.Decode.cs
index 7f58c6ecd8..d2ee0f9061 100644
--- a/src/ImageSharp/Image.Decode.cs
+++ b/src/ImageSharp/Image.Decode.cs
@@ -128,21 +128,18 @@ public abstract partial class Image
         // Does the given stream contain enough data to fit in the header for the format
         // and does that data match the format specification?
         // Individual formats should still check since they are public.
-        IImageFormat? format = null;
         foreach (IImageFormatDetector formatDetector in configuration.ImageFormatsManager.FormatDetectors)
         {
             if (formatDetector.HeaderSize <= headersBuffer.Length && formatDetector.TryDetectFormat(headersBuffer, out IImageFormat? attemptFormat))
             {
-                format = attemptFormat;
+                return attemptFormat;
             }
         }
 
-        if (format is null)
-        {
-            ImageFormatManager.ThrowInvalidDecoder(configuration.ImageFormatsManager);
-        }
+        ImageFormatManager.ThrowInvalidDecoder(configuration.ImageFormatsManager);
 
-        return format;
+        // Need to write this otherwise compiler is not happy
+        return null;
     }
 
     /// <summary>