diff --git a/src/ImageSharp/Common/Helpers/Guard.cs b/src/ImageSharp/Common/Helpers/Guard.cs
index cd53e3d69a..d8cf69a52e 100644
--- a/src/ImageSharp/Common/Helpers/Guard.cs
+++ b/src/ImageSharp/Common/Helpers/Guard.cs
@@ -21,7 +21,6 @@ namespace SixLabors.ImageSharp
/// The name of the parameter that is to be checked.
/// is null
[MethodImpl(InliningOptions.ShortMethod)]
- [DebuggerStepThrough]
public static void NotNull(T value, string parameterName)
where T : class
{
@@ -39,7 +38,6 @@ namespace SixLabors.ImageSharp
/// is null.
/// is empty or contains only blanks.
[MethodImpl(InliningOptions.ShortMethod)]
- [DebuggerStepThrough]
public static void NotNullOrWhiteSpace(string value, string parameterName)
{
if (value is null)
@@ -62,7 +60,6 @@ namespace SixLabors.ImageSharp
/// is null.
/// is empty.
[MethodImpl(InliningOptions.ShortMethod)]
- [DebuggerStepThrough]
public static void NotNullOrEmpty(ICollection value, string parameterName)
{
if (value is null)
@@ -87,7 +84,6 @@ namespace SixLabors.ImageSharp
/// is greater than the maximum value.
///
[MethodImpl(InliningOptions.ShortMethod)]
- [DebuggerStepThrough]
public static void MustBeLessThan(TValue value, TValue max, string parameterName)
where TValue : IComparable
{
@@ -109,7 +105,6 @@ namespace SixLabors.ImageSharp
/// is greater than the maximum value.
///
[MethodImpl(InliningOptions.ShortMethod)]
- [DebuggerStepThrough]
public static void MustBeLessThanOrEqualTo(TValue value, TValue max, string parameterName)
where TValue : IComparable
{
@@ -131,7 +126,6 @@ namespace SixLabors.ImageSharp
/// is less than the minimum value.
///
[MethodImpl(InliningOptions.ShortMethod)]
- [DebuggerStepThrough]
public static void MustBeGreaterThan(TValue value, TValue min, string parameterName)
where TValue : IComparable
{
@@ -155,7 +149,6 @@ namespace SixLabors.ImageSharp
/// is less than the minimum value.
///
[MethodImpl(InliningOptions.ShortMethod)]
- [DebuggerStepThrough]
public static void MustBeGreaterThanOrEqualTo(TValue value, TValue min, string parameterName)
where TValue : IComparable
{
@@ -178,7 +171,6 @@ namespace SixLabors.ImageSharp
/// is less than the minimum value of greater than the maximum value.
///
[MethodImpl(InliningOptions.ShortMethod)]
- [DebuggerStepThrough]
public static void MustBeBetweenOrEqualTo(TValue value, TValue min, TValue max, string parameterName)
where TValue : IComparable
{
@@ -199,7 +191,6 @@ namespace SixLabors.ImageSharp
/// is false
///
[MethodImpl(InliningOptions.ShortMethod)]
- [DebuggerStepThrough]
public static void IsTrue(bool target, string parameterName, string message)
{
if (!target)
@@ -219,7 +210,6 @@ namespace SixLabors.ImageSharp
/// is true
///
[MethodImpl(InliningOptions.ShortMethod)]
- [DebuggerStepThrough]
public static void IsFalse(bool target, string parameterName, string message)
{
if (target)
@@ -239,7 +229,6 @@ namespace SixLabors.ImageSharp
/// has less than items
///
[MethodImpl(InliningOptions.ShortMethod)]
- [DebuggerStepThrough]
public static void MustBeSizedAtLeast(ReadOnlySpan source, int minLength, string parameterName)
{
if (source.Length < minLength)
@@ -257,7 +246,6 @@ namespace SixLabors.ImageSharp
/// The destination span
/// The name of the argument for 'destination'
[MethodImpl(InliningOptions.ShortMethod)]
- [DebuggerStepThrough]
public static void DestinationShouldNotBeTooShort(
ReadOnlySpan source,
Span destination,
@@ -280,7 +268,6 @@ namespace SixLabors.ImageSharp
/// has less than items
///
[MethodImpl(InliningOptions.ShortMethod)]
- [DebuggerStepThrough]
public static void MustBeSizedAtLeast(Span source, int minLength, string parameterName)
{
if (source.Length < minLength)
diff --git a/src/ImageSharp/PixelFormats/IPixel.cs b/src/ImageSharp/PixelFormats/IPixel.cs
index 13e35cce05..1277406869 100644
--- a/src/ImageSharp/PixelFormats/IPixel.cs
+++ b/src/ImageSharp/PixelFormats/IPixel.cs
@@ -24,93 +24,93 @@ namespace SixLabors.ImageSharp.PixelFormats
}
///
- /// An interface that represents a pixel type.
+ /// A base interface for all pixels, defining the mandatory operations to be implemented by a pixel type.
///
public interface IPixel
{
///
- /// Sets the packed representation from a scaled .
+ /// Initializes the pixel instance from a generic ("scaled") .
///
- /// The vector to create the packed representation from.
+ /// The vector to load the pixel from.
void FromScaledVector4(Vector4 vector);
///
- /// Expands the packed representation into a scaled
- /// with values clamped between 0 and 1.
+ /// Expands the pixel into a generic ("scaled") representation
+ /// with values scaled and clamped between 0 and 1.
/// The vector components are typically expanded in least to greatest significance order.
///
/// The .
Vector4 ToScaledVector4();
///
- /// Sets the packed representation from a .
+ /// Initializes the pixel instance from a which is specific to the current pixel type.
///
- /// The vector to create the packed representation from.
+ /// The vector to load the pixel from.
void FromVector4(Vector4 vector);
///
- /// Expands the packed representation into a .
+ /// Expands the pixel into a which is specific to the current pixel type.
/// The vector components are typically expanded in least to greatest significance order.
///
/// The .
Vector4 ToVector4();
///
- /// Packs the pixel from an value.
+ /// Initializes the pixel instance from an value.
///
/// The value.
void FromArgb32(Argb32 source);
///
- /// Packs the pixel from an value.
+ /// Initializes the pixel instance from an value.
///
/// The value.
void FromBgr24(Bgr24 source);
///
- /// Packs the pixel from an value.
+ /// Initializes the pixel instance from an value.
///
/// The value.
void FromBgra32(Bgra32 source);
///
- /// Packs the Pixel from an value.
+ /// Initializes the pixel instance from an value.
///
/// The value.
void FromGray8(Gray8 source);
///
- /// Packs the Pixel from an value.
+ /// Initializes the pixel instance from an value.
///
/// The value.
void FromGray16(Gray16 source);
///
- /// Packs the pixel from an value.
+ /// Initializes the pixel instance from an value.
///
/// The value.
void FromRgb24(Rgb24 source);
///
- /// Packs the pixel from an value.
+ /// Initializes the pixel instance from an value.
///
/// The value.
void FromRgba32(Rgba32 source);
///
- /// Expands the packed representation into an .
+ /// Convert the pixel instance into representation.
///
/// The reference to the destination pixel
void ToRgba32(ref Rgba32 dest);
///
- /// Packs the pixel from an value.
+ /// Initializes the pixel instance from an value.
///
/// The value.
void FromRgb48(Rgb48 source);
///
- /// Packs the pixel from an value.
+ /// Initializes the pixel instance from an value.
///
/// The value.
void FromRgba64(Rgba64 source);
diff --git a/src/ImageSharp/PixelFormats/PixelOperations{TPixel}.cs b/src/ImageSharp/PixelFormats/PixelOperations{TPixel}.cs
index ea03af683d..02b80de9b4 100644
--- a/src/ImageSharp/PixelFormats/PixelOperations{TPixel}.cs
+++ b/src/ImageSharp/PixelFormats/PixelOperations{TPixel}.cs
@@ -169,7 +169,7 @@ namespace SixLabors.ImageSharp.PixelFormats
return;
}
- // Normal converson
+ // Normal conversion
ref TDestinationPixel destRef = ref MemoryMarshal.GetReference(destinationColors);
for (int i = 0; i < count; i++)
{
diff --git a/tests/ImageSharp.Tests/Helpers/RowIntervalTests.cs b/tests/ImageSharp.Tests/Helpers/RowIntervalTests.cs
index f092da7082..629b3cdeb3 100644
--- a/tests/ImageSharp.Tests/Helpers/RowIntervalTests.cs
+++ b/tests/ImageSharp.Tests/Helpers/RowIntervalTests.cs
@@ -1,9 +1,9 @@
-using System;
-using System.Runtime.CompilerServices;
+// Copyright (c) Six Labors and contributors.
+// Licensed under the Apache License, Version 2.0.
+using System;
+using System.Runtime.CompilerServices;
using SixLabors.ImageSharp.Memory;
-using SixLabors.Memory;
-
using Xunit;
namespace SixLabors.ImageSharp.Tests.Helpers
@@ -35,4 +35,4 @@ namespace SixLabors.ImageSharp.Tests.Helpers
}
}
}
-}
\ No newline at end of file
+}
diff --git a/tests/ImageSharp.Tests/Numerics/RationalTests.cs b/tests/ImageSharp.Tests/Numerics/RationalTests.cs
index a9b9106c5c..caddd49216 100644
--- a/tests/ImageSharp.Tests/Numerics/RationalTests.cs
+++ b/tests/ImageSharp.Tests/Numerics/RationalTests.cs
@@ -1,7 +1,6 @@
// Copyright (c) Six Labors and contributors.
// Licensed under the Apache License, Version 2.0.
-using SixLabors.ImageSharp.MetaData.Profiles.Exif;
using SixLabors.ImageSharp.Primitives;
using Xunit;
diff --git a/tests/ImageSharp.Tests/TestUtilities/TestDataGenerator.cs b/tests/ImageSharp.Tests/TestUtilities/TestDataGenerator.cs
index 912b86e347..56cde41fc1 100644
--- a/tests/ImageSharp.Tests/TestUtilities/TestDataGenerator.cs
+++ b/tests/ImageSharp.Tests/TestUtilities/TestDataGenerator.cs
@@ -1,10 +1,24 @@
-using System;
+// Copyright (c) Six Labors and contributors.
+// Licensed under the Apache License, Version 2.0.
+
+using System;
using System.Numerics;
namespace SixLabors.ImageSharp.Tests
{
+ ///
+ /// Helper methods that allow the creation of random test data.
+ ///
internal static class TestDataGenerator
{
+ ///
+ /// Creates an of the given length consisting of random values between the two ranges.
+ ///
+ /// The pseudo-random number generator.
+ /// The length.
+ /// The minimum value.
+ /// The maximum value.
+ /// The .
public static float[] GenerateRandomFloatArray(this Random rnd, int length, float minVal, float maxVal)
{
float[] values = new float[length];
@@ -17,6 +31,14 @@ namespace SixLabors.ImageSharp.Tests
return values;
}
+ ///
+ /// Creates an of the given length consisting of random values between the two ranges.
+ ///
+ /// The pseudo-random number generator.
+ /// The length.
+ /// The minimum value.
+ /// The maximum value.
+ /// The .
public static Vector4[] GenerateRandomVectorArray(this Random rnd, int length, float minVal, float maxVal)
{
var values = new Vector4[length];
@@ -33,20 +55,32 @@ namespace SixLabors.ImageSharp.Tests
return values;
}
+ ///
+ /// Creates an of the given length consisting of rounded random values between the two ranges.
+ ///
+ /// The pseudo-random number generator.
+ /// The length.
+ /// The minimum value.
+ /// The maximum value.
+ /// The .
public static float[] GenerateRandomRoundedFloatArray(this Random rnd, int length, float minVal, float maxVal)
{
float[] values = new float[length];
for (int i = 0; i < length; i++)
{
- values[i] = (float) Math.Round(rnd.GetRandomFloat(minVal, maxVal));
+ values[i] = (float)Math.Round(rnd.GetRandomFloat(minVal, maxVal));
}
return values;
}
-
-
+ ///
+ /// Creates an of the given length consisting of random values.
+ ///
+ /// The pseudo-random number generator.
+ /// The length.
+ /// The .
public static byte[] GenerateRandomByteArray(this Random rnd, int length)
{
byte[] values = new byte[length];
@@ -54,9 +88,6 @@ namespace SixLabors.ImageSharp.Tests
return values;
}
- private static float GetRandomFloat(this Random rnd, float minVal, float maxVal)
- {
- return (float)rnd.NextDouble() * (maxVal - minVal) + minVal;
- }
+ private static float GetRandomFloat(this Random rnd, float minVal, float maxVal) => ((float)rnd.NextDouble() * (maxVal - minVal)) + minVal;
}
}
\ No newline at end of file