diff --git a/src/ImageSharp/Processing/DetectEdgesExtensions.cs b/src/ImageSharp/Processing/DetectEdgesExtensions.cs
index 5ac89df29..a3be298d0 100644
--- a/src/ImageSharp/Processing/DetectEdgesExtensions.cs
+++ b/src/ImageSharp/Processing/DetectEdgesExtensions.cs
@@ -2,6 +2,7 @@
// Licensed under the Apache License, Version 2.0.
using SixLabors.ImageSharp.PixelFormats;
+using SixLabors.ImageSharp.Processing.Processors;
using SixLabors.ImageSharp.Processing.Processors.Convolution;
using SixLabors.Primitives;
@@ -82,7 +83,7 @@ namespace SixLabors.ImageSharp.Processing
/// The image this method extends.
/// The filter for detecting edges.
/// The .
- public static IImageProcessingContext DetectEdges(this IImageProcessingContext source, IEdgeDetectorProcessor filter)
+ private static IImageProcessingContext DetectEdges(this IImageProcessingContext source, IImageProcessor filter)
where TPixel : struct, IPixel
{
return source.ApplyProcessor(filter);
@@ -98,17 +99,17 @@ namespace SixLabors.ImageSharp.Processing
///
/// The filter for detecting edges.
/// The .
- public static IImageProcessingContext DetectEdges(this IImageProcessingContext source, Rectangle rectangle, IEdgeDetectorProcessor filter)
+ private static IImageProcessingContext DetectEdges(this IImageProcessingContext source, Rectangle rectangle, IImageProcessor filter)
where TPixel : struct, IPixel
{
source.ApplyProcessor(filter, rectangle);
return source;
}
- private static IEdgeDetectorProcessor GetProcessor(EdgeDetectionOperators filter, bool grayscale)
+ private static IImageProcessor GetProcessor(EdgeDetectionOperators filter, bool grayscale)
where TPixel : struct, IPixel
{
- IEdgeDetectorProcessor processor;
+ IImageProcessor processor;
switch (filter)
{
diff --git a/src/ImageSharp/Processing/Processors/Convolution/BoxBlurProcessor{TPixel}.cs b/src/ImageSharp/Processing/Processors/Convolution/BoxBlurProcessor{TPixel}.cs
index ba092cb42..f4252e840 100644
--- a/src/ImageSharp/Processing/Processors/Convolution/BoxBlurProcessor{TPixel}.cs
+++ b/src/ImageSharp/Processing/Processors/Convolution/BoxBlurProcessor{TPixel}.cs
@@ -1,5 +1,5 @@
-// // Copyright (c) Six Labors and contributors.
-// // Licensed under the Apache License, Version 2.0.
+// Copyright (c) Six Labors and contributors.
+// Licensed under the Apache License, Version 2.0.
using SixLabors.ImageSharp.PixelFormats;
using SixLabors.ImageSharp.Primitives;
@@ -38,7 +38,6 @@ namespace SixLabors.ImageSharp.Processing.Processors.Convolution
///
public DenseMatrix KernelY { get; }
-
///
protected override void OnFrameApply(
ImageFrame source,
diff --git a/src/ImageSharp/Processing/Processors/Convolution/ConvolutionProcessorHelpers.cs b/src/ImageSharp/Processing/Processors/Convolution/ConvolutionProcessorHelpers.cs
index bb0072b82..1fb26c976 100644
--- a/src/ImageSharp/Processing/Processors/Convolution/ConvolutionProcessorHelpers.cs
+++ b/src/ImageSharp/Processing/Processors/Convolution/ConvolutionProcessorHelpers.cs
@@ -1,5 +1,5 @@
-// // Copyright (c) Six Labors and contributors.
-// // Licensed under the Apache License, Version 2.0.
+// Copyright (c) Six Labors and contributors.
+// Licensed under the Apache License, Version 2.0.
using System;
@@ -11,7 +11,7 @@ namespace SixLabors.ImageSharp.Processing.Processors.Convolution
{
///
/// Kernel radius is calculated using the minimum viable value.
- /// .
+ /// See http://chemaguerra.com/gaussian-filter-radius/ .
///
internal static int GetDefaultGaussianRadius(float sigma)
{
@@ -19,7 +19,7 @@ namespace SixLabors.ImageSharp.Processing.Processors.Convolution
}
///
- /// Create a 1 dimensional Gaussian kernel using the Gaussian G(x) function
+ /// Create a 1 dimensional Gaussian kernel using the Gaussian G(x) function.
///
/// The .
internal static DenseMatrix CreateGaussianBlurKernel(int size, float weight)
diff --git a/src/ImageSharp/Processing/Processors/Convolution/EdgeDetector2DProcessor.cs b/src/ImageSharp/Processing/Processors/Convolution/EdgeDetector2DProcessor.cs
index b4ac89139..ef185a01f 100644
--- a/src/ImageSharp/Processing/Processors/Convolution/EdgeDetector2DProcessor.cs
+++ b/src/ImageSharp/Processing/Processors/Convolution/EdgeDetector2DProcessor.cs
@@ -12,7 +12,7 @@ namespace SixLabors.ImageSharp.Processing.Processors.Convolution
/// Defines a processor that detects edges within an image using two one-dimensional matrices.
///
/// The pixel format.
- internal abstract class EdgeDetector2DProcessor : ImageProcessor, IEdgeDetectorProcessor
+ internal abstract class EdgeDetector2DProcessor : ImageProcessor
where TPixel : struct, IPixel
{
///
diff --git a/src/ImageSharp/Processing/Processors/Convolution/EdgeDetectorCompassProcessor.cs b/src/ImageSharp/Processing/Processors/Convolution/EdgeDetectorCompassProcessor.cs
index aa33699f5..1205b02dc 100644
--- a/src/ImageSharp/Processing/Processors/Convolution/EdgeDetectorCompassProcessor.cs
+++ b/src/ImageSharp/Processing/Processors/Convolution/EdgeDetectorCompassProcessor.cs
@@ -19,7 +19,7 @@ namespace SixLabors.ImageSharp.Processing.Processors.Convolution
/// Defines a processor that detects edges within an image using a eight two dimensional matrices.
///
/// The pixel format.
- internal abstract class EdgeDetectorCompassProcessor : ImageProcessor, IEdgeDetectorProcessor
+ internal abstract class EdgeDetectorCompassProcessor : ImageProcessor
where TPixel : struct, IPixel
{
///
diff --git a/src/ImageSharp/Processing/Processors/Convolution/EdgeDetectorProcessor.cs b/src/ImageSharp/Processing/Processors/Convolution/EdgeDetectorProcessor.cs
index 9ec79da9e..b4d4763d0 100644
--- a/src/ImageSharp/Processing/Processors/Convolution/EdgeDetectorProcessor.cs
+++ b/src/ImageSharp/Processing/Processors/Convolution/EdgeDetectorProcessor.cs
@@ -12,7 +12,7 @@ namespace SixLabors.ImageSharp.Processing.Processors.Convolution
/// Defines a processor that detects edges within an image using a single two dimensional matrix.
///
/// The pixel format.
- internal abstract class EdgeDetectorProcessor : ImageProcessor, IEdgeDetectorProcessor
+ internal abstract class EdgeDetectorProcessor : ImageProcessor
where TPixel : struct, IPixel
{
///
diff --git a/src/ImageSharp/Processing/Processors/Convolution/GaussianSharpenProcessor.cs b/src/ImageSharp/Processing/Processors/Convolution/GaussianSharpenProcessor.cs
index bc06ee618..84e56869d 100644
--- a/src/ImageSharp/Processing/Processors/Convolution/GaussianSharpenProcessor.cs
+++ b/src/ImageSharp/Processing/Processors/Convolution/GaussianSharpenProcessor.cs
@@ -70,6 +70,7 @@ namespace SixLabors.ImageSharp.Processing.Processors.Convolution
///
public int Radius { get; }
+ ///
public IImageProcessor CreatePixelSpecificProcessor()
where TPixel : struct, IPixel
{
diff --git a/src/ImageSharp/Processing/Processors/Convolution/IEdgeDetectorProcessor.cs b/src/ImageSharp/Processing/Processors/Convolution/IEdgeDetectorProcessor.cs
deleted file mode 100644
index b2ecbf115..000000000
--- a/src/ImageSharp/Processing/Processors/Convolution/IEdgeDetectorProcessor.cs
+++ /dev/null
@@ -1,28 +0,0 @@
-// Copyright (c) Six Labors and contributors.
-// Licensed under the Apache License, Version 2.0.
-
-using SixLabors.ImageSharp.PixelFormats;
-using SixLabors.ImageSharp.Processing.Processors;
-
-namespace SixLabors.ImageSharp.Processing.Processors.Convolution
-{
- ///
- /// Provides properties and methods allowing the detection of edges within an image.
- ///
- /// The pixel format.
- public interface IEdgeDetectorProcessor : IImageProcessor, IEdgeDetectorProcessor
- where TPixel : struct, IPixel
- {
- }
-
- ///
- /// Provides properties and methods allowing the detection of edges within an image.
- ///
- public interface IEdgeDetectorProcessor
- {
- ///
- /// Gets a value indicating whether to convert the image to grayscale before performing edge detection.
- ///
- bool Grayscale { get; }
- }
-}
\ No newline at end of file
diff --git a/src/ImageSharp/Processing/Processors/IImageProcessor{TPixel}.cs b/src/ImageSharp/Processing/Processors/IImageProcessor{TPixel}.cs
index f2c7ef29c..90dfaf8db 100644
--- a/src/ImageSharp/Processing/Processors/IImageProcessor{TPixel}.cs
+++ b/src/ImageSharp/Processing/Processors/IImageProcessor{TPixel}.cs
@@ -1,5 +1,5 @@
-// // Copyright (c) Six Labors and contributors.
-// // Licensed under the Apache License, Version 2.0.
+// Copyright (c) Six Labors and contributors.
+// Licensed under the Apache License, Version 2.0.
using SixLabors.ImageSharp.PixelFormats;
using SixLabors.Primitives;
diff --git a/src/ImageSharp/Processing/Processors/ImageProcessorExtensions.cs b/src/ImageSharp/Processing/Processors/ImageProcessorExtensions.cs
index 1e189b9c7..762d761c6 100644
--- a/src/ImageSharp/Processing/Processors/ImageProcessorExtensions.cs
+++ b/src/ImageSharp/Processing/Processors/ImageProcessorExtensions.cs
@@ -1,5 +1,5 @@
-// // Copyright (c) Six Labors and contributors.
-// // Licensed under the Apache License, Version 2.0.
+// Copyright (c) Six Labors and contributors.
+// Licensed under the Apache License, Version 2.0.
using SixLabors.ImageSharp.PixelFormats;
using SixLabors.Primitives;
diff --git a/src/ImageSharp/Processing/Processors/Transforms/Resize/ResizeProcessor.cs b/src/ImageSharp/Processing/Processors/Transforms/Resize/ResizeProcessor.cs
index 5710c4bd8..8762d6b26 100644
--- a/src/ImageSharp/Processing/Processors/Transforms/Resize/ResizeProcessor.cs
+++ b/src/ImageSharp/Processing/Processors/Transforms/Resize/ResizeProcessor.cs
@@ -9,7 +9,7 @@ using SixLabors.Primitives;
namespace SixLabors.ImageSharp.Processing.Processors.Transforms
{
///
- /// Implements resizing of images using various resamplers.
+ /// Defines an image resizing operation with the given and dimensional parameters.
///
public class ResizeProcessor : IImageProcessor
{
diff --git a/tests/ImageSharp.Tests/Processing/Convolution/DetectEdgesTest.cs b/tests/ImageSharp.Tests/Processing/Convolution/DetectEdgesTest.cs
index 60fa19b49..cf5feac27 100644
--- a/tests/ImageSharp.Tests/Processing/Convolution/DetectEdgesTest.cs
+++ b/tests/ImageSharp.Tests/Processing/Convolution/DetectEdgesTest.cs
@@ -50,7 +50,7 @@ namespace SixLabors.ImageSharp.Tests.Processing.Convolution
[Theory]
[MemberData(nameof(EdgeDetectionTheoryData))]
public void DetectEdges_filter_SobelProcessorDefaultsSet(TestType type, EdgeDetectionOperators filter)
- where TProcessor : IEdgeDetectorProcessor
+ where TProcessor : IImageProcessor
{
this.operations.DetectEdges(filter);
@@ -62,7 +62,7 @@ namespace SixLabors.ImageSharp.Tests.Processing.Convolution
[Theory]
[MemberData(nameof(EdgeDetectionTheoryData))]
public void DetectEdges_filter_grayscale_SobelProcessorDefaultsSet(TestType type, EdgeDetectionOperators filter)
- where TProcessor : IEdgeDetectorProcessor
+ where TProcessor : IImageProcessor
{
bool grey = (int)filter % 2 == 0;
this.operations.DetectEdges(filter, grey);