Browse Source

Return empty string instead of null.

pull/753/head
Dirk Lemstra 7 years ago
parent
commit
a2a4bcbfab
No known key found for this signature in database GPG Key ID: 57FEA4B5173E68
  1. 2
      src/ImageSharp/Common/Extensions/EncoderExtensions.cs
  2. 4
      tests/ImageSharp.Tests/Common/EncoderExtensionsTests.cs

2
src/ImageSharp/Common/Extensions/EncoderExtensions.cs

@ -22,7 +22,7 @@ namespace SixLabors.ImageSharp
{ {
if (buffer.Length == 0) if (buffer.Length == 0)
{ {
return null; return string.Empty;
} }
fixed (byte* bytes = buffer) fixed (byte* bytes = buffer)

4
tests/ImageSharp.Tests/Common/EncoderExtensionsTests.cs

@ -10,13 +10,13 @@ namespace SixLabors.ImageSharp.Tests.Common
public class EncoderExtensionsTests public class EncoderExtensionsTests
{ {
[Fact] [Fact]
public void GetString_EmptyBuffer_ReturnsNull() public void GetString_EmptyBuffer_ReturnsEmptyString()
{ {
var buffer = new ReadOnlySpan<byte>(); var buffer = new ReadOnlySpan<byte>();
string result = Encoding.UTF8.GetString(buffer); string result = Encoding.UTF8.GetString(buffer);
Assert.Null(result); Assert.Equal(string.Empty, result);
} }
[Fact] [Fact]

Loading…
Cancel
Save