From afec8c65ba1cc41201d17ffae067d66e9deb4362 Mon Sep 17 00:00:00 2001 From: Jason Nelson Date: Wed, 22 Aug 2018 14:39:09 -0700 Subject: [PATCH 1/8] Update dotnet SDK --- .travis.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index 5a146cea6..2515ca82a 100644 --- a/.travis.yml +++ b/.travis.yml @@ -6,7 +6,7 @@ matrix: - os: linux # Ubuntu 14.04 dist: trusty sudo: required - dotnet: 2.1.300 + dotnet: 2.1.401 mono: latest # - os: osx # OSX 10.11 # osx_image: xcode7.3.1 From bddacf1cecd348bd4b1982dae522685339472214 Mon Sep 17 00:00:00 2001 From: Jason Nelson Date: Wed, 22 Aug 2018 14:39:24 -0700 Subject: [PATCH 2/8] Drop netcoreapp2.0 test target --- appveyor.yml | 5 ----- 1 file changed, 5 deletions(-) diff --git a/appveyor.yml b/appveyor.yml index 5d84e6cea..fccac0c44 100644 --- a/appveyor.yml +++ b/appveyor.yml @@ -12,9 +12,6 @@ environment: - target_framework: netcoreapp2.1 is_32bit: True - - target_framework: netcoreapp2.0 - is_32bit: False - - target_framework: net471 is_32bit: False @@ -27,8 +24,6 @@ environment: - target_framework: net462 is_32bit: True - #- target_framework: netcoreapp2.0 # As far as I understand, 32 bit test execution is not supported by "dotnet xunit" - # is_32bit: True #- target_framework: mono # is_32bit: False #- target_framework: mono From 0954df11b078be6bf92ecdeb30aa513740490631 Mon Sep 17 00:00:00 2001 From: Jason Nelson Date: Wed, 22 Aug 2018 14:39:39 -0700 Subject: [PATCH 3/8] Drop netcoreapp2.0 build target --- tests/ImageSharp.Tests/ImageSharp.Tests.csproj | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/ImageSharp.Tests/ImageSharp.Tests.csproj b/tests/ImageSharp.Tests/ImageSharp.Tests.csproj index d153ecf50..38a9e2700 100644 --- a/tests/ImageSharp.Tests/ImageSharp.Tests.csproj +++ b/tests/ImageSharp.Tests/ImageSharp.Tests.csproj @@ -1,8 +1,8 @@  - net471;netcoreapp2.0;netcoreapp2.1;net47;net462 + net471;netcoreapp2.1;net47;net462 True - 7.2 + 7.3 full portable True From e7a701f85e7e9dd0a1a81f90d630dd7fa4cb6cfc Mon Sep 17 00:00:00 2001 From: Jason Nelson Date: Thu, 23 Aug 2018 07:06:12 -0700 Subject: [PATCH 4/8] Drop net47 from test library --- tests/ImageSharp.Tests/ImageSharp.Tests.csproj | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/ImageSharp.Tests/ImageSharp.Tests.csproj b/tests/ImageSharp.Tests/ImageSharp.Tests.csproj index 38a9e2700..5ef8f0111 100644 --- a/tests/ImageSharp.Tests/ImageSharp.Tests.csproj +++ b/tests/ImageSharp.Tests/ImageSharp.Tests.csproj @@ -1,6 +1,6 @@  - net471;netcoreapp2.1;net47;net462 + net462;net471;netcoreapp2.1 True 7.3 full From 90fbef6b172d9e5d2a76a9664d5945b689451ae0 Mon Sep 17 00:00:00 2001 From: Jason Nelson Date: Thu, 23 Aug 2018 07:15:05 -0700 Subject: [PATCH 5/8] Add run-tests.ps1 to Solution --- ImageSharp.sln | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/ImageSharp.sln b/ImageSharp.sln index 3ff5b09d4..0291d9f93 100644 --- a/ImageSharp.sln +++ b/ImageSharp.sln @@ -1,7 +1,6 @@  Microsoft Visual Studio Solution File, Format Version 12.00 # Visual Studio 15 -VisualStudioVersion = 15.0.26730.3 VisualStudioVersion = 15.0.26730.12 MinimumVisualStudioVersion = 10.0.40219.1 Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "SolutionItems", "SolutionItems", "{C317F1B1-D75E-4C6D-83EB-80367343E0D7}" @@ -19,6 +18,7 @@ Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "SolutionItems", "SolutionIt NuGet.config = NuGet.config .github\PULL_REQUEST_TEMPLATE.md = .github\PULL_REQUEST_TEMPLATE.md README.md = README.md + run-tests.ps1 = run-tests.ps1 EndProjectSection EndProject Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Source", "Source", "{815C0625-CD3D-440F-9F80-2D83856AB7AE}" @@ -46,9 +46,6 @@ EndProject Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "ImageSharp.Sandbox46", "tests\ImageSharp.Sandbox46\ImageSharp.Sandbox46.csproj", "{561B880A-D9EE-44EF-90F5-817C54A9D9AB}" EndProject Global - GlobalSection(Performance) = preSolution - HasPerformanceSessions = true - EndGlobalSection GlobalSection(SolutionConfigurationPlatforms) = preSolution Debug|Any CPU = Debug|Any CPU Debug|x64 = Debug|x64 @@ -133,4 +130,7 @@ Global GlobalSection(ExtensibilityGlobals) = postSolution SolutionGuid = {5F8B9D1F-CD8B-4CC5-8216-D531E25BD795} EndGlobalSection + GlobalSection(Performance) = preSolution + HasPerformanceSessions = true + EndGlobalSection EndGlobal From 29fc3c2a8209743b5184272edacce7383daac9f0 Mon Sep 17 00:00:00 2001 From: Jason Nelson Date: Thu, 23 Aug 2018 07:15:18 -0700 Subject: [PATCH 6/8] Update run-tests.ps1 to use .NETCORE2.1 --- run-tests.ps1 | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/run-tests.ps1 b/run-tests.ps1 index 3218d9d67..4aeaa1490 100644 --- a/run-tests.ps1 +++ b/run-tests.ps1 @@ -41,8 +41,8 @@ function CheckSubmoduleStatus() { } -if ( ($targetFramework -eq "netcoreapp2.0") -and ($env:CI -eq "True") -and ($is32Bit -ne "True")) { - # We execute CodeCoverage.cmd only for one specific job on CI (netcoreapp2.0 + 64bit ) +if ( ($targetFramework -eq "netcoreapp2.1") -and ($env:CI -eq "True") -and ($is32Bit -ne "True")) { + # We execute CodeCoverage.cmd only for one specific job on CI (netcoreapp2.1 + 64bit ) $testRunnerCmd = ".\tests\CodeCoverage\CodeCoverage.cmd" } elseif ($targetFramework -eq "mono") { @@ -70,11 +70,6 @@ else { cd .\tests\ImageSharp.Tests $xunitArgs = "-nobuild -c Release -framework $targetFramework" - if ($targetFramework -eq "netcoreapp2.0") { - # There were issues matching the correct installed runtime if we do not specify it explicitly: - $xunitArgs += " --fx-version 2.0.0" - } - if ($targetFramework -eq "netcoreapp2.1") { # There were issues matching the correct installed runtime if we do not specify it explicitly: $xunitArgs += " --fx-version 2.1.0" From 299a8c2bafc768338d08a3ce9e8592074a88f584 Mon Sep 17 00:00:00 2001 From: Jason Nelson Date: Thu, 23 Aug 2018 07:27:56 -0700 Subject: [PATCH 7/8] Update CodeCoverage to use .NETCORE2.1 --- tests/CodeCoverage/CodeCoverage.cmd | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/CodeCoverage/CodeCoverage.cmd b/tests/CodeCoverage/CodeCoverage.cmd index f0ed3da1b..01e342b3d 100644 --- a/tests/CodeCoverage/CodeCoverage.cmd +++ b/tests/CodeCoverage/CodeCoverage.cmd @@ -12,7 +12,7 @@ dotnet restore ImageSharp.sln rem Clean the solution to force a rebuild with /p:codecov=true dotnet clean ImageSharp.sln -c Release rem The -threshold options prevents this taking ages... -tests\CodeCoverage\OpenCover.4.6.519\tools\OpenCover.Console.exe -target:"dotnet.exe" -targetargs:"test tests\ImageSharp.Tests\ImageSharp.Tests.csproj -c Release -f netcoreapp2.0 /p:codecov=true" -register:user -threshold:10 -oldStyle -safemode:off -output:.\ImageSharp.Coverage.xml -hideskipped:All -returntargetcode -filter:"+[SixLabors.ImageSharp*]*" +tests\CodeCoverage\OpenCover.4.6.519\tools\OpenCover.Console.exe -target:"dotnet.exe" -targetargs:"test tests\ImageSharp.Tests\ImageSharp.Tests.csproj -c Release -f netcoreapp2.1 /p:codecov=true" -register:user -threshold:10 -oldStyle -safemode:off -output:.\ImageSharp.Coverage.xml -hideskipped:All -returntargetcode -filter:"+[SixLabors.ImageSharp*]*" if %errorlevel% neq 0 exit /b %errorlevel% From d9e86a8e0509923958baed136c994bfde1267607 Mon Sep 17 00:00:00 2001 From: Jason Nelson Date: Thu, 23 Aug 2018 07:33:26 -0700 Subject: [PATCH 8/8] Update manual build nstructions in README --- README.md | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/README.md b/README.md index b54a9b207..a420c07c8 100644 --- a/README.md +++ b/README.md @@ -117,12 +117,9 @@ For more examples check out: If you prefer, you can compile ImageSharp yourself (please do and help!) -- Using [Visual Studio 2017 Preview](https://docs.microsoft.com/en-us/visualstudio/releasenotes/vs2017-preview-relnotes) +- Using [Visual Studio 2017](https://visualstudio.microsoft.com/vs/) - Make sure you have the latest version installed - - Make sure you have [the newest 2.1 RC1 SDK installed](https://www.microsoft.com/net/core#windows) - -- Using [Visual Studio 2017](https://www.visualstudio.com/en-us/news/releasenotes/vs2017-relnotes) - - If you are unable and/or don't want to build ImageSharp.Tests against 2.1 RC, remove the `netcoreapp2.1` target [from TargetFrameworks](https://github.com/SixLabors/ImageSharp/blob/master/tests/ImageSharp.Tests/ImageSharp.Tests.csproj#L3) locally + - Make sure you have [the .NET Core 2.1 SDK](https://www.microsoft.com/net/core#windows) installed Alternatively, you can work from command line and/or with a lightweight editor on **both Linux/Unix and Windows**: