From ca035582f9c91fa59d00c41f3573ffdc0ea6c209 Mon Sep 17 00:00:00 2001 From: James Jackson-South Date: Thu, 10 Nov 2016 22:05:57 +1100 Subject: [PATCH] Fix test names --- src/ImageSharp/Formats/Png/PngDecoderCore.cs | 4 +++- tests/ImageSharp.Benchmarks/Image/EncodeBmp.cs | 4 ++-- tests/ImageSharp.Benchmarks/Image/EncodeGif.cs | 4 ++-- tests/ImageSharp.Benchmarks/Image/EncodePng.cs | 4 ++-- 4 files changed, 9 insertions(+), 7 deletions(-) diff --git a/src/ImageSharp/Formats/Png/PngDecoderCore.cs b/src/ImageSharp/Formats/Png/PngDecoderCore.cs index cad32d9f2..2ee994d30 100644 --- a/src/ImageSharp/Formats/Png/PngDecoderCore.cs +++ b/src/ImageSharp/Formats/Png/PngDecoderCore.cs @@ -283,7 +283,9 @@ namespace ImageSharp.Formats FilterType filterType = (FilterType)scanline[0]; byte[] defilteredScanline; - // TODO: It would be good if we can reduce the memory usage here. Each filter is creating a new row. + // TODO: It would be good if we can reduce the memory usage here - Each filter is creating a new row. + // Every time I try to use the same approach as I have in the encoder though I keep messing up. + // Fingers crossed someone with a big brain and a kind heart will come along and finish optimizing this for me. switch (filterType) { case FilterType.None: diff --git a/tests/ImageSharp.Benchmarks/Image/EncodeBmp.cs b/tests/ImageSharp.Benchmarks/Image/EncodeBmp.cs index 7e2060ce9..261a7f269 100644 --- a/tests/ImageSharp.Benchmarks/Image/EncodeBmp.cs +++ b/tests/ImageSharp.Benchmarks/Image/EncodeBmp.cs @@ -32,7 +32,7 @@ namespace ImageSharp.Benchmarks.Image } [Benchmark(Baseline = true, Description = "System.Drawing Bmp")] - public void JpegSystemDrawing() + public void BmpSystemDrawing() { using (MemoryStream memoryStream = new MemoryStream()) { @@ -41,7 +41,7 @@ namespace ImageSharp.Benchmarks.Image } [Benchmark(Description = "ImageSharp Bmp")] - public void JpegCore() + public void BmpCore() { using (MemoryStream memoryStream = new MemoryStream()) { diff --git a/tests/ImageSharp.Benchmarks/Image/EncodeGif.cs b/tests/ImageSharp.Benchmarks/Image/EncodeGif.cs index 7128089f9..e2acb4db5 100644 --- a/tests/ImageSharp.Benchmarks/Image/EncodeGif.cs +++ b/tests/ImageSharp.Benchmarks/Image/EncodeGif.cs @@ -32,7 +32,7 @@ namespace ImageSharp.Benchmarks.Image } [Benchmark(Baseline = true, Description = "System.Drawing Gif")] - public void JpegSystemDrawing() + public void GifSystemDrawing() { using (MemoryStream memoryStream = new MemoryStream()) { @@ -41,7 +41,7 @@ namespace ImageSharp.Benchmarks.Image } [Benchmark(Description = "ImageSharp Gif")] - public void JpegCore() + public void GifCore() { using (MemoryStream memoryStream = new MemoryStream()) { diff --git a/tests/ImageSharp.Benchmarks/Image/EncodePng.cs b/tests/ImageSharp.Benchmarks/Image/EncodePng.cs index d9a83f556..52d953775 100644 --- a/tests/ImageSharp.Benchmarks/Image/EncodePng.cs +++ b/tests/ImageSharp.Benchmarks/Image/EncodePng.cs @@ -32,7 +32,7 @@ namespace ImageSharp.Benchmarks.Image } [Benchmark(Baseline = true, Description = "System.Drawing Png")] - public void JpegSystemDrawing() + public void PngSystemDrawing() { using (MemoryStream memoryStream = new MemoryStream()) { @@ -41,7 +41,7 @@ namespace ImageSharp.Benchmarks.Image } [Benchmark(Description = "ImageSharp Png")] - public void JpegCore() + public void PngCore() { using (MemoryStream memoryStream = new MemoryStream()) {