tsai
/
ImageSharp
mirror of https://github.com/SixLabors/ImageSharp
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
Browse Source

Avoid bounds checks

pull/1848/head
Brian Popow 4 years ago
parent
bab85d4372
commit
cc430cc846
1 changed files with 24 additions and 37 deletions
Whitespace
Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL
Split View
Diff Options
Show Stats Download Patch File Download Diff File
  1. 61
      src/ImageSharp/Formats/Webp/Lossless/LosslessUtils.cs

61
src/ImageSharp/Formats/Webp/Lossless/LosslessUtils.cs
View File

@ -783,39 +783,39 @@ namespace SixLabors.ImageSharp.Formats.Webp.Lossless
// Analyze the different X + Y.
Unsafe.As<int, Vector128<int>>(ref tmpRef) = xy128;
if (tmp[0] != 0)
if (tmpRef != 0)
{
retVal -= FastSLog2((uint)tmp[0]);
if (x[i + 0] != 0)
retVal -= FastSLog2((uint)tmpRef);
if (Unsafe.Add(ref xRef, i) != 0)
{
retVal -= FastSLog2((uint)x[i + 0]);
retVal -= FastSLog2((uint)Unsafe.Add(ref xRef, i));
}
}
if (tmp[1] != 0)
if (Unsafe.Add(ref tmpRef, 1) != 0)
{
retVal -= FastSLog2((uint)tmp[1]);
if (x[i + 1] != 0)
retVal -= FastSLog2((uint)Unsafe.Add(ref tmpRef, 1));
if (Unsafe.Add(ref xRef, i + 1) != 0)
{
retVal -= FastSLog2((uint)x[i + 1]);
retVal -= FastSLog2((uint)Unsafe.Add(ref xRef, i + 1));
}
}
if (tmp[2] != 0)
if (Unsafe.Add(ref tmpRef, 2) != 0)
{
retVal -= FastSLog2((uint)tmp[2]);
if (x[i + 2] != 0)
retVal -= FastSLog2((uint)Unsafe.Add(ref tmpRef, 2));
if (Unsafe.Add(ref xRef, i + 2) != 0)
{
retVal -= FastSLog2((uint)x[i + 2]);
retVal -= FastSLog2((uint)Unsafe.Add(ref xRef, i + 2));
}
}
if (tmp[3] != 0)
if (Unsafe.Add(ref tmpRef, 3) != 0)
{
retVal -= FastSLog2((uint)tmp[3]);
if (x[i + 3] != 0)
retVal -= FastSLog2((uint)Unsafe.Add(ref tmpRef, 3));
if (Unsafe.Add(ref xRef, i + 3) != 0)
{
retVal -= FastSLog2((uint)x[i + 3]);
retVal -= FastSLog2((uint)Unsafe.Add(ref xRef, i + 3));
}
}
}
@ -824,24 +824,24 @@ namespace SixLabors.ImageSharp.Formats.Webp.Lossless
// X is fully 0, so only deal with Y.
sumXY128 = Sse2.Add(sumXY128, yVec);
if (y[i] != 0)
if (Unsafe.Add(ref yRef, i) != 0)
{
retVal -= FastSLog2((uint)y[i]);
retVal -= FastSLog2((uint)Unsafe.Add(ref yRef, i));
}
if (y[i + 1] != 0)
if (Unsafe.Add(ref yRef, i + 1) != 0)
{
retVal -= FastSLog2((uint)y[i + 1]);
retVal -= FastSLog2((uint)Unsafe.Add(ref yRef, i + 1));
}
if (y[i + 2] != 0)
if (Unsafe.Add(ref yRef, i + 2) != 0)
{
retVal -= FastSLog2((uint)y[i + 2]);
retVal -= FastSLog2((uint)Unsafe.Add(ref yRef, i + 2));
}
if (y[i + 3] != 0)
if (Unsafe.Add(ref yRef, i + 3) != 0)
{
retVal -= FastSLog2((uint)y[i + 3]);
retVal -= FastSLog2((uint)Unsafe.Add(ref yRef, i + 3));
}
}
}
@ -889,19 +889,6 @@ namespace SixLabors.ImageSharp.Formats.Webp.Lossless
}
}
[MethodImpl(InliningOptions.ShortMethod)]
private static void AnalyzeXy(Span<int> tmp, Span<int> x, int i, int pos, ref double retVal)
{
if (tmp[pos] != 0)
{
retVal -= FastSLog2((uint)tmp[pos]);
if (x[i + pos] != 0)
{
retVal -= FastSLog2((uint)x[i + pos]);
}
}
}
[MethodImpl(InliningOptions.ShortMethod)]
public static byte TransformColorRed(sbyte greenToRed, uint argb)
{

Write Preview
Loading…
Cancel
Save