From cf13ebfe190dcb3bb596641a0c7f5c0c977cc147 Mon Sep 17 00:00:00 2001
From: Lauri Kotilainen <lauri@offbeat.fi>
Date: Sat, 13 Jan 2018 13:39:00 +0200
Subject: [PATCH] - Optional param -> second method

---
 src/ImageSharp/Memory/ArrayPoolMemoryManager.cs |  8 +++++++-
 src/ImageSharp/Memory/MemoryManager.cs          | 13 ++++++++++++-
 src/ImageSharp/Memory/NullMemoryManager.cs      |  8 +++++++-
 3 files changed, 26 insertions(+), 3 deletions(-)

diff --git a/src/ImageSharp/Memory/ArrayPoolMemoryManager.cs b/src/ImageSharp/Memory/ArrayPoolMemoryManager.cs
index 3e5628c75..f77a1f8ac 100644
--- a/src/ImageSharp/Memory/ArrayPoolMemoryManager.cs
+++ b/src/ImageSharp/Memory/ArrayPoolMemoryManager.cs
@@ -30,7 +30,13 @@ namespace SixLabors.ImageSharp.Memory
         }
 
         /// <inheritdoc />
-        internal override Buffer<T> Allocate<T>(int itemCount, bool clear = false)
+        internal override Buffer<T> Allocate<T>(int itemCount)
+        {
+            return this.Allocate<T>(itemCount, false);
+        }
+
+        /// <inheritdoc />
+        internal override Buffer<T> Allocate<T>(int itemCount, bool clear)
         {
             int itemSizeBytes = Unsafe.SizeOf<T>();
             int bufferSizeInBytes = itemCount * itemSizeBytes;
diff --git a/src/ImageSharp/Memory/MemoryManager.cs b/src/ImageSharp/Memory/MemoryManager.cs
index 67d72d2b4..1cefccfb2 100644
--- a/src/ImageSharp/Memory/MemoryManager.cs
+++ b/src/ImageSharp/Memory/MemoryManager.cs
@@ -11,6 +11,17 @@ namespace SixLabors.ImageSharp.Memory
     /// </summary>
     public abstract class MemoryManager
     {
+        /// <summary>
+        /// Allocates a <see cref="Buffer{T}"/> of size <paramref name="size"/>.
+        /// Note: Depending on the implementation, the buffer may not cleared before
+        /// returning, so it may contain data from an earlier use.
+        /// </summary>
+        /// <typeparam name="T">Type of the data stored in the buffer</typeparam>
+        /// <param name="size">Size of the buffer to allocate</param>
+        /// <returns>A buffer of values of type <typeparamref name="T"/>.</returns>
+        internal abstract Buffer<T> Allocate<T>(int size)
+            where T : struct;
+
         /// <summary>
         /// Allocates a <see cref="Buffer{T}"/> of size <paramref name="size"/>, optionally
         /// clearing the buffer before it gets returned.
@@ -19,7 +30,7 @@ namespace SixLabors.ImageSharp.Memory
         /// <param name="size">Size of the buffer to allocate</param>
         /// <param name="clear">True to clear the backing memory of the buffer</param>
         /// <returns>A buffer of values of type <typeparamref name="T"/>.</returns>
-        internal abstract Buffer<T> Allocate<T>(int size, bool clear = false)
+        internal abstract Buffer<T> Allocate<T>(int size, bool clear)
             where T : struct;
 
         /// <summary>
diff --git a/src/ImageSharp/Memory/NullMemoryManager.cs b/src/ImageSharp/Memory/NullMemoryManager.cs
index 32642dae4..d82f01353 100644
--- a/src/ImageSharp/Memory/NullMemoryManager.cs
+++ b/src/ImageSharp/Memory/NullMemoryManager.cs
@@ -6,7 +6,13 @@
     public class NullMemoryManager : MemoryManager
     {
         /// <inheritdoc />
-        internal override Buffer<T> Allocate<T>(int size, bool clear = false)
+        internal override Buffer<T> Allocate<T>(int size)
+        {
+            return new Buffer<T>(new T[size], size);
+        }
+
+        /// <inheritdoc />
+        internal override Buffer<T> Allocate<T>(int size, bool clear)
         {
             return new Buffer<T>(new T[size], size);
         }