fix remaining stylecop issues

src/ImageSharp.Drawing/Processing/DrawingHelpers.cs

@@ -1,5 +1,5 @@
-// // Copyright (c) Six Labors and contributors.
-// // Licensed under the Apache License, Version 2.0.
+// Copyright (c) Six Labors and contributors.
+// Licensed under the Apache License, Version 2.0.
 
 using SixLabors.ImageSharp.PixelFormats;
 using SixLabors.ImageSharp.Primitives;
@@ -8,6 +8,9 @@ namespace SixLabors.ImageSharp.Processing
 {
     internal static class DrawingHelpers
     {
+        /// <summary>
+        /// Convert a <see cref="DenseMatrix{Color}"/> to a <see cref="DenseMatrix{T}"/> of the given pixel type.
+        /// </summary>
         public static DenseMatrix<TPixel> ToPixelMatrix<TPixel>(this DenseMatrix<Color> colorMatrix, Configuration configuration)
             where TPixel : struct, IPixel<TPixel>
         {

src/ImageSharp.Drawing/Processing/Extensions/DrawPathExtensions.cs

@@ -15,80 +15,90 @@ namespace SixLabors.ImageSharp.Processing
         /// <summary>
         /// Draws the outline of the polygon with the provided pen.
         /// </summary>
-        
         /// <param name="source">The image this method extends.</param>
         /// <param name="options">The options.</param>
         /// <param name="pen">The pen.</param>
         /// <param name="path">The path.</param>
         /// <returns>The <see cref="Image{TPixel}"/>.</returns>
-        public static IImageProcessingContext Draw(this IImageProcessingContext source, GraphicsOptions options, IPen pen, IPath path)
-            
-            => source.Fill(options, pen.StrokeFill, new ShapePath(path, pen));
+        public static IImageProcessingContext Draw(
+            this IImageProcessingContext source,
+            GraphicsOptions options,
+            IPen pen,
+            IPath path) =>
+            source.Fill(options, pen.StrokeFill, new ShapePath(path, pen));
 
         /// <summary>
         /// Draws the outline of the polygon with the provided pen.
         /// </summary>
-        
         /// <param name="source">The image this method extends.</param>
         /// <param name="pen">The pen.</param>
         /// <param name="path">The path.</param>
         /// <returns>The <see cref="Image{TPixel}"/>.</returns>
-        public static IImageProcessingContext Draw(this IImageProcessingContext source, IPen pen, IPath path)
-            
-            => source.Draw(GraphicsOptions.Default, pen, path);
+        public static IImageProcessingContext Draw(this IImageProcessingContext source, IPen pen, IPath path) =>
+            source.Draw(GraphicsOptions.Default, pen, path);
 
         /// <summary>
         /// Draws the outline of the polygon with the provided brush at the provided thickness.
         /// </summary>
-        
         /// <param name="source">The image this method extends.</param>
         /// <param name="options">The options.</param>
         /// <param name="brush">The brush.</param>
         /// <param name="thickness">The thickness.</param>
         /// <param name="path">The shape.</param>
         /// <returns>The <see cref="Image{TPixel}"/>.</returns>
-        public static IImageProcessingContext Draw(this IImageProcessingContext source, GraphicsOptions options, IBrush brush, float thickness, IPath path)
-            
-            => source.Draw(options, new Pen(brush, thickness), path);
+        public static IImageProcessingContext Draw(
+            this IImageProcessingContext source,
+            GraphicsOptions options,
+            IBrush brush,
+            float thickness,
+            IPath path) =>
+            source.Draw(options, new Pen(brush, thickness), path);
 
         /// <summary>
         /// Draws the outline of the polygon with the provided brush at the provided thickness.
         /// </summary>
-        
         /// <param name="source">The image this method extends.</param>
         /// <param name="brush">The brush.</param>
         /// <param name="thickness">The thickness.</param>
         /// <param name="path">The path.</param>
         /// <returns>The <see cref="Image{TPixel}"/>.</returns>
-        public static IImageProcessingContext Draw(this IImageProcessingContext source, IBrush brush, float thickness, IPath path)
-            
-            => source.Draw(new Pen(brush, thickness), path);
+        public static IImageProcessingContext Draw(
+            this IImageProcessingContext source,
+            IBrush brush,
+            float thickness,
+            IPath path) =>
+            source.Draw(new Pen(brush, thickness), path);
 
         /// <summary>
         /// Draws the outline of the polygon with the provided brush at the provided thickness.
         /// </summary>
-        
         /// <param name="source">The image this method extends.</param>
         /// <param name="options">The options.</param>
         /// <param name="color">The color.</param>
         /// <param name="thickness">The thickness.</param>
         /// <param name="path">The path.</param>
         /// <returns>The <see cref="Image{TPixel}"/>.</returns>
-        public static IImageProcessingContext Draw(this IImageProcessingContext source, GraphicsOptions options, Color color, float thickness, IPath path)
-            
-            => source.Draw(options, new SolidBrush(color), thickness, path);
+        public static IImageProcessingContext Draw(
+            this IImageProcessingContext source,
+            GraphicsOptions options,
+            Color color,
+            float thickness,
+            IPath path) =>
+            source.Draw(options, new SolidBrush(color), thickness, path);
 
         /// <summary>
         /// Draws the outline of the polygon with the provided brush at the provided thickness.
         /// </summary>
-        
         /// <param name="source">The image this method extends.</param>
         /// <param name="color">The color.</param>
         /// <param name="thickness">The thickness.</param>
         /// <param name="path">The path.</param>
         /// <returns>The <see cref="Image{TPixel}"/>.</returns>
-        public static IImageProcessingContext Draw(this IImageProcessingContext source, Color color, float thickness, IPath path)
-            
-            => source.Draw(new SolidBrush(color), thickness, path);
+        public static IImageProcessingContext Draw(
+            this IImageProcessingContext source,
+            Color color,
+            float thickness,
+            IPath path) =>
+            source.Draw(new SolidBrush(color), thickness, path);
     }
 }

src/ImageSharp.Drawing/Processing/Extensions/FillPathExtensions.cs

@@ -1,7 +1,6 @@
 // Copyright (c) Six Labors and contributors.
 // Licensed under the Apache License, Version 2.0.
 
-using SixLabors.ImageSharp.PixelFormats;
 using SixLabors.ImageSharp.Primitives;
 using SixLabors.Shapes;
 
@@ -15,51 +14,51 @@ namespace SixLabors.ImageSharp.Processing
         /// <summary>
         /// Flood fills the image in the shape of the provided polygon with the specified brush.
         /// </summary>
-        
         /// <param name="source">The image this method extends.</param>
         /// <param name="options">The graphics options.</param>
         /// <param name="brush">The brush.</param>
         /// <param name="path">The shape.</param>
         /// <returns>The <see cref="Image{TPixel}"/>.</returns>
-        public static IImageProcessingContext Fill(this IImageProcessingContext source, GraphicsOptions options, IBrush brush, IPath path)
-            
-            => source.Fill(options, brush, new ShapeRegion(path));
+        public static IImageProcessingContext Fill(
+            this IImageProcessingContext source,
+            GraphicsOptions options,
+            IBrush brush,
+            IPath path) =>
+            source.Fill(options, brush, new ShapeRegion(path));
 
         /// <summary>
         /// Flood fills the image in the shape of the provided polygon with the specified brush.
         /// </summary>
-        
         /// <param name="source">The image this method extends.</param>
         /// <param name="brush">The brush.</param>
         /// <param name="path">The path.</param>
         /// <returns>The <see cref="Image{TPixel}"/>.</returns>
-        public static IImageProcessingContext Fill(this IImageProcessingContext source, IBrush brush, IPath path)
-            
-            => source.Fill(GraphicsOptions.Default, brush, new ShapeRegion(path));
+        public static IImageProcessingContext Fill(this IImageProcessingContext source, IBrush brush, IPath path) =>
+            source.Fill(GraphicsOptions.Default, brush, new ShapeRegion(path));
 
         /// <summary>
         /// Flood fills the image in the shape of the provided polygon with the specified brush..
         /// </summary>
-        
         /// <param name="source">The image this method extends.</param>
         /// <param name="options">The options.</param>
         /// <param name="color">The color.</param>
         /// <param name="path">The path.</param>
         /// <returns>The <see cref="Image{TPixel}"/>.</returns>
-        public static IImageProcessingContext Fill(this IImageProcessingContext source, GraphicsOptions options, Color color, IPath path)
-            
-            => source.Fill(options, new SolidBrush(color), path);
+        public static IImageProcessingContext Fill(
+            this IImageProcessingContext source,
+            GraphicsOptions options,
+            Color color,
+            IPath path) =>
+            source.Fill(options, new SolidBrush(color), path);
 
         /// <summary>
         /// Flood fills the image in the shape of the provided polygon with the specified brush..
         /// </summary>
-        
         /// <param name="source">The image this method extends.</param>
         /// <param name="color">The color.</param>
         /// <param name="path">The path.</param>
         /// <returns>The <see cref="Image{TPixel}"/>.</returns>
-        public static IImageProcessingContext Fill(this IImageProcessingContext source, Color color, IPath path)
-            
-            => source.Fill(new SolidBrush(color), path);
+        public static IImageProcessingContext Fill(this IImageProcessingContext source, Color color, IPath path) =>
+            source.Fill(new SolidBrush(color), path);
     }
 }

src/ImageSharp.Drawing/Processing/Extensions/FillRegionExtensions.cs

@@ -1,7 +1,6 @@
 // Copyright (c) Six Labors and contributors.
 // Licensed under the Apache License, Version 2.0.
 
-using SixLabors.ImageSharp.PixelFormats;
 using SixLabors.ImageSharp.Primitives;
 using SixLabors.ImageSharp.Processing.Processors.Drawing;
 
@@ -15,85 +14,82 @@ namespace SixLabors.ImageSharp.Processing
         /// <summary>
         /// Flood fills the image with the specified brush.
         /// </summary>
-        
         /// <param name="source">The image this method extends.</param>
         /// <param name="brush">The details how to fill the region of interest.</param>
         /// <returns>The <see cref="Image{TPixel}"/>.</returns>
-        public static IImageProcessingContext Fill(this IImageProcessingContext source, IBrush brush)
-            
-            => source.Fill(GraphicsOptions.Default, brush);
+        public static IImageProcessingContext Fill(this IImageProcessingContext source, IBrush brush) =>
+            source.Fill(GraphicsOptions.Default, brush);
 
         /// <summary>
         /// Flood fills the image with the specified color.
         /// </summary>
-        
         /// <param name="source">The image this method extends.</param>
         /// <param name="color">The color.</param>
         /// <returns>The <see cref="Image{TPixel}"/>.</returns>
-        public static IImageProcessingContext Fill(this IImageProcessingContext source, Color color)
-            
-            => source.Fill(new SolidBrush(color));
+        public static IImageProcessingContext Fill(this IImageProcessingContext source, Color color) =>
+            source.Fill(new SolidBrush(color));
 
         /// <summary>
         /// Flood fills the image with in the region with the specified brush.
         /// </summary>
-        
         /// <param name="source">The image this method extends.</param>
         /// <param name="brush">The brush.</param>
         /// <param name="region">The region.</param>
         /// <returns>The <see cref="Image{TPixel}"/>.</returns>
-        public static IImageProcessingContext Fill(this IImageProcessingContext source, IBrush brush, Region region)
-            
-            => source.Fill(GraphicsOptions.Default, brush, region);
+        public static IImageProcessingContext Fill(this IImageProcessingContext source, IBrush brush, Region region) =>
+            source.Fill(GraphicsOptions.Default, brush, region);
 
         /// <summary>
         /// Flood fills the image with in the region with the specified color.
         /// </summary>
-        
         /// <param name="source">The image this method extends.</param>
         /// <param name="options">The options.</param>
         /// <param name="color">The color.</param>
         /// <param name="region">The region.</param>
         /// <returns>The <see cref="Image{TPixel}"/>.</returns>
-        public static IImageProcessingContext Fill(this IImageProcessingContext source, GraphicsOptions options, Color color, Region region)
-            
-            => source.Fill(options, new SolidBrush(color), region);
+        public static IImageProcessingContext Fill(
+            this IImageProcessingContext source,
+            GraphicsOptions options,
+            Color color,
+            Region region) =>
+            source.Fill(options, new SolidBrush(color), region);
 
         /// <summary>
         /// Flood fills the image with in the region with the specified color.
         /// </summary>
-        
         /// <param name="source">The image this method extends.</param>
         /// <param name="color">The color.</param>
         /// <param name="region">The region.</param>
         /// <returns>The <see cref="Image{TPixel}"/>.</returns>
-        public static IImageProcessingContext Fill(this IImageProcessingContext source, Color color, Region region)
-            
-            => source.Fill(new SolidBrush(color), region);
+        public static IImageProcessingContext Fill(this IImageProcessingContext source, Color color, Region region) =>
+            source.Fill(new SolidBrush(color), region);
 
         /// <summary>
         /// Flood fills the image with in the region with the specified brush.
         /// </summary>
-        
         /// <param name="source">The image this method extends.</param>
         /// <param name="options">The graphics options.</param>
         /// <param name="brush">The brush.</param>
         /// <param name="region">The region.</param>
         /// <returns>The <see cref="Image{TPixel}"/>.</returns>
-        public static IImageProcessingContext Fill(this IImageProcessingContext source, GraphicsOptions options, IBrush brush, Region region)
-            
-            => source.ApplyProcessor(new FillRegionProcessor(brush, region, options));
+        public static IImageProcessingContext Fill(
+            this IImageProcessingContext source,
+            GraphicsOptions options,
+            IBrush brush,
+            Region region) =>
+            source.ApplyProcessor(new FillRegionProcessor(brush, region, options));
 
         /// <summary>
         /// Flood fills the image with the specified brush.
         /// </summary>
-        
         /// <param name="source">The image this method extends.</param>
         /// <param name="options">The graphics options.</param>
         /// <param name="brush">The details how to fill the region of interest.</param>
         /// <returns>The <see cref="Image{TPixel}"/>.</returns>
-        public static IImageProcessingContext Fill(this IImageProcessingContext source, GraphicsOptions options, IBrush brush)
-            
-            => source.ApplyProcessor(new FillProcessor(brush, options));
+        public static IImageProcessingContext Fill(
+            this IImageProcessingContext source,
+            GraphicsOptions options,
+            IBrush brush) =>
+            source.ApplyProcessor(new FillProcessor(brush, options));
     }
 }

src/ImageSharp.Drawing/Processing/GradientBrushBase.cs

@@ -46,7 +46,7 @@ namespace SixLabors.ImageSharp.Processing
         /// <summary>
         /// Base class for gradient brush applicators
         /// </summary>
-        protected abstract class GradientBrushApplicatorBase<TPixel> : BrushApplicator<TPixel>
+        internal abstract class GradientBrushApplicatorBase<TPixel> : BrushApplicator<TPixel>
             where TPixel : struct, IPixel<TPixel>
         {
             private readonly ColorStop[] colorStops;

src/ImageSharp.Drawing/Processing/GradientRepetitionMode.cs

@@ -21,16 +21,16 @@ namespace SixLabors.ImageSharp.Processing
 
         /// <summary>
         /// Reflect the gradient.
-        /// Similar to <see cref="Repeat"/>, but each other repetition uses inverse order of <see cref="ColorStop{TPixel}"/>s.
+        /// Similar to <see cref="Repeat"/>, but each other repetition uses inverse order of <see cref="ColorStop"/>s.
         /// Used on a Black-White gradient, Reflect leads to Black->{gray}->White->{gray}->White...
         /// </summary>
         Reflect,
 
         /// <summary>
         /// With DontFill a gradient does not touch any pixel beyond it's borders.
-        /// For the <see cref="LinearGradientBrush{TPixel}" /> this is beyond the orthogonal through start and end,
+        /// For the <see cref="LinearGradientBrush" /> this is beyond the orthogonal through start and end,
         /// TODO For the cref="PolygonalGradientBrush" it's outside the polygon,
-        /// For <see cref="RadialGradientBrush{TPixel}" /> and <see cref="EllipticGradientBrush{TPixel}" /> it's beyond 1.0.
+        /// For <see cref="RadialGradientBrush" /> and <see cref="EllipticGradientBrush" /> it's beyond 1.0.
         /// </summary>
         DontFill
     }

src/ImageSharp.Drawing/Processing/IBrush.cs

@@ -9,16 +9,16 @@ namespace SixLabors.ImageSharp.Processing
     /// <summary>
     /// Brush represents a logical configuration of a brush which can be used to source pixel colors
     /// </summary>
-    /// <typeparam name="TPixel">The pixel format.</typeparam>
     /// <remarks>
     /// A brush is a simple class that will return an <see cref="BrushApplicator{TPixel}" /> that will perform the
-    /// logic for converting a pixel location to a <typeparamref name="TPixel"/>.
+    /// logic for retrieving pixel values for specific locations.
     /// </remarks>
     public interface IBrush
     {
         /// <summary>
         /// Creates the applicator for this brush.
         /// </summary>
+        /// <typeparam name="TPixel">The pixel type.</typeparam>
         /// <param name="source">The source image.</param>
         /// <param name="region">The region the brush will be applied to.</param>
         /// <param name="options">The graphic options</param>

src/ImageSharp.Drawing/Processing/IPen.cs

@@ -2,6 +2,7 @@
 // Licensed under the Apache License, Version 2.0.
 
 using System;
+
 using SixLabors.ImageSharp.PixelFormats;
 
 namespace SixLabors.ImageSharp.Processing
@@ -15,7 +16,7 @@ namespace SixLabors.ImageSharp.Processing
         /// Gets the stroke fill.
         /// </summary>
         IBrush StrokeFill { get; }
-        
+
         /// <summary>
         /// Gets the width to apply to the stroke
         /// </summary>
@@ -26,4 +27,4 @@ namespace SixLabors.ImageSharp.Processing
         /// </summary>
         ReadOnlySpan<float> StrokePattern { get; }
     }
-}
+}

src/ImageSharp.Drawing/Processing/ImageBrush.cs

@@ -44,7 +44,7 @@ namespace SixLabors.ImageSharp.Processing
             }
 
             specificImage = this.image.CloneAs<TPixel>();
-            
+
             return new ImageBrushApplicator<TPixel>(source, specificImage, region, options, true);
         }
 

src/ImageSharp.Drawing/Processing/LinearGradientBrush.cs

@@ -14,7 +14,6 @@ namespace SixLabors.ImageSharp.Processing
     /// - a set of colors in relative distances to each other.
     /// </summary>
     public sealed class LinearGradientBrush : GradientBrushBase
-        
     {
         private readonly PointF p1;
 
@@ -39,8 +38,17 @@ namespace SixLabors.ImageSharp.Processing
         }
 
         /// <inheritdoc />
-        public override BrushApplicator<TPixel> CreateApplicator<TPixel>(ImageFrame<TPixel> source, RectangleF region, GraphicsOptions options)
-            => new LinearGradientBrushApplicator<TPixel>(source, this.p1, this.p2, this.ColorStops, this.RepetitionMode, options);
+        public override BrushApplicator<TPixel> CreateApplicator<TPixel>(
+            ImageFrame<TPixel> source,
+            RectangleF region,
+            GraphicsOptions options) =>
+            new LinearGradientBrushApplicator<TPixel>(
+                source,
+                this.p1,
+                this.p2,
+                this.ColorStops,
+                this.RepetitionMode,
+                options);
 
         /// <summary>
         /// The linear gradient brush applicator.
@@ -137,9 +145,7 @@ namespace SixLabors.ImageSharp.Processing
                     float y4 = y + (k * this.alongX);
 
                     // get distance from (x4,y4) to start
-                    float distance = (float)Math.Sqrt(
-                        Math.Pow(x4 - this.start.X, 2)
-                        + Math.Pow(y4 - this.start.Y, 2));
+                    float distance = (float)Math.Sqrt(Math.Pow(x4 - this.start.X, 2) + Math.Pow(y4 - this.start.Y, 2));
 
                     // get and return ratio
                     float ratio = distance / this.length;