From f08b68247d09c9cafe3cacacaa8de6927fca86f3 Mon Sep 17 00:00:00 2001 From: James Jackson-South Date: Mon, 12 Oct 2020 14:46:04 +0100 Subject: [PATCH 1/7] Use Ubuntu for coverage. Touch #1376 --- .github/workflows/build-and-test.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build-and-test.yml b/.github/workflows/build-and-test.yml index 0e093a834..1422606a6 100644 --- a/.github/workflows/build-and-test.yml +++ b/.github/workflows/build-and-test.yml @@ -18,7 +18,7 @@ jobs: framework: netcoreapp3.1 runtime: -x64 codecov: false - - os: windows-latest + - os: ubuntu-latest framework: netcoreapp3.1 runtime: -x64 codecov: true From 90624b71fbb7b4bd2e84e38a5465f35db311826f Mon Sep 17 00:00:00 2001 From: James Jackson-South Date: Mon, 12 Oct 2020 14:57:54 +0100 Subject: [PATCH 2/7] Enable windows netcore 3.1 --- .github/workflows/build-and-test.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/build-and-test.yml b/.github/workflows/build-and-test.yml index 1422606a6..c8f399794 100644 --- a/.github/workflows/build-and-test.yml +++ b/.github/workflows/build-and-test.yml @@ -17,11 +17,11 @@ jobs: - os: ubuntu-latest framework: netcoreapp3.1 runtime: -x64 - codecov: false - - os: ubuntu-latest + codecov: true + - os: windows-latest framework: netcoreapp3.1 runtime: -x64 - codecov: true + codecov: false - os: windows-latest framework: netcoreapp2.1 runtime: -x64 From f1f4d49c01c00216a356f8033878c4a7f9c7517b Mon Sep 17 00:00:00 2001 From: James Jackson-South Date: Mon, 12 Oct 2020 15:31:51 +0100 Subject: [PATCH 3/7] Try bumping SDK --- tests/Directory.Build.targets | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/Directory.Build.targets b/tests/Directory.Build.targets index e9e93a855..acdf68432 100644 --- a/tests/Directory.Build.targets +++ b/tests/Directory.Build.targets @@ -31,7 +31,7 @@ - + From e7988d21d248ae0984d08b14bfb6103461158d0a Mon Sep 17 00:00:00 2001 From: James Jackson-South Date: Mon, 12 Oct 2020 16:48:06 +0100 Subject: [PATCH 4/7] Update deterministic workaround --- Directory.Build.targets | 2 +- src/Directory.Build.targets | 25 +++++++++++++++++-------- 2 files changed, 18 insertions(+), 9 deletions(-) diff --git a/Directory.Build.targets b/Directory.Build.targets index 4e7ab9e6b..5d27adc65 100644 --- a/Directory.Build.targets +++ b/Directory.Build.targets @@ -18,7 +18,7 @@ - + diff --git a/src/Directory.Build.targets b/src/Directory.Build.targets index d1875262d..9b8be05b5 100644 --- a/src/Directory.Build.targets +++ b/src/Directory.Build.targets @@ -21,16 +21,25 @@ - + + $([System.IO.Path]::Combine('$(IntermediateOutputPath)','$(TargetFrameworkMoniker).AssemblyAttributes$(DefaultLanguageSourceExtension)')) + + + + + + + + + DependsOnTargets="InitializeSourceRootMappedPaths" + Returns="@(_LocalTopLevelSourceRoot)" + Condition="'$(DeterministicSourcePaths)' == 'true'"> <_LocalTopLevelSourceRoot Include="@(SourceRoot)" Condition="'%(SourceRoot.NestedRoot)' == ''"/> - + false @@ -62,7 +71,7 @@ - + @@ -74,7 +83,7 @@ SkipUnchangedFiles = "true" DestinationFolder="..\..\" /> - + - + From 9bbf90837306b84bbd432e6cba632fcd0f7fb40c Mon Sep 17 00:00:00 2001 From: James Jackson-South Date: Mon, 12 Oct 2020 17:03:39 +0100 Subject: [PATCH 5/7] Revert SDK bump --- Directory.Build.targets | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Directory.Build.targets b/Directory.Build.targets index 5d27adc65..4e7ab9e6b 100644 --- a/Directory.Build.targets +++ b/Directory.Build.targets @@ -18,7 +18,7 @@ - + From 8d3f5e79624041fc87ba04ad2c5f1a3a30ffe6a8 Mon Sep 17 00:00:00 2001 From: James Jackson-South Date: Mon, 12 Oct 2020 18:06:51 +0100 Subject: [PATCH 6/7] Use coverlet nightlies --- Directory.Build.props | 1 + tests/Directory.Build.targets | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/Directory.Build.props b/Directory.Build.props index 0f9c5bdde..c4610d0ed 100644 --- a/Directory.Build.props +++ b/Directory.Build.props @@ -120,6 +120,7 @@ https://api.nuget.org/v3/index.json; https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-eng/nuget/v3/index.json; + https://www.myget.org/F/coverlet-dev/api/v3/index.json; true $(MSBuildThisFileDirectory)shared-infrastructure/SixLabors.snk diff --git a/tests/Directory.Build.targets b/tests/Directory.Build.targets index acdf68432..9ee4e2a2e 100644 --- a/tests/Directory.Build.targets +++ b/tests/Directory.Build.targets @@ -28,7 +28,7 @@ - + From f71d7a9cb30d0124e7949f44c88bc3022b6a1ae5 Mon Sep 17 00:00:00 2001 From: James Jackson-South Date: Mon, 12 Oct 2020 19:07:42 +0100 Subject: [PATCH 7/7] Update Directory.Build.targets --- tests/Directory.Build.targets | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/Directory.Build.targets b/tests/Directory.Build.targets index 9ee4e2a2e..335f3d106 100644 --- a/tests/Directory.Build.targets +++ b/tests/Directory.Build.targets @@ -31,7 +31,7 @@ - +