Add setter to IPackedVector<TP>

Former-commit-id: 8f90f6fd99515e8cbf50184baeaefd93466bb39c
Former-commit-id: f1e9aa552dc446eedb450aa7ed1a9f6ef87a5001
Former-commit-id: 15c3d89bf472544d8c89dd7da2f45dfffbb441e6

src/ImageProcessorCore/Colors/Color.cs

@@ -49,7 +49,7 @@ namespace ImageProcessorCore
         /// The packed value.
         /// </summary>
         [FieldOffset(0)]
-        private readonly uint packedValue;
+        private uint packedValue;
 
         /// <summary>
         /// Initializes a new instance of the <see cref="Color"/> struct. 
@@ -192,13 +192,19 @@ namespace ImageProcessorCore
         }
 
         /// <inheritdoc/>
-        public uint PackedValue()
+        public uint GetPackedValue()
         {
             return this.packedValue;
         }
 
         /// <inheritdoc/>
-        public void PackVector(Vector4 vector)
+        public void SetPackedValue(uint value)
+        {
+            this.packedValue = value;
+        }
+
+        /// <inheritdoc/>
+        public void PackFromVector4(Vector4 vector)
         {
             Vector4 clamped = Vector4.Clamp(vector, Vector4.Zero, Vector4.One) * 255F;
             this.R = (byte)Math.Round(clamped.X);
@@ -208,7 +214,7 @@ namespace ImageProcessorCore
         }
 
         /// <inheritdoc/>
-        public void PackBytes(byte x, byte y, byte z, byte w)
+        public void PackFromBytes(byte x, byte y, byte z, byte w)
         {
             this.R = x;
             this.G = y;

src/ImageProcessorCore/Colors/PackedVector/IPackedVector.cs

@@ -9,20 +9,27 @@ namespace ImageProcessorCore
 
     /// <summary>
     /// An interface that converts packed vector types to and from <see cref="Vector4"/> values, 
-    /// allowing multiple encodings to be manipulated in a generic way.
+    /// allowing multiple encodings to be manipulated in a generic manner.
     /// </summary>
     /// <typeparam name="TP">The packed format. <example>long, float.</example></typeparam>
     public interface IPackedVector<TP> : IPackedVector
         where TP : struct
     {
         /// <summary>
-        /// Gets the packed representation of the value.
+        /// Directly gets the packed representation of the packed vector.
         /// Typically packed in least to greatest significance order.
         /// </summary>
         /// <returns>
         /// The <see cref="TP"/>.
         /// </returns>
-        TP PackedValue();
+        TP GetPackedValue();
+
+        /// <summary>
+        /// Directly sets the packed representation of the packed vector.
+        /// Typically packed in least to greatest significance order.
+        /// </summary>
+        /// <param name="value">The packed value.</param>
+        void SetPackedValue(TP value);
     }
 
     /// <summary>
@@ -33,17 +40,17 @@ namespace ImageProcessorCore
         /// <summary>
         /// Sets the packed representation from a <see cref="Vector4"/>.
         /// </summary>
-        /// <param name="vector">The vector to pack.</param>
+        /// <param name="vector">The vector to create the packed representation from.</param>
-        void PackVector(Vector4 vector);
+        void PackFromVector4(Vector4 vector);
 
         /// <summary>
-        /// Sets the packed representation from a <see cref="Vector4"/>.
+        /// Sets the packed representation from a <see cref="T:byte[]"/>.
         /// </summary>
-        /// <param name="x">The x-component.</param>
+        /// <param name="x">The x-component to create the packed representation from.</param>
-        /// <param name="y">The y-component.</param>
+        /// <param name="y">The y-component to create the packed representation from.</param>
-        /// <param name="z">The z-component.</param>
+        /// <param name="z">The z-component to create the packed representation from.</param>
-        /// <param name="w">The w-component.</param>
+        /// <param name="w">The w-component to create the packed representation from.</param>
-        void PackBytes(byte x, byte y, byte z, byte w);
+        void PackFromBytes(byte x, byte y, byte z, byte w);
 
         /// <summary>
         /// Expands the packed representation into a <see cref="Vector4"/>.

src/ImageProcessorCore/Filters/Processors/AlphaProcessor.cs

@@ -62,7 +62,7 @@ namespace ImageProcessorCore.Processors
                                     color *= alphaVector;
 
                                     T packed = default(T);
-                                    packed.PackVector(color);
+                                    packed.PackFromVector4(color);
                                     targetPixels[x, y] = packed;
                                 }
 

src/ImageProcessorCore/Filters/Processors/BackgroundColorProcessor.cs

@@ -71,7 +71,7 @@ namespace ImageProcessorCore.Processors
                                     }
 
                                     T packed = default(T);
-                                    packed.PackVector(color);
+                                    packed.PackFromVector4(color);
                                     targetPixels[x, y] = packed;
                                 }
 

src/ImageProcessorCore/Filters/Processors/Binarization/BinaryThresholdProcessor.cs

@@ -32,11 +32,11 @@ namespace ImageProcessorCore.Processors
             this.Value = threshold;
 
             T upper = default(T);
-            upper.PackVector(Color.White.ToVector4());
+            upper.PackFromVector4(Color.White.ToVector4());
             this.UpperColor = upper;
 
             T lower = default(T);
-            lower.PackVector(Color.Black.ToVector4());
+            lower.PackFromVector4(Color.Black.ToVector4());
             this.LowerColor = lower;
         }
 

src/ImageProcessorCore/Filters/Processors/BlendProcessor.cs

@@ -81,7 +81,7 @@ namespace ImageProcessorCore.Processors
                                     }
 
                                     T packed = default(T);
-                                    packed.PackVector(color);
+                                    packed.PackFromVector4(color);
                                     targetPixels[x, y] = packed;
                                 }
 

src/ImageProcessorCore/Filters/Processors/BrightnessProcessor.cs

@@ -64,7 +64,7 @@ namespace ImageProcessorCore.Processors
                                     vector = new Vector4(transformed, vector.W);
 
                                     T packed = default(T);
-                                    packed.PackVector(vector.Compress());
+                                    packed.PackFromVector4(vector.Compress());
 
                                     targetPixels[x, y] = packed;
                                 }

src/ImageProcessorCore/Filters/Processors/ColorMatrix/ColorMatrixFilter.cs

@@ -71,7 +71,7 @@ namespace ImageProcessorCore.Processors
             Vector3 transformed = Vector3.Transform(new Vector3(vector.X, vector.Y, vector.Z), matrix);
             vector = new Vector4(transformed, vector.W);
             T packed = default(T);
-            packed.PackVector(compand ? vector.Compress() : vector);
+            packed.PackFromVector4(compand ? vector.Compress() : vector);
             return packed;
         }
     }

src/ImageProcessorCore/Filters/Processors/ColorMatrix/LomographProcessor.cs

@@ -31,7 +31,7 @@ namespace ImageProcessorCore.Processors
         protected override void AfterApply(ImageBase<T, TP> target, ImageBase<T, TP> source, Rectangle targetRectangle, Rectangle sourceRectangle)
         {
             T packed = default(T);
-            packed.PackBytes(0, 10, 0, 255);
+            packed.PackFromBytes(0, 10, 0, 255);
             new VignetteProcessor<T, TP> { VignetteColor = packed }.Apply(target, target, targetRectangle);
         }
     }

src/ImageProcessorCore/Filters/Processors/ColorMatrix/PolaroidProcessor.cs

@@ -37,11 +37,11 @@ namespace ImageProcessorCore.Processors
         protected override void AfterApply(ImageBase<T, TP> target, ImageBase<T, TP> source, Rectangle targetRectangle, Rectangle sourceRectangle)
         {
             T packedV = default(T);
-            packedV.PackBytes(102, 34, 0, 255);
+            packedV.PackFromBytes(102, 34, 0, 255);
             new VignetteProcessor<T, TP> { VignetteColor = packedV }.Apply(target, target, targetRectangle);
 
             T packedG = default(T);
-            packedG.PackBytes(255, 153, 102, 178);
+            packedG.PackFromBytes(255, 153, 102, 178);
             new GlowProcessor<T, TP>
             {
                 GlowColor = packedG,

src/ImageProcessorCore/Filters/Processors/ContrastProcessor.cs

@@ -64,7 +64,7 @@ namespace ImageProcessorCore.Processors
                                     vector *= contrastVector;
                                     vector += shiftVector;
                                     T packed = default(T);
-                                    packed.PackVector(vector.Compress());
+                                    packed.PackFromVector4(vector.Compress());
                                     targetPixels[x, y] = packed;
                                 }
                                 this.OnRowProcessed();

src/ImageProcessorCore/Filters/Processors/Convolution/Convolution2DFilter.cs

@@ -109,7 +109,7 @@ namespace ImageProcessorCore.Processors
 
                             Vector4 targetColor = targetPixels[x, y].ToVector4();
                             T packed = default(T);
-                            packed.PackVector(new Vector4(red, green, blue, targetColor.Z));
+                            packed.PackFromVector4(new Vector4(red, green, blue, targetColor.Z));
                             targetPixels[x, y] = packed;
                         }
                         this.OnRowProcessed();

src/ImageProcessorCore/Filters/Processors/Convolution/Convolution2PassFilter.cs

@@ -97,7 +97,7 @@ namespace ImageProcessorCore.Processors
                         }
 
                         T packed = default(T);
-                        packed.PackVector(destination);
+                        packed.PackFromVector4(destination);
                         targetPixels[x, y] = packed;
                     }
 

src/ImageProcessorCore/Filters/Processors/Convolution/ConvolutionFilter.cs

@@ -83,7 +83,7 @@ namespace ImageProcessorCore.Processors
 
                             Vector4 targetColor = targetPixels[x, y].ToVector4();
                             T packed = default(T);
-                            packed.PackVector(new Vector4(red, green, blue, targetColor.Z));
+                            packed.PackFromVector4(new Vector4(red, green, blue, targetColor.Z));
                             targetPixels[x, y] = packed;
 
                         }

src/ImageProcessorCore/Filters/Processors/GlowProcessor.cs

@@ -23,7 +23,7 @@ namespace ImageProcessorCore.Processors
         /// </summary>
         public GlowProcessor()
         {
-            this.GlowColor.PackVector(Color.White.ToVector4());
+            this.GlowColor.PackFromVector4(Color.White.ToVector4());
         }
 
         /// <summary>
@@ -68,7 +68,7 @@ namespace ImageProcessorCore.Processors
                                 Vector4 sourceColor = sourcePixels[x, y].ToVector4();
                                 Vector4 result = Vector4.Lerp(glowColor.ToVector4(), sourceColor, .5f * (distance / maxDistance));
                                 T packed = default(T);
-                                packed.PackVector(result);
+                                packed.PackFromVector4(result);
                                 targetPixels[x, y] = packed;
                             }
 

src/ImageProcessorCore/Filters/Processors/InvertProcessor.cs

@@ -41,7 +41,7 @@ namespace ImageProcessorCore.Processors
                                     Vector3 vector = inverseVector - new Vector3(color.X, color.Y, color.Z);
 
                                     T packed = default(T);
-                                    packed.PackVector(new Vector4(vector, color.W));
+                                    packed.PackFromVector4(new Vector4(vector, color.W));
                                     targetPixels[x, y] = packed;
                                 }
 

src/ImageProcessorCore/Filters/Processors/VignetteProcessor.cs

@@ -23,7 +23,7 @@ namespace ImageProcessorCore.Processors
         /// </summary>
         public VignetteProcessor()
         {
-            this.VignetteColor.PackVector(Color.Black.ToVector4());
+            this.VignetteColor.PackFromVector4(Color.Black.ToVector4());
         }
 
         /// <summary>
@@ -67,7 +67,7 @@ namespace ImageProcessorCore.Processors
                                 Vector4 sourceColor = sourcePixels[x, y].ToVector4();
                                 Vector4 result = Vector4.Lerp(vignetteColor.ToVector4(), sourceColor, 1 - .9f * (distance / maxDistance));
                                 T packed = default(T);
-                                packed.PackVector(result);
+                                packed.PackFromVector4(result);
                                 targetPixels[x, y] = packed;
 
                             }

src/ImageProcessorCore/Formats/Bmp/BmpDecoderCore.cs

@@ -243,7 +243,7 @@ namespace ImageProcessorCore.Formats
 
                                 // Stored in b-> g-> r order.
                                 T packed = default(T);
-                                packed.PackBytes(colors[colorIndex + 2], colors[colorIndex + 1], colors[colorIndex], 255);
+                                packed.PackFromBytes(colors[colorIndex + 2], colors[colorIndex + 1], colors[colorIndex], 255);
                                 imageData[arrayOffset] = packed;
                             }
                         }
@@ -295,7 +295,7 @@ namespace ImageProcessorCore.Formats
 
                             // Stored in b-> g-> r order.
                             T packed = default(T);
-                            packed.PackBytes(r, g, b, 255);
+                            packed.PackFromBytes(r, g, b, 255);
                             imageData[arrayOffset] = packed;
                         }
                     });
@@ -336,7 +336,7 @@ namespace ImageProcessorCore.Formats
                             // We divide by 255 as we will store the colors in our floating point format.
                             // Stored in b-> g-> r-> a order.
                             T packed = default(T);
-                            packed.PackBytes(data[offset + 2], data[offset + 1], data[offset], 255);
+                            packed.PackFromBytes(data[offset + 2], data[offset + 1], data[offset], 255);
                             imageData[arrayOffset] = packed;
                         }
                     });
@@ -376,7 +376,7 @@ namespace ImageProcessorCore.Formats
 
                             // Stored in b-> g-> r-> a order.
                             T packed = default(T);
-                            packed.PackBytes(data[offset + 2], data[offset + 1], data[offset], data[offset + 3]);
+                            packed.PackFromBytes(data[offset + 2], data[offset + 1], data[offset], data[offset + 3]);
                             imageData[arrayOffset] = packed;
                         }
                     });

src/ImageProcessorCore/Formats/Gif/GifDecoderCore.cs

@@ -360,7 +360,7 @@ namespace ImageProcessorCore.Formats
                         int indexOffset = index * 3;
 
                         T pixel = default(T);
-                        pixel.PackBytes(colorTable[indexOffset], colorTable[indexOffset + 1], colorTable[indexOffset + 2], 255);
+                        pixel.PackFromBytes(colorTable[indexOffset], colorTable[indexOffset + 1], colorTable[indexOffset + 2], 255);
                         this.currentFrame[offset] = pixel;
                     }
 

src/ImageProcessorCore/Formats/Jpg/JpegDecoderCore.cs.REMOVED.git-id

@@ -1 +1 @@
-09cbf92c0d7d3e4659626b60663612836e1e90e7
+adc0f0265d9f43bfcc4b6e12b48eda9c8f48b81a

src/ImageProcessorCore/Formats/Png/GrayscaleReader.cs

@@ -52,7 +52,7 @@ namespace ImageProcessorCore.Formats
                     byte a = newScanline[(x * 2) + 1];
 
                     T color = default(T);
-                    color.PackBytes(rgb, rgb, rgb, a);
+                    color.PackFromBytes(rgb, rgb, rgb, a);
                     pixels[offset] = color;
                 }
             }
@@ -64,7 +64,7 @@ namespace ImageProcessorCore.Formats
                     byte rgb = newScanline[x];
 
                     T color = default(T);
-                    color.PackBytes(rgb, rgb, rgb, 255);
+                    color.PackFromBytes(rgb, rgb, rgb, 255);
 
                     pixels[offset] = color;
                 }

src/ImageProcessorCore/Formats/Png/PaletteIndexReader.cs

@@ -66,7 +66,7 @@ namespace ImageProcessorCore.Formats
                                             : (byte)255;
 
                     T color = default(T);
-                    color.PackBytes(r, g, b, a);
+                    color.PackFromBytes(r, g, b, a);
                     pixels[offset] = color;
                 }
             }
@@ -84,7 +84,7 @@ namespace ImageProcessorCore.Formats
                     byte b = this.palette[pixelOffset + 2];
 
                     T color = default(T);
-                    color.PackBytes(r, g, b, 255);
+                    color.PackFromBytes(r, g, b, 255);
                     pixels[offset] = color;
                 }
             }

src/ImageProcessorCore/Formats/Png/TrueColorReader.cs

@@ -53,7 +53,7 @@ namespace ImageProcessorCore.Formats
                     byte a = newScanline[x + 3];
 
                     T color = default(T);
-                    color.PackBytes(r, g, b, a);
+                    color.PackFromBytes(r, g, b, a);
 
                     pixels[offset] = color;
                 }
@@ -70,7 +70,7 @@ namespace ImageProcessorCore.Formats
                     byte b = newScanline[pixelOffset + 2];
 
                     T color = default(T);
-                    color.PackBytes(r, g, b, 255);
+                    color.PackFromBytes(r, g, b, 255);
                     pixels[offset] = color;
                 }
             }

src/ImageProcessorCore/Quantizers/Octree/OctreeQuantizer.cs

@@ -197,7 +197,7 @@ namespace ImageProcessorCore.Quantizers
             /// </param>
             public void AddColor(T pixel)
             {
-                TP packed = pixel.PackedValue();
+                TP packed = pixel.GetPackedValue();
                 // Check if this request is for the same color as the last
                 if (this.previousColor.Equals(packed))
                 {
@@ -468,7 +468,7 @@ namespace ImageProcessorCore.Quantizers
 
                         // And set the color of the palette entry
                         T pixel = default(T);
-                        pixel.PackBytes(r, g, b, 255);
+                        pixel.PackFromBytes(r, g, b, 255);
                         palette.Add(pixel);
                     }
                     else

src/ImageProcessorCore/Quantizers/Palette/PaletteQuantizer.cs

@@ -47,7 +47,7 @@ namespace ImageProcessorCore.Quantizers
                 foreach (Color c in constants)
                 {
                     T packed = default(T);
-                    packed.PackVector(c.ToVector4());
+                    packed.PackFromVector4(c.ToVector4());
                     safe.Add(packed);
                 }
 

src/ImageProcessorCore/Quantizers/Wu/WuQuantizer.cs

@@ -745,7 +745,7 @@ namespace ImageProcessorCore.Quantizers
                     byte a = (byte)(Volume(cube[k], this.vma) / weight);
 
                     T color = default(T);
-                    color.PackBytes(r, g, b, a);
+                    color.PackFromBytes(r, g, b, a);
 
                     if (color.Equals(default(T)))
                     {

src/ImageProcessorCore/Samplers/Processors/CompandingResizeProcessor.cs

@@ -124,7 +124,7 @@ namespace ImageProcessorCore.Processors
                             }
 
                             T d = default(T);
-                            d.PackVector(destination.Compress());
+                            d.PackFromVector4(destination.Compress());
                             firstPassPixels[x, y] = d;
                         }
                     });
@@ -151,7 +151,7 @@ namespace ImageProcessorCore.Processors
                             }
 
                             T d = default(T);
-                            d.PackVector(destination.Compress());
+                            d.PackFromVector4(destination.Compress());
                             targetPixels[x, y] = d;
                         }
 

src/ImageProcessorCore/Samplers/Processors/ResizeProcessor.cs

@@ -123,7 +123,7 @@ namespace ImageProcessorCore.Processors
                             }
 
                             T d = default(T);
-                            d.PackVector(destination);
+                            d.PackFromVector4(destination);
                             firstPassPixels[x, y] = d;
                         }
                     });
@@ -150,7 +150,7 @@ namespace ImageProcessorCore.Processors
                             }
 
                             T d = default(T);
-                            d.PackVector(destination);
+                            d.PackFromVector4(destination);
                             targetPixels[x, y] = d;
                         }
 

tests/ImageProcessorCore.Tests/Colors/Class.cs → tests/ImageProcessorCore.Tests/Colors/ColorTests.cs

@@ -75,23 +75,17 @@ namespace ImageProcessorCore.Tests
             Assert.Equal(0, color3.B);
             Assert.Equal(255, color3.A);
 
-            //Color color4 = new Color(new Vector3(1, .1f, .133f));
+            Color color4 = new Color(new Vector3(1, .1f, .133f));
-            //Assert.Equal(1, color4.R, 1);
+            Assert.Equal(255, color4.R);
-            //Assert.Equal(.1f, color4.G, 1);
+            Assert.Equal(Math.Round(.1f * 255), color4.G);
-            //Assert.Equal(.133f, color4.B, 3);
+            Assert.Equal(Math.Round(.133f * 255), color4.B);
-            //Assert.Equal(1, color4.A, 1);
+            Assert.Equal(255, color4.A);
 
-            //Color color5 = new Color(new Vector3(1, .1f, .133f), .5f);
+            Color color5 = new Color(new Vector4(1, .1f, .133f, .5f));
-            //Assert.Equal(1, color5.R, 1);
+            Assert.Equal(255, color5.R);
-            //Assert.Equal(.1f, color5.G, 1);
+            Assert.Equal(Math.Round(.1f * 255), color5.G);
-            //Assert.Equal(.133f, color5.B, 3);
+            Assert.Equal(Math.Round(.133f * 255), color5.B);
-            //Assert.Equal(.5f, color5.A, 1);
+            Assert.Equal(Math.Round(.5f * 255), color5.A);
-
-            Color color6 = new Color(new Vector4(1, .1f, .133f, .5f));
-            Assert.Equal(255, color6.R);
-            Assert.Equal(Math.Round(.1f * 255), color6.G);
-            Assert.Equal(Math.Round(.133f * 255), color6.B);
-            Assert.Equal(Math.Round(.5f * 255), color6.A);
         }
 
         /// <summary>
@@ -102,7 +96,7 @@ namespace ImageProcessorCore.Tests
         {
             const string First = "FF000000";
             Color color = Color.Black;
-            string second = color.PackedValue().ToString("X");
+            string second = color.GetPackedValue().ToString("X");
             Assert.Equal(First, second);
         }
     }