Browse Source

Use classes

af/merge-core
James Jackson-South 8 years ago
parent
commit
eba6669078
  1. 11
      src/ImageSharp/ColorSpaces/Conversion/Implementation/Rgb/RgbWorkingSpace.cs
  2. 3
      tests/ImageSharp.Tests/Colorspaces/RgbAndCieXyzConversionTest.cs
  3. 3
      tests/ImageSharp.Tests/Colorspaces/RgbAndCmykConversionTest.cs
  4. 3
      tests/ImageSharp.Tests/Colorspaces/RgbAndHslConversionTest.cs
  5. 3
      tests/ImageSharp.Tests/Colorspaces/RgbAndHsvConversionTest.cs
  6. 3
      tests/ImageSharp.Tests/Colorspaces/RgbAndYCbCrConversionTest.cs

11
src/ImageSharp/ColorSpaces/Conversion/Implementation/Rgb/RgbWorkingSpace.cs

@ -6,10 +6,10 @@ namespace SixLabors.ImageSharp.ColorSpaces.Conversion.Implementation.RgbColorSap
/// <summary>
/// Trivial implementation of <see cref="IRgbWorkingSpace"/>
/// </summary>
internal struct RgbWorkingSpace : IRgbWorkingSpace
internal class RgbWorkingSpace : IRgbWorkingSpace
{
/// <summary>
/// Initializes a new instance of the <see cref="RgbWorkingSpace"/> struct.
/// Initializes a new instance of the <see cref="RgbWorkingSpace"/> class.
/// </summary>
/// <param name="referenceWhite">The reference white point.</param>
/// <param name="companding">The function pair for converting to <see cref="CieXyz"/> and back.</param>
@ -84,11 +84,10 @@ namespace SixLabors.ImageSharp.ColorSpaces.Conversion.Implementation.RgbColorSap
/// <inheritdoc/>
public bool Equals(IRgbWorkingSpace other)
{
// This should be refactored as separate classes with different companding implementations.
return this.WhitePoint.Equals(other.WhitePoint)
&& this.ChromaticityCoordinates.Equals(other.ChromaticityCoordinates);
// TODO: This should be refactored as separate classes with different companding implementations.
// && Equals(this.Companding, other.Companding);
&& this.ChromaticityCoordinates.Equals(other.ChromaticityCoordinates)
&& Equals(this.Companding, other.Companding);
}
/// <inheritdoc/>

3
tests/ImageSharp.Tests/Colorspaces/RgbAndCieXyzConversionTest.cs

@ -40,8 +40,7 @@ namespace SixLabors.ImageSharp.Tests.Colorspaces
Rgb output = converter.ToRgb(input);
// Assert
// TODO: Enable next line
// Assert.Equal(Rgb.DefaultWorkingSpace, output.WorkingSpace);
Assert.Equal(Rgb.DefaultWorkingSpace, output.WorkingSpace);
Assert.Equal(r, output.R, FloatRoundingComparer);
Assert.Equal(g, output.G, FloatRoundingComparer);
Assert.Equal(b, output.B, FloatRoundingComparer);

3
tests/ImageSharp.Tests/Colorspaces/RgbAndCmykConversionTest.cs

@ -38,8 +38,7 @@ namespace SixLabors.ImageSharp.Tests.Colorspaces
Rgb output = Converter.ToRgb(input);
// Assert
// TODO: Enable next line
// Assert.Equal(Rgb.DefaultWorkingSpace, output.WorkingSpace);
Assert.Equal(Rgb.DefaultWorkingSpace, output.WorkingSpace);
Assert.Equal(r, output.R, FloatRoundingComparer);
Assert.Equal(g, output.G, FloatRoundingComparer);
Assert.Equal(b, output.B, FloatRoundingComparer);

3
tests/ImageSharp.Tests/Colorspaces/RgbAndHslConversionTest.cs

@ -41,8 +41,7 @@ namespace SixLabors.ImageSharp.Tests.Colorspaces
Rgb output = Converter.ToRgb(input);
// Assert
// TODO: Enable next line
// Assert.Equal(Rgb.DefaultWorkingSpace, output.WorkingSpace);
Assert.Equal(Rgb.DefaultWorkingSpace, output.WorkingSpace);
Assert.Equal(r, output.R, FloatRoundingComparer);
Assert.Equal(g, output.G, FloatRoundingComparer);
Assert.Equal(b, output.B, FloatRoundingComparer);

3
tests/ImageSharp.Tests/Colorspaces/RgbAndHsvConversionTest.cs

@ -40,8 +40,7 @@ namespace SixLabors.ImageSharp.Tests.Colorspaces
Rgb output = Converter.ToRgb(input);
// Assert
// TODO: Enable next line
// Assert.Equal(Rgb.DefaultWorkingSpace, output.WorkingSpace);
Assert.Equal(Rgb.DefaultWorkingSpace, output.WorkingSpace);
Assert.Equal(r, output.R, FloatRoundingComparer);
Assert.Equal(g, output.G, FloatRoundingComparer);
Assert.Equal(b, output.B, FloatRoundingComparer);

3
tests/ImageSharp.Tests/Colorspaces/RgbAndYCbCrConversionTest.cs

@ -36,8 +36,7 @@ namespace SixLabors.ImageSharp.Tests.Colorspaces
Rgb output = Converter.ToRgb(input);
// Assert
// TODO: Enable next line
// Assert.Equal(Rgb.DefaultWorkingSpace, output.WorkingSpace);
Assert.Equal(Rgb.DefaultWorkingSpace, output.WorkingSpace);
Assert.Equal(r, output.R, FloatRoundingComparer);
Assert.Equal(g, output.G, FloatRoundingComparer);
Assert.Equal(b, output.B, FloatRoundingComparer);

Loading…
Cancel
Save