From f3d79643cf35629c5fc5e6d434bbebc564413d5d Mon Sep 17 00:00:00 2001
From: James Jackson-South <james_south@hotmail.com>
Date: Wed, 7 Nov 2018 00:00:41 +0000
Subject: [PATCH] Cleanup TransformKernel and handle negative transform
 dimensions

---
 .../Transforms/AffineTransformProcessor.cs        |  6 ++++++
 .../Processors/Transforms/TransformKernelMap.cs   | 15 ++++++---------
 2 files changed, 12 insertions(+), 9 deletions(-)

diff --git a/src/ImageSharp/Processing/Processors/Transforms/AffineTransformProcessor.cs b/src/ImageSharp/Processing/Processors/Transforms/AffineTransformProcessor.cs
index edddab181..f63baa95c 100644
--- a/src/ImageSharp/Processing/Processors/Transforms/AffineTransformProcessor.cs
+++ b/src/ImageSharp/Processing/Processors/Transforms/AffineTransformProcessor.cs
@@ -38,6 +38,12 @@ namespace SixLabors.ImageSharp.Processing.Processors.Transforms
 
             // We want to resize the canvas here taking into account any translations.
             this.TargetDimensions = new Size(this.transformedRectangle.Right, this.transformedRectangle.Bottom);
+
+            // Handle a negative translation that exceeds the original with of the image.
+            if (this.TargetDimensions.Width <= 0 || this.TargetDimensions.Height <= 0)
+            {
+                this.TargetDimensions = sourceSize;
+            }
         }
 
         /// <summary>
diff --git a/src/ImageSharp/Processing/Processors/Transforms/TransformKernelMap.cs b/src/ImageSharp/Processing/Processors/Transforms/TransformKernelMap.cs
index 5acc7213c..531edbc45 100644
--- a/src/ImageSharp/Processing/Processors/Transforms/TransformKernelMap.cs
+++ b/src/ImageSharp/Processing/Processors/Transforms/TransformKernelMap.cs
@@ -21,8 +21,6 @@ namespace SixLabors.ImageSharp.Processing.Processors.Transforms
     {
         private readonly Buffer2D<float> yBuffer;
         private readonly Buffer2D<float> xBuffer;
-        private readonly float yScale;
-        private readonly float xScale;
         private readonly int yLength;
         private readonly int xLength;
         private readonly Vector2 extents;
@@ -39,12 +37,10 @@ namespace SixLabors.ImageSharp.Processing.Processors.Transforms
         public TransformKernelMap(Configuration configuration, Size source, Size destination, IResampler sampler)
         {
             this.sampler = sampler;
-            (float radius, float scale) yRadiusScale = this.GetSamplingRadius(source.Height, destination.Height);
-            (float radius, float scale) xRadiusScale = this.GetSamplingRadius(source.Width, destination.Width);
+            float yRadius = this.GetSamplingRadius(source.Height, destination.Height);
+            float xRadius = this.GetSamplingRadius(source.Width, destination.Width);
 
-            this.yScale = yRadiusScale.scale;
-            this.xScale = xRadiusScale.scale;
-            this.extents = new Vector2(xRadiusScale.radius, yRadiusScale.radius);
+            this.extents = new Vector2(xRadius, yRadius);
             this.xLength = (int)MathF.Ceiling((this.extents.X * 2) + 2);
             this.yLength = (int)MathF.Ceiling((this.extents.Y * 2) + 2);
 
@@ -167,7 +163,8 @@ namespace SixLabors.ImageSharp.Processing.Processors.Transforms
             // }
         }
 
-        private (float radius, float scale) GetSamplingRadius(int sourceSize, int destinationSize)
+        [MethodImpl(InliningOptions.ShortMethod)]
+        private float GetSamplingRadius(int sourceSize, int destinationSize)
         {
             float scale = (float)sourceSize / destinationSize;
 
@@ -176,7 +173,7 @@ namespace SixLabors.ImageSharp.Processing.Processors.Transforms
                 scale = 1F;
             }
 
-            return (MathF.Ceiling(scale * this.sampler.Radius), scale);
+            return MathF.Ceiling(scale * this.sampler.Radius);
         }
 
         public void Dispose()