ImageSharp

Commit Graph

Author	SHA1	Message	Date
James Jackson-South	6384f44501	Merge namespaces	6 years ago
Anton Firszov	7c45f467d5	expose ParallelExecutionSettings and ParallelHelper, fix MaxDegreeOfParallelism	6 years ago
Anton Firszov	1993facee2	expose limited Buffer2D internals, smplify API surface	6 years ago
Simon Cropp	564348631f	use var where apparent (#972 ) * use var where apparent * use var where apparent * should use Rgb24	7 years ago
Simon Cropp	6f1134102c	Cleanup (#965 ) * redundant () * redundant stirng interpolation * use method groups * redundant unsafe * redundant qualifiers * redundant () * redundant init * redundant init * redundant casts * redundant casts	7 years ago
Anthony Truskinger	ff269db0bd	Now throws a better excpetion DrawImage source does not overlap target (#877 ) * No longer throws when DrawImage source does not overlap target Previously, when DrawImage was used to overlay an image, in cases where the source image did not overlap the target image, a very confusing error was reported: "System.ArgumentOutOfRangeException: Specified argument was out of the range of valid values. Parameter name: MaxDegreeOfParallelism" Now, when this case happens, the DrawImage method will simply not affect the target image, which is the same way FillRegionProcessor handles such cases. ParallelHelper.IterRows also now does more validation of the input rectangle so that any further cases of this kind of problem throw a more relvant exception. Note I switched from DebugGuard to Guard because IterRows is a public API and thus should always validate its inputs. Fixes #875 * Refines DrawImage non-overlap error logic Adresses PR feedback in #877. Changes DrawImage shortcut to be less than or equal to. Also changes maxX calculation to use `Right` over `Width`. This is a semantic change that reflects intention better. No actual change because Top,Left for that rectanngle should always be 0,0. And adds more informative argument names to ParallelHelper.IterRows error message. * Non-overlapping DrawImage now throws Adressing PR feedback from #877 DrawImage now throws when the source image does not overlap, with a useful error message. Also improved the error messages for IterRows (and added validation to the other IterRows method) * DrawImage overlap test changed to support RELEASE The tests on the CI server are run in RELEASE which wrap the expected exception with an ImageProcessingException. * Adress feedback for DrawImage exception DrawImage throws an ImageProcessor exception which makes it easier to catch. And reverted IterRows to use Guard helpers	7 years ago
Anton Firszov	00992043bb	fixed ParallelHelper + improved tests	7 years ago
Anton Firszov	55b30e8a28	DetectEdgesTest.DetectEdges_InBox issue isolated in a failing test for ParallelHelper.IterateRows()	7 years ago
Anton Firszov	feb1a44356	implemented IterateRowsWithTempBuffer<T>	8 years ago
Anton Firszov	4bfafc97b5	implemented ParallelHelper.IterateRows()	8 years ago
Anton Firszov	c094e12ba7	ParallelHelper.IterateRows WIP	8 years ago

11 Commits (60008fc740f83c62aefd86e6dd77f4e5cc985fa8)