Browse Source

Disable audit logging for Get requests by default.

pull/395/head
Halil ibrahim Kalkan 8 years ago
parent
commit
00a0fce9e3
  1. 13
      framework/src/Volo.Abp.AspNetCore/Volo/Abp/AspNetCore/Auditing/AbpAuditingMiddleware.cs
  2. 6
      framework/src/Volo.Abp.Auditing/Volo/Abp/Auditing/AbpAuditingOptions.cs

13
framework/src/Volo.Abp.AspNetCore/Volo/Abp/AspNetCore/Auditing/AbpAuditingMiddleware.cs

@ -1,4 +1,5 @@
using System.Threading.Tasks; using System;
using System.Threading.Tasks;
using Microsoft.AspNetCore.Http; using Microsoft.AspNetCore.Http;
using Microsoft.Extensions.Options; using Microsoft.Extensions.Options;
using Volo.Abp.Auditing; using Volo.Abp.Auditing;
@ -29,7 +30,7 @@ namespace Volo.Abp.AspNetCore.Auditing
public async Task Invoke(HttpContext httpContext) public async Task Invoke(HttpContext httpContext)
{ {
if (!ShouldWriteAuditLog()) if (!ShouldWriteAuditLog(httpContext))
{ {
await _next(httpContext); await _next(httpContext);
return; return;
@ -48,7 +49,7 @@ namespace Volo.Abp.AspNetCore.Auditing
} }
} }
private bool ShouldWriteAuditLog() private bool ShouldWriteAuditLog(HttpContext httpContext)
{ {
if (!Options.IsEnabled) if (!Options.IsEnabled)
{ {
@ -60,6 +61,12 @@ namespace Volo.Abp.AspNetCore.Auditing
return false; return false;
} }
if (!Options.IsEnabledForGetRequests &&
string.Equals(httpContext.Request.Method, HttpMethods.Get, StringComparison.OrdinalIgnoreCase))
{
return false;
}
return true; return true;
} }
} }

6
framework/src/Volo.Abp.Auditing/Volo/Abp/Auditing/AbpAuditingOptions.cs

@ -24,6 +24,12 @@ namespace Volo.Abp.Auditing
public List<Type> IgnoredTypes { get; } public List<Type> IgnoredTypes { get; }
public IEntityHistorySelectorList EntityHistorySelectors { get; } public IEntityHistorySelectorList EntityHistorySelectors { get; }
//TODO: Move this to asp.net core layer or convert it to a more dynamic strategy?
/// <summary>
/// Default: false.
/// </summary>
public bool IsEnabledForGetRequests { get; set; }
public AbpAuditingOptions() public AbpAuditingOptions()
{ {

Loading…
Cancel
Save