mirror of https://github.com/abpframework/abp.git
Browse Source
# Conflicts: # framework/test/Volo.Abp.EntityFrameworkCore.Tests/Volo/Abp/EntityFrameworkCore/TestMigrationsDbContext.cs # framework/test/Volo.Abp.EntityFrameworkCore.Tests/Volo/Abp/TestApp/EntityFrameworkCore/TestAppDbContext.cspull/25568/head
maliming
4 months ago
9 changed files with 113 additions and 3 deletions
@ -0,0 +1,48 @@ |
|||
using System; |
|||
using System.Linq; |
|||
using System.Threading.Tasks; |
|||
using Microsoft.EntityFrameworkCore; |
|||
using Microsoft.Extensions.DependencyInjection; |
|||
using Shouldly; |
|||
using Volo.Abp.Data; |
|||
using Volo.Abp.Domain.Repositories; |
|||
using Volo.Abp.TestApp.Domain; |
|||
using Volo.Abp.TestApp.EntityFrameworkCore; |
|||
using Volo.Abp.TestApp.Testing; |
|||
using Xunit; |
|||
|
|||
namespace Volo.Abp.EntityFrameworkCore.DataFiltering; |
|||
|
|||
// Regression for the soft-delete DbFunction translator hardcoding a bool false literal
|
|||
// with the bool TypeMapping instead of routing the literal through the IsDeleted
|
|||
// property's ValueConverter. EntityWithIntSoftDelete maps false->5, true->9, so the
|
|||
// buggy SQL "is_deleted = 0" matches no row (returns 0) while the correct SQL
|
|||
// "is_deleted = 5" matches the not-deleted row (returns 1).
|
|||
public class SoftDelete_DbFunction_Bool_Literal_Tests : TestAppTestBase<AbpEntityFrameworkCoreTestModule> |
|||
{ |
|||
private readonly IRepository<EntityWithIntSoftDelete, Guid> _repository; |
|||
private readonly IDataFilter<ISoftDelete> _softDeleteFilter; |
|||
|
|||
public SoftDelete_DbFunction_Bool_Literal_Tests() |
|||
{ |
|||
_repository = GetRequiredService<IRepository<EntityWithIntSoftDelete, Guid>>(); |
|||
_softDeleteFilter = GetRequiredService<IDataFilter<ISoftDelete>>(); |
|||
} |
|||
|
|||
[Fact] |
|||
public async Task SoftDelete_Filter_Should_Route_False_Literal_Through_ValueConverter() |
|||
{ |
|||
await _repository.InsertAsync(new EntityWithIntSoftDelete { Name = "kept" }); |
|||
await _repository.InsertAsync(new EntityWithIntSoftDelete { Name = "removed", IsDeleted = true }); |
|||
|
|||
var visible = await _repository.GetListAsync(); |
|||
visible.Count.ShouldBe(1); |
|||
visible[0].Name.ShouldBe("kept"); |
|||
|
|||
using (_softDeleteFilter.Disable()) |
|||
{ |
|||
var all = await _repository.GetListAsync(); |
|||
all.Count.ShouldBe(2); |
|||
} |
|||
} |
|||
} |
|||
@ -0,0 +1,19 @@ |
|||
using System; |
|||
using Volo.Abp.Domain.Entities; |
|||
|
|||
namespace Volo.Abp.TestApp.Domain; |
|||
|
|||
// Uses a custom bool<->int converter where false maps to a non-zero value, so the
|
|||
// soft-delete DbFunction translator (which hardcodes a bool false literal with the
|
|||
// bool TypeMapping) is observably wrong on every provider: the generated SQL
|
|||
// compares against 0/FALSE instead of the converter's actual provider value (5).
|
|||
public class EntityWithIntSoftDelete : AggregateRoot<Guid>, ISoftDelete |
|||
{ |
|||
public const string IsDeletedColumnName = "is_deleted"; |
|||
public const int NotDeletedProviderValue = 5; |
|||
public const int DeletedProviderValue = 9; |
|||
|
|||
public string Name { get; set; } |
|||
|
|||
public bool IsDeleted { get; set; } |
|||
} |
|||
Loading…
Reference in new issue