Add logging for DateTime conversion failures

framework/src/Volo.Abp.AspNetCore.Mvc/Volo/Abp/AspNetCore/Mvc/ModelBinding/AbpDateTimeModelBinder.cs

@@ -2,19 +2,27 @@
 using System.Threading.Tasks;
 using Microsoft.AspNetCore.Mvc.ModelBinding;
 using Microsoft.AspNetCore.Mvc.ModelBinding.Binders;
+using Microsoft.Extensions.Logging;
 using Volo.Abp.Timing;
 
 namespace Volo.Abp.AspNetCore.Mvc.ModelBinding;
 
 public class AbpDateTimeModelBinder : IModelBinder
 {
+    private readonly ILogger<AbpDateTimeModelBinder> _logger;
     private readonly DateTimeModelBinder _dateTimeModelBinder;
     private readonly IClock _clock;
     private readonly ICurrentTimezoneProvider _currentTimezoneProvider;
     private readonly ITimezoneProvider _timezoneProvider;
 
-    public AbpDateTimeModelBinder(DateTimeModelBinder dateTimeModelBinder, IClock clock, ICurrentTimezoneProvider currentTimezoneProvider, ITimezoneProvider timezoneProvider)
+    public AbpDateTimeModelBinder(
+        ILogger<AbpDateTimeModelBinder> logger,
+        DateTimeModelBinder dateTimeModelBinder,
+        IClock clock,
+        ICurrentTimezoneProvider currentTimezoneProvider,
+        ITimezoneProvider timezoneProvider)
     {
+        _logger = logger;
         _dateTimeModelBinder = dateTimeModelBinder;
         _clock = clock;
         _currentTimezoneProvider = currentTimezoneProvider;
@@ -41,7 +49,7 @@ public class AbpDateTimeModelBinder : IModelBinder
             }
             catch
             {
-                // ignored
+                _logger.LogWarning("Could not convert DateTime with unspecified Kind using timezone '{TimeZone}'.", _currentTimezoneProvider.TimeZone);
             }
         }
 

framework/src/Volo.Abp.AspNetCore.Mvc/Volo/Abp/AspNetCore/Mvc/ModelBinding/AbpDateTimeModelBinderProvider.cs

@@ -50,9 +50,6 @@ public class AbpDateTimeModelBinderProvider : IModelBinderProvider
     {
         const DateTimeStyles supportedStyles = DateTimeStyles.AllowWhiteSpaces | DateTimeStyles.AdjustToUniversal;
         var dateTimeModelBinder = new DateTimeModelBinder(supportedStyles, context.Services.GetRequiredService<ILoggerFactory>());
-        return new AbpDateTimeModelBinder(dateTimeModelBinder,
-            context.Services.GetRequiredService<IClock>(),
-            context.Services.GetRequiredService<ICurrentTimezoneProvider>(),
-            context.Services.GetRequiredService<ITimezoneProvider>());
+        return ActivatorUtilities.CreateInstance<AbpDateTimeModelBinder>(context.Services, dateTimeModelBinder);
     }
 }

framework/src/Volo.Abp.Json.Newtonsoft/Volo/Abp/Json/Newtonsoft/AbpDateTimeConverter.cs

@@ -2,6 +2,8 @@
 using System.Globalization;
 using System.Linq;
 using System.Reflection;
+using Microsoft.Extensions.Logging;
+using Microsoft.Extensions.Logging.Abstractions;
 using Microsoft.Extensions.Options;
 using Newtonsoft.Json;
 using Newtonsoft.Json.Converters;
@@ -15,6 +17,9 @@ namespace Volo.Abp.Json.Newtonsoft;
 public class AbpDateTimeConverter : DateTimeConverterBase, ITransientDependency
 {
     private const string DefaultDateTimeFormat = "yyyy'-'MM'-'dd'T'HH':'mm':'ss.FFFFFFFK";
+
+    public ILogger<AbpDateTimeConverter> Logger { get; set; }
+
     private readonly DateTimeStyles _dateTimeStyles = DateTimeStyles.RoundtripKind;
     private readonly CultureInfo _culture = CultureInfo.InvariantCulture;
     private readonly IClock _clock;
@@ -25,6 +30,8 @@ public class AbpDateTimeConverter : DateTimeConverterBase, ITransientDependency
 
     public AbpDateTimeConverter(IClock clock, IOptions<AbpJsonOptions> options, ICurrentTimezoneProvider currentTimezoneProvider, ITimezoneProvider timezoneProvider)
     {
+        Logger = NullLogger<AbpDateTimeConverter>.Instance;
+
         _clock = clock;
         _currentTimezoneProvider = currentTimezoneProvider;
         _timezoneProvider = timezoneProvider;
@@ -134,7 +141,7 @@ public class AbpDateTimeConverter : DateTimeConverterBase, ITransientDependency
         }
         catch
         {
-            // ignored
+            Logger.LogWarning("Could not convert DateTime with unspecified Kind using timezone '{TimeZone}'.", _currentTimezoneProvider.TimeZone);
         }
 
         return _skipDateTimeNormalization

framework/src/Volo.Abp.Json.SystemTextJson/Volo/Abp/Json/SystemTextJson/JsonConverters/AbpDateTimeConverterBase.cs

@@ -3,6 +3,8 @@ using System.Globalization;
 using System.Linq;
 using System.Text.Json;
 using System.Text.Json.Serialization;
+using Microsoft.Extensions.Logging;
+using Microsoft.Extensions.Logging.Abstractions;
 using Microsoft.Extensions.Options;
 using Volo.Abp.Timing;
 
@@ -10,6 +12,8 @@ namespace Volo.Abp.Json.SystemTextJson.JsonConverters;
 
 public abstract class AbpDateTimeConverterBase<T> : JsonConverter<T>
 {
+    public ILogger<AbpDateTimeConverterBase<T>> Logger { get; set; }
+
     protected IClock Clock { get; }
     protected AbpJsonOptions Options { get; }
     protected ICurrentTimezoneProvider CurrentTimezoneProvider { get; }
@@ -22,6 +26,8 @@ public abstract class AbpDateTimeConverterBase<T> : JsonConverter<T>
         ICurrentTimezoneProvider currentTimezoneProvider,
         ITimezoneProvider timezoneProvider)
     {
+        Logger = NullLogger<AbpDateTimeConverterBase<T>>.Instance;
+
         Clock = clock;
         CurrentTimezoneProvider = currentTimezoneProvider;
         TimezoneProvider = timezoneProvider;
@@ -102,7 +108,7 @@ public abstract class AbpDateTimeConverterBase<T> : JsonConverter<T>
         }
         catch
         {
-            // ignored
+            Logger.LogWarning("Could not convert DateTime with unspecified Kind using timezone '{TimeZone}'.", CurrentTimezoneProvider.TimeZone);
         }
 
         return IsSkipDateTimeNormalization ? dateTime : Clock.Normalize(dateTime);