Browse Source

Enhance unit tests for permission and remove unnecessary todo.

pull/208/head
Halil İbrahim Kalkan 9 years ago
parent
commit
078fab86c2
  1. 3
      src/Volo.Abp.Permissions/Volo/Abp/Permissions/PermissionManager.cs
  2. 4
      test/Volo.Abp.Permissions.Tests/Volo/Abp/Permissions/PermissionManager_User_Tests.cs

3
src/Volo.Abp.Permissions/Volo/Abp/Permissions/PermissionManager.cs

@ -81,9 +81,6 @@ namespace Volo.Abp.Permissions
return false; return false;
} }
//TODO: Should also return for non-granted permissions!
//TODO: Create a method for getting only granted permissions!
public virtual Task<List<PermissionGrantInfo>> GetAllAsync() public virtual Task<List<PermissionGrantInfo>> GetAllAsync()
{ {
return GetAllFromProvidersAsync(Providers.Value, null); return GetAllFromProvidersAsync(Providers.Value, null);

4
test/Volo.Abp.Permissions.Tests/Volo/Abp/Permissions/PermissionManager_User_Tests.cs

@ -78,7 +78,7 @@ namespace Volo.Abp.Permissions
//User1 //User1
var permission = await _permissionManager.GetAllForUserAsync(PermissionTestDataBuilder.User1Id); var permission = await _permissionManager.GetAllForUserAsync(PermissionTestDataBuilder.User1Id);
permission.Count.ShouldBeGreaterThan(0); permission.Count.ShouldBeGreaterThan(0);
permission.ShouldContain(p => p.Name == "MyPermission1" && p.IsGranted); permission.ShouldContain(p => p.Name == "MyPermission1" && p.IsGranted && p.ProviderName == UserPermissionValueProvider.ProviderName);
//User2 //User2
permission = await _permissionManager.GetAllForUserAsync(PermissionTestDataBuilder.User2Id); permission = await _permissionManager.GetAllForUserAsync(PermissionTestDataBuilder.User2Id);
@ -93,7 +93,7 @@ namespace Volo.Abp.Permissions
_currentUserId = PermissionTestDataBuilder.User1Id; _currentUserId = PermissionTestDataBuilder.User1Id;
var permission = await _permissionManager.GetAllForCurrentUserAsync(); var permission = await _permissionManager.GetAllForCurrentUserAsync();
permission.Count.ShouldBeGreaterThan(0); permission.Count.ShouldBeGreaterThan(0);
permission.ShouldContain(p => p.Name == "MyPermission1" && p.IsGranted); permission.ShouldContain(p => p.Name == "MyPermission1" && p.IsGranted && p.ProviderName == UserPermissionValueProvider.ProviderName);
//User2 //User2
_currentUserId = PermissionTestDataBuilder.User2Id; _currentUserId = PermissionTestDataBuilder.User2Id;

Loading…
Cancel
Save