Merge pull request #22498 from abpframework/19660

feat: add includeChildren parameter to GetMembersCountAsync for hierarchical member counting

modules/identity/src/Volo.Abp.Identity.Domain/Volo/Abp/Identity/IOrganizationUnitRepository.cs

@@ -98,18 +98,21 @@ public interface IOrganizationUnitRepository : IBasicRepository<OrganizationUnit
         int maxResultCount = int.MaxValue,
         int skipCount = 0,
         string filter = null,
+        bool includeChildren = false,
         bool includeDetails = false,
         CancellationToken cancellationToken = default
     );
 
     Task<List<Guid>> GetMemberIdsAsync(
         Guid id,
+        bool includeChildren = false,
         CancellationToken cancellationToken = default
     );
 
     Task<int> GetMembersCountAsync(
         OrganizationUnit organizationUnit,
         string filter = null,
+        bool includeChildren = false,
         CancellationToken cancellationToken = default
     );
 

modules/identity/src/Volo.Abp.Identity.Domain/Volo/Abp/Identity/IdentityUserManager.cs

@@ -395,14 +395,14 @@ public class IdentityUserManager : UserManager<IdentityUser>, IDomainService
         var sourceOrganization = await OrganizationUnitRepository.GetAsync(sourceOrganizationId, cancellationToken: CancellationToken);
 
         Logger.LogDebug($"Remove dynamic claims cache for users of organization: {sourceOrganizationId}");
-        var userIdList = await OrganizationUnitRepository.GetMemberIdsAsync(sourceOrganizationId, cancellationToken: CancellationToken);
+        var userIdList = await OrganizationUnitRepository.GetMemberIdsAsync(sourceOrganizationId, includeChildren: true, cancellationToken: CancellationToken);
         await DynamicClaimCache.RemoveManyAsync(userIdList.Select(userId => AbpDynamicClaimCacheItem.CalculateCacheKey(userId, sourceOrganization.TenantId)), token: CancellationToken);
 
         var targetOrganization = targetOrganizationId.HasValue ? await OrganizationUnitRepository.GetAsync(targetOrganizationId.Value, cancellationToken: CancellationToken) : null;
         if (targetOrganization != null)
         {
             Logger.LogDebug($"Remove dynamic claims cache for users of organization: {targetOrganizationId}");
-            userIdList = await OrganizationUnitRepository.GetMemberIdsAsync(targetOrganizationId.Value, cancellationToken: CancellationToken);
+            userIdList = await OrganizationUnitRepository.GetMemberIdsAsync(targetOrganizationId.Value, includeChildren: true, cancellationToken: CancellationToken);
             await DynamicClaimCache.RemoveManyAsync(userIdList.Select(userId => AbpDynamicClaimCacheItem.CalculateCacheKey(userId, targetOrganization.TenantId)), token: CancellationToken);
         }
 

modules/identity/src/Volo.Abp.Identity.EntityFrameworkCore/Volo/Abp/Identity/EntityFrameworkCore/EfCoreIdentityUserRepository.cs

@@ -7,6 +7,7 @@ using System.Threading;
 using System.Threading.Tasks;
 using JetBrains.Annotations;
 using Microsoft.EntityFrameworkCore;
+using Volo.Abp.Domain.Entities;
 using Volo.Abp.Domain.Repositories.EntityFrameworkCore;
 using Volo.Abp.EntityFrameworkCore;
 
@@ -420,9 +421,20 @@ public class EfCoreIdentityUserRepository : EfCoreRepository<IIdentityDbContext,
     {
         if (targetOrganizationId != null)
         {
+            var sourceOrganization = await (await GetDbContextAsync()).Set<OrganizationUnit>().FirstOrDefaultAsync(x => x.Id == sourceOrganizationId, cancellationToken: cancellationToken);
+            if (sourceOrganization == null)
+            {
+                throw new EntityNotFoundException(typeof(OrganizationUnit), sourceOrganizationId);
+            }
+
+            var allSourceOrganizationIds = await (await GetDbContextAsync()).Set<OrganizationUnit>()
+                .Where(x => x.Code.StartsWith(sourceOrganization.Code))
+                .Select(x => x.Id).ToArrayAsync(cancellationToken: cancellationToken);
+
             var users = await (await GetDbContextAsync()).Set<IdentityUserOrganizationUnit>().Where(x => x.OrganizationUnitId == targetOrganizationId).Select(x => x.UserId).ToArrayAsync(cancellationToken: cancellationToken);
-            await (await GetDbContextAsync()).Set<IdentityUserOrganizationUnit>().Where(x => x.OrganizationUnitId == sourceOrganizationId && !users.Contains(x.UserId)).ExecuteUpdateAsync(t => t.SetProperty(e => e.OrganizationUnitId, targetOrganizationId), GetCancellationToken(cancellationToken));
-            await (await GetDbContextAsync()).Set<IdentityUserOrganizationUnit>().Where(x => x.OrganizationUnitId == sourceOrganizationId).ExecuteDeleteAsync(GetCancellationToken(cancellationToken));
+
+            await (await GetDbContextAsync()).Set<IdentityUserOrganizationUnit>().Where(x => allSourceOrganizationIds.Contains(x.OrganizationUnitId) && !users.Contains(x.UserId)).ExecuteUpdateAsync(t => t.SetProperty(e => e.OrganizationUnitId, targetOrganizationId), GetCancellationToken(cancellationToken));
+            await (await GetDbContextAsync()).Set<IdentityUserOrganizationUnit>().Where(x => allSourceOrganizationIds.Contains(x.OrganizationUnitId)).ExecuteDeleteAsync(GetCancellationToken(cancellationToken));
         }
         else
         {

modules/identity/src/Volo.Abp.Identity.EntityFrameworkCore/Volo/Abp/Identity/EntityFrameworkCore/EfCoreOrganizationUnitRepository.cs

@@ -208,32 +208,31 @@ public class EfCoreOrganizationUnitRepository
         int maxResultCount = int.MaxValue,
         int skipCount = 0,
         string filter = null,
+        bool includeChildren = false,
         bool includeDetails = false,
         CancellationToken cancellationToken = default)
     {
-        var query = await CreateGetMembersFilteredQueryAsync(organizationUnit, filter);
+        var query = await CreateGetMembersFilteredQueryAsync(organizationUnit, filter, includeChildren);
 
         return await query.IncludeDetails(includeDetails).OrderBy(sorting.IsNullOrEmpty() ? nameof(IdentityUser.UserName) : sorting)
                     .PageBy(skipCount, maxResultCount)
                     .ToListAsync(GetCancellationToken(cancellationToken));
     }
 
-    public virtual async Task<List<Guid>> GetMemberIdsAsync(Guid id, CancellationToken cancellationToken = default)
+    public virtual async Task<List<Guid>> GetMemberIdsAsync(Guid id, bool includeChildren = false, CancellationToken cancellationToken = default)
     {
-        var dbContext = await GetDbContextAsync();
-
-        return await (from userOu in dbContext.Set<IdentityUserOrganizationUnit>()
-            join user in dbContext.Users on userOu.UserId equals user.Id
-            where userOu.OrganizationUnitId == id
-            select user.Id).ToListAsync(cancellationToken);
+        var organizationUnit = await GetAsync(id, cancellationToken: cancellationToken);
+        var query = await CreateGetMembersFilteredQueryAsync(organizationUnit, null, includeChildren);
+        return await query.Select(x => x.Id).ToListAsync(cancellationToken);
     }
 
     public virtual async Task<int> GetMembersCountAsync(
         OrganizationUnit organizationUnit,
         string filter = null,
+        bool includeChildren = false,
         CancellationToken cancellationToken = default)
     {
-        var query = await CreateGetMembersFilteredQueryAsync(organizationUnit, filter);
+        var query = await CreateGetMembersFilteredQueryAsync(organizationUnit, filter, includeChildren);
 
         return await query.CountAsync(GetCancellationToken(cancellationToken));
     }
@@ -324,14 +323,33 @@ public class EfCoreOrganizationUnitRepository
         dbContext.Set<IdentityUserOrganizationUnit>().RemoveRange(ouMembersQuery);
     }
 
-    protected virtual async Task<IQueryable<IdentityUser>> CreateGetMembersFilteredQueryAsync(OrganizationUnit organizationUnit, string filter = null)
+    protected virtual async Task<IQueryable<IdentityUser>> CreateGetMembersFilteredQueryAsync(
+        OrganizationUnit organizationUnit,
+        string filter = null,
+        bool includeChildren = false)
     {
         var dbContext = await GetDbContextAsync();
 
-        var query = from userOu in dbContext.Set<IdentityUserOrganizationUnit>()
-                    join user in dbContext.Users on userOu.UserId equals user.Id
-                    where userOu.OrganizationUnitId == organizationUnit.Id
-                    select user;
+        IQueryable<IdentityUser> query;
+        if (includeChildren)
+        {
+            var childrenIds = await (await GetDbSetAsync())
+                .Where(ou => ou.Code.StartsWith(organizationUnit.Code))
+                .Select(x => x.Id)
+                .ToListAsync();
+
+            query = from userOu in dbContext.Set<IdentityUserOrganizationUnit>()
+                join user in dbContext.Users on userOu.UserId equals user.Id
+                where childrenIds.Contains(userOu.OrganizationUnitId)
+                select user;
+        }
+        else
+        {
+            query = from userOu in dbContext.Set<IdentityUserOrganizationUnit>()
+                join user in dbContext.Users on userOu.UserId equals user.Id
+                where userOu.OrganizationUnitId == organizationUnit.Id
+                select user;
+        }
 
         if (!filter.IsNullOrWhiteSpace())
         {

modules/identity/src/Volo.Abp.Identity.MongoDB/Volo/Abp/Identity/MongoDB/MongoIdentityUserRepository.cs

@@ -8,6 +8,7 @@ using System.Threading.Tasks;
 using JetBrains.Annotations;
 using MongoDB.Driver;
 using MongoDB.Driver.Linq;
+using Volo.Abp.Domain.Entities;
 using Volo.Abp.Domain.Repositories.MongoDB;
 using Volo.Abp.MongoDB;
 
@@ -358,13 +359,30 @@ public class MongoIdentityUserRepository : MongoDbRepository<IAbpIdentityMongoDb
 
     public virtual async Task UpdateOrganizationAsync(Guid sourceOrganizationId, Guid? targetOrganizationId, CancellationToken cancellationToken = default)
     {
+        var sourceOrganizationUnit = await (await GetMongoQueryableAsync<OrganizationUnit>(cancellationToken))
+            .Where(x => x.Id == sourceOrganizationId)
+            .FirstOrDefaultAsync(cancellationToken: cancellationToken);
+        if (sourceOrganizationUnit == null)
+        {
+            throw new EntityNotFoundException(typeof(OrganizationUnit), sourceOrganizationId);
+        }
+
+        var allSourceOrganizationIds = await (await GetMongoQueryableAsync<OrganizationUnit>(cancellationToken))
+            .Where(x => x.Code.StartsWith(sourceOrganizationUnit.Code))
+            .Select(x => x.Id)
+            .ToListAsync(cancellationToken: cancellationToken);
+
         var users = await (await GetMongoQueryableAsync(cancellationToken))
-            .Where(x => x.OrganizationUnits.Any(r => r.OrganizationUnitId == sourceOrganizationId))
+            .Where(x => x.OrganizationUnits.Any(r => allSourceOrganizationIds.Contains(r.OrganizationUnitId)))
             .ToListAsync(GetCancellationToken(cancellationToken));
 
         foreach (var user in users)
         {
-            user.RemoveOrganizationUnit(sourceOrganizationId);
+            foreach (var organizationId in allSourceOrganizationIds)
+            {
+                user.RemoveOrganizationUnit(organizationId);
+            }
+
             if (targetOrganizationId.HasValue)
             {
                 user.AddOrganizationUnit(targetOrganizationId.Value);

modules/identity/src/Volo.Abp.Identity.MongoDB/Volo/Abp/Identity/MongoDB/MongoOrganizationUnitRepository.cs

@@ -189,11 +189,12 @@ public class MongoOrganizationUnitRepository
         int maxResultCount = int.MaxValue,
         int skipCount = 0,
         string filter = null,
+        bool includeChildren = false,
         bool includeDetails = false,
         CancellationToken cancellationToken = default)
     {
         cancellationToken = GetCancellationToken(cancellationToken);
-        var query = await CreateGetMembersFilteredQueryAsync(organizationUnit, filter, cancellationToken);
+        var query = await CreateGetMembersFilteredQueryAsync(organizationUnit, filter, includeChildren, cancellationToken);
         return await query
             .OrderBy(sorting.IsNullOrEmpty() ? nameof(IdentityUser.UserName) : sorting)
             .As<IMongoQueryable<IdentityUser>>()
@@ -201,21 +202,22 @@ public class MongoOrganizationUnitRepository
             .ToListAsync(cancellationToken);
     }
 
-    public virtual async Task<List<Guid>> GetMemberIdsAsync(Guid id, CancellationToken cancellationToken = default)
+    public virtual async Task<List<Guid>> GetMemberIdsAsync(Guid id, bool includeChildren = false, CancellationToken cancellationToken = default)
     {
         cancellationToken = GetCancellationToken(cancellationToken);
-        return await (await GetMongoQueryableAsync<IdentityUser>(cancellationToken))
-            .Where(u => u.OrganizationUnits.Any(uou => uou.OrganizationUnitId == id)).Select(x => x.Id)
-            .ToListAsync(cancellationToken);
+        var organizationUnit = await GetAsync(id, cancellationToken: cancellationToken);
+        var query = await CreateGetMembersFilteredQueryAsync(organizationUnit, null, includeChildren, cancellationToken);
+        return await query.Select(x => x.Id).ToListAsync(cancellationToken);
     }
 
     public virtual async Task<int> GetMembersCountAsync(
         OrganizationUnit organizationUnit,
         string filter = null,
+        bool includeChildren = false,
         CancellationToken cancellationToken = default)
     {
         cancellationToken = GetCancellationToken(cancellationToken);
-        var query = await CreateGetMembersFilteredQueryAsync(organizationUnit, filter, cancellationToken);
+        var query = await CreateGetMembersFilteredQueryAsync(organizationUnit, filter, includeChildren, cancellationToken);
         return await query.CountAsync(cancellationToken);
     }
 
@@ -286,8 +288,27 @@ public class MongoOrganizationUnitRepository
     protected virtual async Task<IMongoQueryable<IdentityUser>> CreateGetMembersFilteredQueryAsync(
         OrganizationUnit organizationUnit,
         string filter = null,
+        bool includeChildren = false,
         CancellationToken cancellationToken = default)
     {
+        if (includeChildren)
+        {
+            var childrenIds = await (await GetMongoQueryableAsync(cancellationToken))
+                .Where(ou => ou.Code.StartsWith(organizationUnit.Code))
+                .Select(ou => ou.Id)
+                .ToListAsync(GetCancellationToken(cancellationToken));
+
+            return (await GetMongoQueryableAsync<IdentityUser>(cancellationToken))
+                .Where(u => u.OrganizationUnits.Any(uou => childrenIds.Contains(uou.OrganizationUnitId)))
+                .WhereIf<IdentityUser, IMongoQueryable<IdentityUser>>(
+                    !filter.IsNullOrWhiteSpace(),
+                    u =>
+                        u.UserName.Contains(filter) ||
+                        u.Email.Contains(filter) ||
+                        (u.PhoneNumber != null && u.PhoneNumber.Contains(filter))
+                );
+        }
+
         return (await GetMongoQueryableAsync<IdentityUser>(cancellationToken))
             .Where(u => u.OrganizationUnits.Any(uou => uou.OrganizationUnitId == organizationUnit.Id))
             .WhereIf<IdentityUser, IMongoQueryable<IdentityUser>>(

modules/identity/test/Volo.Abp.Identity.TestBase/Volo/Abp/Identity/OrganizationUnitRepository_Tests.cs

@@ -267,6 +267,10 @@ public abstract class OrganizationUnitRepository_Tests<TStartupModule> : AbpIden
         var usersCount = await _organizationUnitRepository.GetMembersCountAsync(ou);
 
         usersCount.ShouldBeGreaterThan(1);
+
+        usersCount = await _organizationUnitRepository.GetMembersCountAsync(ou, includeChildren: true);
+
+        usersCount.ShouldBeGreaterThanOrEqualTo(2);
     }
 
     [Fact]
@@ -301,6 +305,9 @@ public abstract class OrganizationUnitRepository_Tests<TStartupModule> : AbpIden
         await _organizationUnitRepository.RemoveAllMembersAsync(ou);
         var newCount = await _organizationUnitRepository.GetMembersCountAsync(ou);
         newCount.ShouldBe(0);
+
+        newCount = await _organizationUnitRepository.GetMembersCountAsync(ou, includeChildren: true);
+        newCount.ShouldBe(0);
     }
 
     [Fact]