Browse Source

Add mime type: application/x-www-form-urlencoded and use constants.

pull/714/head
Halil ibrahim Kalkan 8 years ago
parent
commit
09b4a5b0da
  1. 4
      framework/src/Volo.Abp.Http.Client/Volo/Abp/Http/Client/DynamicProxying/DynamicHttpProxyInterceptor.cs
  2. 4
      framework/src/Volo.Abp.Http.Client/Volo/Abp/Http/Client/DynamicProxying/RequestPayloadBuilder.cs
  3. 1
      framework/src/Volo.Abp.Http/Volo/Abp/Http/MimeTypes.cs
  4. 7
      framework/test/Volo.Abp.AspNetCore.Mvc.Tests/Volo/Abp/AspNetCore/Mvc/PersonAppService_Tests.cs

4
framework/src/Volo.Abp.Http.Client/Volo/Abp/Http/Client/DynamicProxying/DynamicHttpProxyInterceptor.cs

@ -174,8 +174,8 @@ namespace Volo.Abp.Http.Client.DynamicProxying
if (!apiVersion.Version.IsNullOrEmpty())
{
//TODO: What about other media types?
requestMessage.Headers.Add("accept", $"text/plain; v={apiVersion.Version}");
requestMessage.Headers.Add("accept", $"application/json; v={apiVersion.Version}");
requestMessage.Headers.Add("accept", $"{MimeTypes.Text.Plain}; v={apiVersion.Version}");
requestMessage.Headers.Add("accept", $"{MimeTypes.Application.Json}; v={apiVersion.Version}");
requestMessage.Headers.Add("api-version", apiVersion.Version);
}

4
framework/src/Volo.Abp.Http.Client/Volo/Abp/Http/Client/DynamicProxying/RequestPayloadBuilder.cs

@ -17,13 +17,13 @@ namespace Volo.Abp.Http.Client.DynamicProxying
var body = GenerateBody(action, methodArguments, jsonSerializer);
if (body != null)
{
return new StringContent(body, Encoding.UTF8, "application/json"); //TODO: application/json to a constant
return new StringContent(body, Encoding.UTF8, MimeTypes.Application.Json);
}
body = GenerateFormPostData(action, methodArguments);
if (body != null)
{
return new StringContent(body, Encoding.UTF8, "application/x-www-form-urlencoded"); //TODO: application/x-www-form-urlencoded to a constant
return new StringContent(body, Encoding.UTF8, MimeTypes.Application.XWwwFormUrlencoded);
}
return null;

1
framework/src/Volo.Abp.Http/Volo/Abp/Http/MimeTypes.cs

@ -32,6 +32,7 @@ namespace Volo.Abp.Http
public const string XPkcs12 = "application/x-pkcs12";
public const string XShockwaveFlash = "application/x-shockwave-flash";
public const string XSilverlightApp = "application/x-silverlight-app";
public const string XWwwFormUrlencoded = "application/x-www-form-urlencoded";
public const string XhtmlXml = "application/xhtml+xml";
public const string Xml = "application/xml";
public const string XmlDtd = "application/xml-dtd";

7
framework/test/Volo.Abp.AspNetCore.Mvc.Tests/Volo/Abp/AspNetCore/Mvc/PersonAppService_Tests.cs

@ -10,6 +10,7 @@ using System.Linq;
using System.Net;
using System.Net.Http;
using System.Text;
using Volo.Abp.Http;
using Volo.Abp.ObjectMapping;
using Volo.Abp.Json;
using Volo.Abp.TestApp.Application.Dto;
@ -66,7 +67,7 @@ namespace Volo.Abp.AspNetCore.Mvc
var response = await Client.PostAsync(
"/api/app/people",
new StringContent(postData, Encoding.UTF8, "application/json")
new StringContent(postData, Encoding.UTF8, MimeTypes.Application.Json)
);
response.StatusCode.ShouldBe(HttpStatusCode.OK);
@ -98,7 +99,7 @@ namespace Volo.Abp.AspNetCore.Mvc
var response = await Client.PutAsync(
$"/api/app/people/{updateDto.Id}",
new StringContent(putData, Encoding.UTF8, "application/json")
new StringContent(putData, Encoding.UTF8, MimeTypes.Application.Json)
);
response.StatusCode.ShouldBe(HttpStatusCode.OK);
@ -131,7 +132,7 @@ namespace Volo.Abp.AspNetCore.Mvc
var response = await Client.PostAsync(
$"/api/app/people/{personToAddNewPhone.Id}/phones",
new StringContent(postData, Encoding.UTF8, "application/json")
new StringContent(postData, Encoding.UTF8, MimeTypes.Application.Json)
);
response.StatusCode.ShouldBe(HttpStatusCode.OK);

Loading…
Cancel
Save