Browse Source

Simplify telemetry activity processing logic.

Removed unnecessary usage of `IActivityDataProvider` in `TelemetryService` and `TelemetryDataSender`. Optimized activity handling by directly working with provided data, reducing complexity and improving maintainability.
pull/23059/head
Emre KARA 1 year ago
parent
commit
0a9debf61d
  1. 3
      framework/src/Volo.Abp.Core/Volo/Abp/Telemetry/TelemetryDataSender.cs
  2. 8
      framework/src/Volo.Abp.Core/Volo/Abp/Telemetry/TelemetryService.cs

3
framework/src/Volo.Abp.Core/Volo/Abp/Telemetry/TelemetryDataSender.cs

@ -38,12 +38,11 @@ public class TelemetryDataSender : ITelemetryDataSender , IScopedDependency
if (activities.Count > 0)
{
await _activityDataProvider.AddExtraInformationAsync(activities[0]);
foreach (var activity in activities)
{
await _activityDataProvider.AddExtraInformationAsync(activity);
await httpClient.PostAsync(ApiUrl,
new StringContent(JsonSerializer.Serialize(activity), Encoding.UTF8, "application/json"));
}
await _activityStorage.MarkActivitiesAsSentAsync();

8
framework/src/Volo.Abp.Core/Volo/Abp/Telemetry/TelemetryService.cs

@ -10,13 +10,11 @@ namespace Volo.Abp.Telemetry;
public class TelemetryService : ITelemetryService , IScopedDependency
{
private readonly IActivityStorage _activityStorage;
private readonly IActivityDataProvider _activityDataProvider;
private readonly ITelemetryDataSender _telemetryDataSender;
public TelemetryService(IActivityStorage activityStorage, IActivityDataProvider activityDataProvider, ITelemetryDataSender telemetryDataSender)
public TelemetryService(IActivityStorage activityStorage, ITelemetryDataSender telemetryDataSender)
{
_activityStorage = activityStorage;
_activityDataProvider = activityDataProvider;
_telemetryDataSender = telemetryDataSender;
}
@ -67,8 +65,8 @@ public class TelemetryService : ITelemetryService , IScopedDependency
}
public async Task AddActivityAsync(ActivityData data, CancellationToken cancellationToken = default)
{
var build = await _activityDataProvider.AddExtraInformationAsync(data, cancellationToken);
await _activityStorage.BufferActivityAsync(build, cancellationToken);
await _activityStorage.BufferActivityAsync(data, cancellationToken);
await CheckIfActivitySendTimeIsDueAsync();
}

Loading…
Cancel
Save