Browse Source

Merge pull request #11072 from abpframework/SettingProvider-Patch

Break after the values are got from the provider.
pull/11073/head
liangshiwei 4 years ago
committed by GitHub
parent
commit
0ef5edd720
No known key found for this signature in database GPG Key ID: 4AEE18F83AFDEB23
  1. 4
      framework/src/Volo.Abp.Settings/Volo/Abp/Settings/SettingProvider.cs
  2. 9
      modules/setting-management/test/Volo.Abp.SettingManagement.Tests/Volo/Abp/SettingManagement/SettingManager_Basic_Tests.cs

4
framework/src/Volo.Abp.Settings/Volo/Abp/Settings/SettingProvider.cs

@ -73,6 +73,10 @@ namespace Volo.Abp.Settings
}
settingDefinitions.RemoveAll(x => notNullValues.Any(v => v.Name == x.Name));
if (!settingDefinitions.Any())
{
break;
}
}
return result.Values.ToList();

9
modules/setting-management/test/Volo.Abp.SettingManagement.Tests/Volo/Abp/SettingManagement/SettingManager_Basic_Tests.cs

@ -46,6 +46,15 @@ namespace Volo.Abp.SettingManagement
settingValues.ShouldContain(sv => sv.Name == "SettingNotSetInStore" && sv.Value == "default-value");
}
[Fact]
public async Task Should_Get_All_By_Names_Base_Store_Values()
{
var settingValues = await _settingProvider.GetAllAsync(new []{ "MySetting1", "MySetting2" });
settingValues.Count.ShouldBe(2);
settingValues.ShouldContain(sv => sv.Name == "MySetting1" && sv.Value == "42");
settingValues.ShouldContain(sv => sv.Name == "MySetting2" && sv.Value == "default-store-value");
}
[Fact]
public async Task Should_Set_Global_Value()
{

Loading…
Cancel
Save