Browse Source

Merge pull request #5274 from abpframework/fix/volo-3173

Fixed the RTL margin problem in permissions modal
pull/5285/head
Mehmet Erim 6 years ago
committed by GitHub
parent
commit
1184c1d325
No known key found for this signature in database GPG Key ID: 4AEE18F83AFDEB23
  1. 2
      npm/ng-packs/packages/permission-management/src/lib/components/permission-management.component.html
  2. 17
      npm/ng-packs/packages/permission-management/src/lib/components/permission-management.component.ts
  3. 2
      npm/ng-packs/packages/theme-basic/src/lib/constants/styles.ts

2
npm/ng-packs/packages/permission-management/src/lib/components/permission-management.component.html

@ -63,7 +63,7 @@
let i = index; let i = index;
trackBy: trackByFn trackBy: trackByFn
" "
[style.margin-left]="permission.margin + 'px'" [ngStyle]="permission.style"
class="custom-checkbox custom-control mb-2" class="custom-checkbox custom-control mb-2"
> >
<input <input

17
npm/ng-packs/packages/permission-management/src/lib/components/permission-management.component.ts

@ -1,4 +1,5 @@
import { ApplicationConfiguration, ConfigState, GetAppConfiguration } from '@abp/ng.core'; import { ApplicationConfiguration, ConfigState, GetAppConfiguration } from '@abp/ng.core';
import { LocaleDirection } from '@abp/ng.theme.shared';
import { Component, EventEmitter, Input, Output, Renderer2, TrackByFunction } from '@angular/core'; import { Component, EventEmitter, Input, Output, Renderer2, TrackByFunction } from '@angular/core';
import { Select, Store } from '@ngxs/store'; import { Select, Store } from '@ngxs/store';
import { Observable, of } from 'rxjs'; import { Observable, of } from 'rxjs';
@ -7,8 +8,8 @@ import { GetPermissions, UpdatePermissions } from '../actions/permission-managem
import { PermissionManagement } from '../models/permission-management'; import { PermissionManagement } from '../models/permission-management';
import { PermissionManagementState } from '../states/permission-management.state'; import { PermissionManagementState } from '../states/permission-management.state';
type PermissionWithMargin = PermissionManagement.Permission & { type PermissionWithStyle = PermissionManagement.Permission & {
margin: number; style: string;
}; };
@Component({ @Component({
@ -79,21 +80,25 @@ export class PermissionManagementComponent
trackByFn: TrackByFunction<PermissionManagement.Group> = (_, item) => item.name; trackByFn: TrackByFunction<PermissionManagement.Group> = (_, item) => item.name;
get selectedGroupPermissions$(): Observable<PermissionWithMargin[]> { get selectedGroupPermissions$(): Observable<PermissionWithStyle[]> {
const margin = `margin-${
(document.body.dir as LocaleDirection) === 'rtl' ? 'right' : 'left'
}.px`;
return this.groups$.pipe( return this.groups$.pipe(
map(groups => map(groups =>
this.selectedGroup this.selectedGroup
? groups.find(group => group.name === this.selectedGroup.name).permissions ? groups.find(group => group.name === this.selectedGroup.name).permissions
: [], : [],
), ),
map<PermissionManagement.Permission[], PermissionWithMargin[]>(permissions => map<PermissionManagement.Permission[], PermissionWithStyle[]>(permissions =>
permissions.map( permissions.map(
permission => permission =>
(({ (({
...permission, ...permission,
margin: findMargin(permissions, permission), style: { [margin]: findMargin(permissions, permission) },
isGranted: this.permissions.find(per => per.name === permission.name).isGranted, isGranted: this.permissions.find(per => per.name === permission.name).isGranted,
} as any) as PermissionWithMargin), } as any) as PermissionWithStyle),
), ),
), ),
); );

2
npm/ng-packs/packages/theme-basic/src/lib/constants/styles.ts

@ -72,7 +72,7 @@ export default `
border: 1px solid #c8c8c8; border: 1px solid #c8c8c8;
} }
.abp-loading { .abp-loading {
background: rgba(0, 0, 0, 0.1); background: rgba(0, 0, 0, 0.05);
} }
.modal-backdrop { .modal-backdrop {
background-color: rgba(0, 0, 0, 0.6); background-color: rgba(0, 0, 0, 0.6);

Loading…
Cancel
Save