From 72ea5b7953556e9cc89b0e388e6072ae1e0a71d2 Mon Sep 17 00:00:00 2001 From: maliming Date: Thu, 17 Feb 2022 13:49:13 +0800 Subject: [PATCH] Output error log when RedirectUrl is invalid. --- .../Volo/Abp/Ui/Navigation/Urls/AppUrlProvider.cs | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/framework/src/Volo.Abp.UI.Navigation/Volo/Abp/Ui/Navigation/Urls/AppUrlProvider.cs b/framework/src/Volo.Abp.UI.Navigation/Volo/Abp/Ui/Navigation/Urls/AppUrlProvider.cs index dc9a6102f8..8992ef062a 100644 --- a/framework/src/Volo.Abp.UI.Navigation/Volo/Abp/Ui/Navigation/Urls/AppUrlProvider.cs +++ b/framework/src/Volo.Abp.UI.Navigation/Volo/Abp/Ui/Navigation/Urls/AppUrlProvider.cs @@ -3,6 +3,8 @@ using System.Collections.Generic; using System.Linq; using System.Threading.Tasks; using JetBrains.Annotations; +using Microsoft.Extensions.Logging; +using Microsoft.Extensions.Logging.Abstractions; using Microsoft.Extensions.Options; using Volo.Abp.DependencyInjection; using Volo.Abp.MultiTenancy; @@ -18,6 +20,8 @@ public class AppUrlProvider : IAppUrlProvider, ITransientDependency protected ICurrentTenant CurrentTenant { get; } protected ITenantStore TenantStore { get; } + public ILogger Logger { get; set; } + public AppUrlProvider( IOptions options, ICurrentTenant currentTenant, @@ -26,6 +30,7 @@ public class AppUrlProvider : IAppUrlProvider, ITransientDependency CurrentTenant = currentTenant; TenantStore = tenantStore; Options = options.Value; + Logger = NullLogger.Instance; } public virtual async Task GetUrlAsync(string appName, string urlName = null) @@ -40,7 +45,12 @@ public class AppUrlProvider : IAppUrlProvider, ITransientDependency public bool IsRedirectAllowedUrl(string url) { - return Options.RedirectAllowedUrls.Any(url.StartsWith); + var allow = Options.RedirectAllowedUrls.Any(url.StartsWith); + if (!allow) + { + Logger.LogError($"Invalid RedirectUrl: {url}, Use {nameof(AppUrlProvider)} to configure it!"); + } + return allow; } protected virtual async Task GetConfiguredUrl(string appName, string urlName)