Browse Source
fix(permission-management): validate user ID parsing in role permission providers
pull/24374/head
maliming
3 months ago
No known key found for this signature in database
GPG Key ID: A646B9CB645ECEA4
2 changed files with
2 additions and
4 deletions
-
modules/identity/src/Volo.Abp.PermissionManagement.Domain.Identity/Volo/Abp/PermissionManagement/Identity/RolePermissionManagementProvider.cs
-
modules/identity/src/Volo.Abp.PermissionManagement.Domain.Identity/Volo/Abp/PermissionManagement/Identity/RoleResourcePermissionManagementProvider.cs
|
|
|
@ -49,9 +49,8 @@ public class RolePermissionManagementProvider : PermissionManagementProvider |
|
|
|
|
|
|
|
} |
|
|
|
|
|
|
|
if (providerName == UserPermissionValueProvider.ProviderName) |
|
|
|
if (providerName == UserPermissionValueProvider.ProviderName && Guid.TryParse(providerKey, out var userId)) |
|
|
|
{ |
|
|
|
var userId = Guid.Parse(providerKey); |
|
|
|
var roleNames = await UserRoleFinder.GetRoleNamesAsync(userId); |
|
|
|
|
|
|
|
foreach (var roleName in roleNames) |
|
|
|
|
|
|
|
@ -48,9 +48,8 @@ public class RoleResourcePermissionManagementProvider : ResourcePermissionManage |
|
|
|
resourcePermissionGrants.AddRange(await ResourcePermissionGrantRepository.GetListAsync(names, resourceName, resourceKey, providerName, providerKey)); |
|
|
|
} |
|
|
|
|
|
|
|
if (providerName == UserResourcePermissionValueProvider.ProviderName) |
|
|
|
if (providerName == UserResourcePermissionValueProvider.ProviderName && Guid.TryParse(providerKey, out var userId)) |
|
|
|
{ |
|
|
|
var userId = Guid.Parse(providerKey); |
|
|
|
var roleNames = await UserRoleFinder.GetRoleNamesAsync(userId); |
|
|
|
|
|
|
|
foreach (var roleName in roleNames) |
|
|
|
|
