Browse Source

Merge pull request #16012 from abpframework/auto-merge/rel-7-1/1811

Merge branch dev with rel-7.1
pull/16013/head
maliming 4 years ago
committed by GitHub
parent
commit
146a750392
No known key found for this signature in database GPG Key ID: 4AEE18F83AFDEB23
  1. 3
      framework/src/Volo.Abp.AspNetCore.Mvc.UI.Theme.Shared/wwwroot/libs/abp/aspnetcore-mvc-ui-theme-shared/bootstrap/dom-event-handlers.js
  2. 2
      npm/ng-packs/packages/theme-shared/src/lib/components/modal/modal.component.ts
  3. 3
      npm/ng-packs/packages/theme-shared/src/lib/tests/modal.component.spec.ts

3
framework/src/Volo.Abp.AspNetCore.Mvc.UI.Theme.Shared/wwwroot/libs/abp/aspnetcore-mvc-ui-theme-shared/bootstrap/dom-event-handlers.js

@ -93,6 +93,9 @@
} }
let name = $(this).attr("name"); let name = $(this).attr("name");
let selectedTextInputName = name + "_Text"; let selectedTextInputName = name + "_Text";
if(name.indexOf(".ExtraProperties[") > 0) {
selectedTextInputName = name.substring(0, name.length - 1) + "_Text]"
}
let selectedTextInput = $('<input>', { let selectedTextInput = $('<input>', {
type: 'hidden', type: 'hidden',
id: selectedTextInputName, id: selectedTextInputName,

2
npm/ng-packs/packages/theme-shared/src/lib/components/modal/modal.component.ts

@ -196,7 +196,7 @@ export class ModalComponent implements OnInit, OnDestroy, DismissableModal {
.pipe( .pipe(
takeUntil(this.destroy$), takeUntil(this.destroy$),
debounceTime(150), debounceTime(150),
filter((key: KeyboardEvent) => key && key.key === 'Escape'), filter((key: KeyboardEvent) => key && key.key === 'Escape' && this.options.keyboard),
) )
.subscribe(() => this.close()); .subscribe(() => this.close());
} }

3
npm/ng-packs/packages/theme-shared/src/lib/tests/modal.component.spec.ts

@ -158,8 +158,9 @@ describe('ModalComponent', () => {
spectator.dispatchKeyboardEvent(spectator.component.modalWindowRef, 'keyup', 'Escape'); spectator.dispatchKeyboardEvent(spectator.component.modalWindowRef, 'keyup', 'Escape');
await wait300ms(); await wait300ms();
const { keyboard } = spectator.component.options;
expect(spectator.component.visible).toBe(false); expect(spectator.component.visible).toBe(!keyboard);
}); });
it('should not close when busy is true', async () => { it('should not close when busy is true', async () => {

Loading…
Cancel
Save