From 1512af765c13ef2ce529b55b2a7c6be9193eb146 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Halil=20=C4=B0brahim=20Kalkan?= <hi_kalkan@yahoo.com>
Date: Fri, 12 Jan 2018 18:23:06 +0300
Subject: [PATCH] Added TODOs.

---
 .../ICommonDbContextRegistrationOptionsBuilder.cs         | 2 +-
 .../Volo/Abp/Domain/Repositories/IRepository.cs           | 8 ++++----
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/Volo.Abp.Ddd/Volo/Abp/DependencyInjection/ICommonDbContextRegistrationOptionsBuilder.cs b/src/Volo.Abp.Ddd/Volo/Abp/DependencyInjection/ICommonDbContextRegistrationOptionsBuilder.cs
index 167fbcad47..f15509dfbe 100644
--- a/src/Volo.Abp.Ddd/Volo/Abp/DependencyInjection/ICommonDbContextRegistrationOptionsBuilder.cs
+++ b/src/Volo.Abp.Ddd/Volo/Abp/DependencyInjection/ICommonDbContextRegistrationOptionsBuilder.cs
@@ -41,7 +41,7 @@ namespace Volo.Abp.DependencyInjection
         /// </summary>
         /// <typeparam name="TEntity">Entity type</typeparam>
         /// <typeparam name="TRepository">Repository type</typeparam>
-        ICommonDbContextRegistrationOptionsBuilder AddCustomRepository<TEntity, TRepository>();
+        ICommonDbContextRegistrationOptionsBuilder AddCustomRepository<TEntity, TRepository>(); //TODO: Rename to AddRepository!
 
         /// <summary>
         /// Uses given class(es) for default repositories.
diff --git a/src/Volo.Abp.Ddd/Volo/Abp/Domain/Repositories/IRepository.cs b/src/Volo.Abp.Ddd/Volo/Abp/Domain/Repositories/IRepository.cs
index fd4f41b03f..2af29b9cbc 100644
--- a/src/Volo.Abp.Ddd/Volo/Abp/Domain/Repositories/IRepository.cs
+++ b/src/Volo.Abp.Ddd/Volo/Abp/Domain/Repositories/IRepository.cs
@@ -112,27 +112,27 @@ namespace Volo.Abp.Domain.Repositories
         /// Deletes an entity.
         /// </summary>
         /// <param name="entity">Entity to be deleted</param>
-        void Delete([NotNull] TEntity entity);
+        void Delete([NotNull] TEntity entity); //TODO: Return true if deleted
 
         /// <summary>
         /// Deletes an entity.
         /// </summary>
         /// <param name="cancellationToken">A <see cref="T:System.Threading.CancellationToken" /> to observe while waiting for the task to complete.</param>
         /// <param name="entity">Entity to be deleted</param>
-        Task DeleteAsync([NotNull] TEntity entity, CancellationToken cancellationToken = default);
+        Task DeleteAsync([NotNull] TEntity entity, CancellationToken cancellationToken = default); //TODO: Return true if deleted
 
         /// <summary>
         /// Deletes an entity by primary key.
         /// </summary>
         /// <param name="id">Primary key of the entity</param>
-        void Delete(TPrimaryKey id);
+        void Delete(TPrimaryKey id); //TODO: Return true if deleted
 
         /// <summary>
         /// Deletes an entity by primary key.
         /// </summary>
         /// <param name="cancellationToken">A <see cref="T:System.Threading.CancellationToken" /> to observe while waiting for the task to complete.</param>
         /// <param name="id">Primary key of the entity</param>
-        Task DeleteAsync(TPrimaryKey id, CancellationToken cancellationToken = default);
+        Task DeleteAsync(TPrimaryKey id, CancellationToken cancellationToken = default);  //TODO: Return true if deleted
 
         /// <summary>
         /// Get list of all entities without any filtering.