early pattern applied

4 years ago · 178158c0a2
1 changed files with 5 additions and 1 deletions
--- a/npm/ng-packs/packages/core/src/lib/services/routes.service.ts
+++ b/npm/ng-packs/packages/core/src/lib/services/routes.service.ts
@ -61,7 +61,11 @@ export abstract class AbstractTreeService<T extends { [key: string | number | sy

  protected createGroupedTree(list: TreeNode<T>[]): RouteGroup<T>[] | undefined {
    const map = createGroupMap<T>(list, this.othersGroup);
-    return Boolean(map) ? Array.from(map, ([key, items]) => ({ group: key, items })) : undefined;
+    if (!map) {
+      return undefined;
+    }
+
+    return Array.from(map, ([key, items]) => ({ group: key, items }));
  }

  private filterWith(setOrMap: Set<string> | Map<string, T>): T[] {