From 218e3c1b3ec1ff0042a14c90f41f3604e68890c5 Mon Sep 17 00:00:00 2001 From: bnymncoskuner Date: Tue, 30 Mar 2021 18:35:12 +0300 Subject: [PATCH] refactor: clear sub first on destroy for page-part --- .../packages/components/page/src/page-part.directive.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/npm/ng-packs/packages/components/page/src/page-part.directive.ts b/npm/ng-packs/packages/components/page/src/page-part.directive.ts index 3e59b7aee2..c228189e0f 100644 --- a/npm/ng-packs/packages/components/page/src/page-part.directive.ts +++ b/npm/ng-packs/packages/components/page/src/page-part.directive.ts @@ -66,11 +66,11 @@ export class PagePartDirective implements OnInit, OnDestroy, OnChanges { } ngOnDestroy() { + this.clearSubscription(); + if (this.renderLogic?.onDestroy) { this.renderLogic.onDestroy(this.type, this.injector, this.context); } - - this.clearSubscription(); } shouldRender(type: string) {