From 2809ec8d4e17fdc05e67254346d0dea7fbd08677 Mon Sep 17 00:00:00 2001
From: mehmet-erim <bilgi@mehmeterim.com>
Date: Thu, 1 Aug 2019 10:37:06 +0300
Subject: [PATCH] fix(theme-shared): improve code quality of error.handler

---
 .../src/lib/handlers/error.handler.ts         | 29 ++++++++-----------
 1 file changed, 12 insertions(+), 17 deletions(-)

diff --git a/npm/ng-packs/packages/theme-shared/src/lib/handlers/error.handler.ts b/npm/ng-packs/packages/theme-shared/src/lib/handlers/error.handler.ts
index 07328a1356..3291c1b1af 100644
--- a/npm/ng-packs/packages/theme-shared/src/lib/handlers/error.handler.ts
+++ b/npm/ng-packs/packages/theme-shared/src/lib/handlers/error.handler.ts
@@ -68,17 +68,26 @@ export class ErrorHandler {
             );
             break;
           case 403:
-            this.show403();
+            this.createErrorComponent({
+              title: DEFAULTS.defaultError403.message,
+              details: DEFAULTS.defaultError403.details,
+            });
             break;
           case 404:
             this.showError(DEFAULTS.defaultError404.details, DEFAULTS.defaultError404.message);
             break;
           case 500:
-            this.show500();
+            this.createErrorComponent({
+              title: '500',
+              details: 'Sorry, an error has occured.',
+            });
             break;
           case 0:
             if ((err as HttpErrorResponse).statusText === 'Unknown Error') {
-              this.show500();
+              this.createErrorComponent({
+                title: 'Unknown Error',
+                details: 'Sorry, an error has occured.',
+              });
             }
             break;
           default:
@@ -113,20 +122,6 @@ export class ErrorHandler {
     );
   }
 
-  private show500() {
-    this.createErrorComponent({
-      title: '500',
-      details: 'Sorry, an error has occured.',
-    });
-  }
-
-  private show403() {
-    this.createErrorComponent({
-      title: DEFAULTS.defaultError403.message,
-      details: DEFAULTS.defaultError403.details,
-    });
-  }
-
   createErrorComponent(instance: Partial<ErrorComponent>) {
     const renderer = this.rendererFactory.createRenderer(null, null);
     const host = renderer.selectRootElement('app-root', true);