From 2c05ca21663afdf4901c38cdf969e2fd861c1fc4 Mon Sep 17 00:00:00 2001 From: Sinan997 Date: Fri, 21 Jul 2023 13:32:47 +0300 Subject: [PATCH] fixed test file --- .../lib/tests/internet-connection.service.spec.ts | 13 ++++++------- .../internet-connection-status.component.ts | 4 ++-- 2 files changed, 8 insertions(+), 9 deletions(-) diff --git a/npm/ng-packs/packages/core/src/lib/tests/internet-connection.service.spec.ts b/npm/ng-packs/packages/core/src/lib/tests/internet-connection.service.spec.ts index 397f362781..9181f430d4 100644 --- a/npm/ng-packs/packages/core/src/lib/tests/internet-connection.service.spec.ts +++ b/npm/ng-packs/packages/core/src/lib/tests/internet-connection.service.spec.ts @@ -4,7 +4,8 @@ import { InternetConnectionService } from '../services/internet-connection-servi describe('InternetConnectionService', () => { let service: InternetConnectionService; - + const internetConnectionStatus = window.navigator.onLine + beforeEach(() => { TestBed.configureTestingModule({}); service = TestBed.inject(InternetConnectionService); @@ -14,15 +15,13 @@ describe('InternetConnectionService', () => { expect(service).toBeTruthy(); }); - it('#networkStatus should return real value (true | false)', () => { - expect(typeof service.networkStatus()).toEqual('boolean') - expect(typeof !service.networkStatus()).toEqual('boolean') + it('networkStatus value should be same with current internetConnectionStatus', () => { + expect(service.networkStatus()).toEqual(internetConnectionStatus) }); - it('#networkStatus$ should return real value (true | false)', () => { + it('networkStatus$ return value should be with the current internetConnectionStatus', () => { service.networkStatus$.subscribe(val=>{ - expect(typeof val).toEqual('boolean') - expect(typeof !val).toEqual('boolean') + expect(val).toEqual(internetConnectionStatus) }) }); }); diff --git a/npm/ng-packs/packages/theme-shared/src/lib/components/internet-connection-status/internet-connection-status.component.ts b/npm/ng-packs/packages/theme-shared/src/lib/components/internet-connection-status/internet-connection-status.component.ts index 4ad473141a..5592e748a3 100644 --- a/npm/ng-packs/packages/theme-shared/src/lib/components/internet-connection-status/internet-connection-status.component.ts +++ b/npm/ng-packs/packages/theme-shared/src/lib/components/internet-connection-status/internet-connection-status.component.ts @@ -1,4 +1,4 @@ -import { Component, inject } from '@angular/core'; +import { Component, computed, inject } from '@angular/core'; import { NgIf } from '@angular/common' import { InternetConnectionService , LocalizationModule } from '@abp/ng.core'; @@ -43,5 +43,5 @@ import { InternetConnectionService , LocalizationModule } from '@abp/ng.core'; }) export class InternetConnectionStatusComponent{ internetConnectionService = inject(InternetConnectionService); - isOnline = this.internetConnectionService.networkStatus + isOnline = computed(() => this.internetConnectionService.networkStatus()) }