From 3afb6bc995ae9a56622483b83e343dee9c3212bd Mon Sep 17 00:00:00 2001 From: yagmurcelk <157795849+yagmurcelk@users.noreply.github.com> Date: Wed, 11 Nov 2026 11:49:09 +0000 Subject: [PATCH 1/2] Fix stale default language after Set as default Publish LanguageChangedEto when Abp.Localization.DefaultLanguage changes so DefaultAbpRequestLocalizationOptionsProvider clears its cached default without a restart or language entity edit. Covers Language Management Set as default and any other writer of that setting. Co-authored-by: Cursor --- docs/en/modules/language-management.md | 2 +- .../Volo.Abp.SettingManagement.Domain.csproj | 1 + .../AbpSettingManagementDomainModule.cs | 2 + .../DefaultLanguageSettingChangedHandler.cs | 30 ++++++++ ...aultLanguageSettingChangedHandler_Tests.cs | 73 +++++++++++++++++++ 5 files changed, 107 insertions(+), 1 deletion(-) create mode 100644 modules/setting-management/src/Volo.Abp.SettingManagement.Domain/Volo/Abp/SettingManagement/DefaultLanguageSettingChangedHandler.cs create mode 100644 modules/setting-management/test/Volo.Abp.SettingManagement.Tests/Volo/Abp/SettingManagement/DefaultLanguageSettingChangedHandler_Tests.cs diff --git a/docs/en/modules/language-management.md b/docs/en/modules/language-management.md index 22d249290d..480fcb49fb 100644 --- a/docs/en/modules/language-management.md +++ b/docs/en/modules/language-management.md @@ -336,6 +336,6 @@ public class MyHandler : -The module already configures the `Language` to `LanguageEto` and `LanguageText` to `LanguageTextEto` mappings. Language entity changes also publish `LanguageChangedEto`, which consumers can use to refresh their language list. See the [Distributed Event Bus](../framework/infrastructure/event-bus/distributed) document for details of the pre-defined entity events. +The module already configures the `Language` to `LanguageEto` and `LanguageText` to `LanguageTextEto` mappings. Language entity changes also publish `LanguageChangedEto`, which consumers can use to refresh their language list. Changing the `Abp.Localization.DefaultLanguage` setting (including **Set as default language**) likewise publishes `LanguageChangedEto`, so request localization options pick up the new default without an application restart. See the [Distributed Event Bus](../framework/infrastructure/event-bus/distributed) document for details of the pre-defined entity events. > Subscribing to distributed events is especially useful for distributed scenarios (like microservice architecture). If you are building a monolithic application or listening for events in the same process that runs the Language Management Module, subscribing to the [Local Event Bus](../framework/infrastructure/event-bus/local) can be simpler. diff --git a/modules/setting-management/src/Volo.Abp.SettingManagement.Domain/Volo.Abp.SettingManagement.Domain.csproj b/modules/setting-management/src/Volo.Abp.SettingManagement.Domain/Volo.Abp.SettingManagement.Domain.csproj index 9c781497c2..0d2debd16d 100644 --- a/modules/setting-management/src/Volo.Abp.SettingManagement.Domain/Volo.Abp.SettingManagement.Domain.csproj +++ b/modules/setting-management/src/Volo.Abp.SettingManagement.Domain/Volo.Abp.SettingManagement.Domain.csproj @@ -18,6 +18,7 @@ + diff --git a/modules/setting-management/src/Volo.Abp.SettingManagement.Domain/Volo/Abp/SettingManagement/AbpSettingManagementDomainModule.cs b/modules/setting-management/src/Volo.Abp.SettingManagement.Domain/Volo/Abp/SettingManagement/AbpSettingManagementDomainModule.cs index 5f447d318f..c76db98755 100644 --- a/modules/setting-management/src/Volo.Abp.SettingManagement.Domain/Volo/Abp/SettingManagement/AbpSettingManagementDomainModule.cs +++ b/modules/setting-management/src/Volo.Abp.SettingManagement.Domain/Volo/Abp/SettingManagement/AbpSettingManagementDomainModule.cs @@ -10,6 +10,7 @@ using Volo.Abp.Caching; using Volo.Abp.Data; using Volo.Abp.DependencyInjection; using Volo.Abp.Domain; +using Volo.Abp.Localization; using Volo.Abp.Modularity; using Volo.Abp.Settings; using Volo.Abp.Threading; @@ -18,6 +19,7 @@ namespace Volo.Abp.SettingManagement; [DependsOn( typeof(AbpSettingsModule), + typeof(AbpLocalizationModule), typeof(AbpDddDomainModule), typeof(AbpSettingManagementDomainSharedModule), typeof(AbpCachingModule) diff --git a/modules/setting-management/src/Volo.Abp.SettingManagement.Domain/Volo/Abp/SettingManagement/DefaultLanguageSettingChangedHandler.cs b/modules/setting-management/src/Volo.Abp.SettingManagement.Domain/Volo/Abp/SettingManagement/DefaultLanguageSettingChangedHandler.cs new file mode 100644 index 0000000000..9d19fbe0ae --- /dev/null +++ b/modules/setting-management/src/Volo.Abp.SettingManagement.Domain/Volo/Abp/SettingManagement/DefaultLanguageSettingChangedHandler.cs @@ -0,0 +1,30 @@ +using System.Threading.Tasks; +using Volo.Abp.DependencyInjection; +using Volo.Abp.Domain.Entities.Events; +using Volo.Abp.EventBus; +using Volo.Abp.EventBus.Distributed; +using Volo.Abp.Localization; + +namespace Volo.Abp.SettingManagement; + +public class DefaultLanguageSettingChangedHandler : + ILocalEventHandler>, + ITransientDependency +{ + protected IDistributedEventBus DistributedEventBus { get; } + + public DefaultLanguageSettingChangedHandler(IDistributedEventBus distributedEventBus) + { + DistributedEventBus = distributedEventBus; + } + + public virtual async Task HandleEventAsync(EntityChangedEventData eventData) + { + if (eventData.Entity.Name != LocalizationSettingNames.DefaultLanguage) + { + return; + } + + await DistributedEventBus.PublishAsync(new LanguageChangedEto()); + } +} diff --git a/modules/setting-management/test/Volo.Abp.SettingManagement.Tests/Volo/Abp/SettingManagement/DefaultLanguageSettingChangedHandler_Tests.cs b/modules/setting-management/test/Volo.Abp.SettingManagement.Tests/Volo/Abp/SettingManagement/DefaultLanguageSettingChangedHandler_Tests.cs new file mode 100644 index 0000000000..e7aea826d7 --- /dev/null +++ b/modules/setting-management/test/Volo.Abp.SettingManagement.Tests/Volo/Abp/SettingManagement/DefaultLanguageSettingChangedHandler_Tests.cs @@ -0,0 +1,73 @@ +using System.Threading.Tasks; +using Shouldly; +using Volo.Abp.EventBus.Distributed; +using Volo.Abp.Localization; +using Volo.Abp.Settings; +using Volo.Abp.Uow; +using Xunit; + +namespace Volo.Abp.SettingManagement; + +public class DefaultLanguageSettingChangedHandler_Tests : SettingsTestBase +{ + private readonly ISettingManagementStore _settingManagementStore; + private readonly IDistributedEventBus _distributedEventBus; + private readonly IUnitOfWorkManager _unitOfWorkManager; + + public DefaultLanguageSettingChangedHandler_Tests() + { + _settingManagementStore = GetRequiredService(); + _distributedEventBus = GetRequiredService(); + _unitOfWorkManager = GetRequiredService(); + } + + [Fact] + public async Task Should_Publish_LanguageChangedEto_When_DefaultLanguage_Setting_Changed() + { + var languageChanged = false; + + using (var uow = _unitOfWorkManager.Begin()) + { + _distributedEventBus.Subscribe(_ => + { + languageChanged = true; + return Task.CompletedTask; + }); + + await _settingManagementStore.SetAsync( + LocalizationSettingNames.DefaultLanguage, + "tr;tr", + GlobalSettingValueProvider.ProviderName, + null); + + await uow.CompleteAsync(); + } + + languageChanged.ShouldBeTrue(); + } + + [Fact] + public async Task Should_Not_Publish_LanguageChangedEto_When_Other_Setting_Changed() + { + var languageChanged = false; + + using (var uow = _unitOfWorkManager.Begin()) + { + _distributedEventBus.Subscribe(_ => + { + languageChanged = true; + return Task.CompletedTask; + }); + + await _settingManagementStore.SetAsync( + "MySetting2", + "MySetting2Value-updated", + GlobalSettingValueProvider.ProviderName, + null); + + await uow.CompleteAsync(); + } + + languageChanged.ShouldBeFalse(); + } +} From 9b6a2a835638b058be797bfa3f32ac3893bf7651 Mon Sep 17 00:00:00 2001 From: maliming Date: Thu, 12 Nov 2026 10:26:18 +0800 Subject: [PATCH 2/2] Skip user-level default language changes and remove redundant localization dependency --- docs/en/modules/language-management.md | 2 +- .../Volo.Abp.SettingManagement.Domain.csproj | 1 - .../AbpSettingManagementDomainModule.cs | 2 -- .../DefaultLanguageSettingChangedHandler.cs | 4 ++- ...aultLanguageSettingChangedHandler_Tests.cs | 26 +++++++++++++++++++ 5 files changed, 30 insertions(+), 5 deletions(-) diff --git a/docs/en/modules/language-management.md b/docs/en/modules/language-management.md index 480fcb49fb..6b91a557d3 100644 --- a/docs/en/modules/language-management.md +++ b/docs/en/modules/language-management.md @@ -336,6 +336,6 @@ public class MyHandler : -The module already configures the `Language` to `LanguageEto` and `LanguageText` to `LanguageTextEto` mappings. Language entity changes also publish `LanguageChangedEto`, which consumers can use to refresh their language list. Changing the `Abp.Localization.DefaultLanguage` setting (including **Set as default language**) likewise publishes `LanguageChangedEto`, so request localization options pick up the new default without an application restart. See the [Distributed Event Bus](../framework/infrastructure/event-bus/distributed) document for details of the pre-defined entity events. +The module already configures the `Language` to `LanguageEto` and `LanguageText` to `LanguageTextEto` mappings. Language entity changes also publish `LanguageChangedEto`, which consumers can use to refresh their language list. Changing the application or tenant default language (the `Abp.Localization.DefaultLanguage` setting, including **Set as default language**) likewise publishes `LanguageChangedEto`, so request localization options pick up the new default without an application restart. The default language is used only when the request doesn't select a supported culture (query string, cookie or `Accept-Language` header). See the [Distributed Event Bus](../framework/infrastructure/event-bus/distributed) document for details of the pre-defined entity events. > Subscribing to distributed events is especially useful for distributed scenarios (like microservice architecture). If you are building a monolithic application or listening for events in the same process that runs the Language Management Module, subscribing to the [Local Event Bus](../framework/infrastructure/event-bus/local) can be simpler. diff --git a/modules/setting-management/src/Volo.Abp.SettingManagement.Domain/Volo.Abp.SettingManagement.Domain.csproj b/modules/setting-management/src/Volo.Abp.SettingManagement.Domain/Volo.Abp.SettingManagement.Domain.csproj index 0d2debd16d..9c781497c2 100644 --- a/modules/setting-management/src/Volo.Abp.SettingManagement.Domain/Volo.Abp.SettingManagement.Domain.csproj +++ b/modules/setting-management/src/Volo.Abp.SettingManagement.Domain/Volo.Abp.SettingManagement.Domain.csproj @@ -18,7 +18,6 @@ - diff --git a/modules/setting-management/src/Volo.Abp.SettingManagement.Domain/Volo/Abp/SettingManagement/AbpSettingManagementDomainModule.cs b/modules/setting-management/src/Volo.Abp.SettingManagement.Domain/Volo/Abp/SettingManagement/AbpSettingManagementDomainModule.cs index c76db98755..5f447d318f 100644 --- a/modules/setting-management/src/Volo.Abp.SettingManagement.Domain/Volo/Abp/SettingManagement/AbpSettingManagementDomainModule.cs +++ b/modules/setting-management/src/Volo.Abp.SettingManagement.Domain/Volo/Abp/SettingManagement/AbpSettingManagementDomainModule.cs @@ -10,7 +10,6 @@ using Volo.Abp.Caching; using Volo.Abp.Data; using Volo.Abp.DependencyInjection; using Volo.Abp.Domain; -using Volo.Abp.Localization; using Volo.Abp.Modularity; using Volo.Abp.Settings; using Volo.Abp.Threading; @@ -19,7 +18,6 @@ namespace Volo.Abp.SettingManagement; [DependsOn( typeof(AbpSettingsModule), - typeof(AbpLocalizationModule), typeof(AbpDddDomainModule), typeof(AbpSettingManagementDomainSharedModule), typeof(AbpCachingModule) diff --git a/modules/setting-management/src/Volo.Abp.SettingManagement.Domain/Volo/Abp/SettingManagement/DefaultLanguageSettingChangedHandler.cs b/modules/setting-management/src/Volo.Abp.SettingManagement.Domain/Volo/Abp/SettingManagement/DefaultLanguageSettingChangedHandler.cs index 9d19fbe0ae..4bef7672f5 100644 --- a/modules/setting-management/src/Volo.Abp.SettingManagement.Domain/Volo/Abp/SettingManagement/DefaultLanguageSettingChangedHandler.cs +++ b/modules/setting-management/src/Volo.Abp.SettingManagement.Domain/Volo/Abp/SettingManagement/DefaultLanguageSettingChangedHandler.cs @@ -4,6 +4,7 @@ using Volo.Abp.Domain.Entities.Events; using Volo.Abp.EventBus; using Volo.Abp.EventBus.Distributed; using Volo.Abp.Localization; +using Volo.Abp.Settings; namespace Volo.Abp.SettingManagement; @@ -20,7 +21,8 @@ public class DefaultLanguageSettingChangedHandler : public virtual async Task HandleEventAsync(EntityChangedEventData eventData) { - if (eventData.Entity.Name != LocalizationSettingNames.DefaultLanguage) + if (eventData.Entity.Name != LocalizationSettingNames.DefaultLanguage || + eventData.Entity.ProviderName == UserSettingValueProvider.ProviderName) { return; } diff --git a/modules/setting-management/test/Volo.Abp.SettingManagement.Tests/Volo/Abp/SettingManagement/DefaultLanguageSettingChangedHandler_Tests.cs b/modules/setting-management/test/Volo.Abp.SettingManagement.Tests/Volo/Abp/SettingManagement/DefaultLanguageSettingChangedHandler_Tests.cs index e7aea826d7..f070ea4b97 100644 --- a/modules/setting-management/test/Volo.Abp.SettingManagement.Tests/Volo/Abp/SettingManagement/DefaultLanguageSettingChangedHandler_Tests.cs +++ b/modules/setting-management/test/Volo.Abp.SettingManagement.Tests/Volo/Abp/SettingManagement/DefaultLanguageSettingChangedHandler_Tests.cs @@ -1,3 +1,4 @@ +using System; using System.Threading.Tasks; using Shouldly; using Volo.Abp.EventBus.Distributed; @@ -70,4 +71,29 @@ public class DefaultLanguageSettingChangedHandler_Tests : SettingsTestBase languageChanged.ShouldBeFalse(); } + + [Fact] + public async Task Should_Not_Publish_LanguageChangedEto_When_User_DefaultLanguage_Setting_Changed() + { + var languageChanged = false; + + using (var uow = _unitOfWorkManager.Begin()) + { + _distributedEventBus.Subscribe(_ => + { + languageChanged = true; + return Task.CompletedTask; + }); + + await _settingManagementStore.SetAsync( + LocalizationSettingNames.DefaultLanguage, + "tr;tr", + UserSettingValueProvider.ProviderName, + Guid.NewGuid().ToString()); + + await uow.CompleteAsync(); + } + + languageChanged.ShouldBeFalse(); + } }