Browse Source

Merge pull request #6623 from abpframework/revert-6480-maliming/PermissionStore

Revert "Use IPermissionStore in PermissionManagementProvider"
pull/6633/head
liangshiwei 6 years ago
committed by GitHub
parent
commit
2dc916cae6
No known key found for this signature in database GPG Key ID: 4AEE18F83AFDEB23
  1. 4
      modules/identity/src/Volo.Abp.PermissionManagement.Domain.Identity/Volo/Abp/PermissionManagement/Identity/RolePermissionManagementProvider.cs
  2. 8
      modules/identity/src/Volo.Abp.PermissionManagement.Domain.Identity/Volo/Abp/PermissionManagement/Identity/UserPermissionManagementProvider.cs
  3. 2
      modules/identityserver/src/Volo.Abp.PermissionManagement.Domain.IdentityServer/Volo/Abp/PermissionManagement/IdentityServer/ClientPermissionManagementProvider.cs
  4. 11
      modules/permission-management/src/Volo.Abp.PermissionManagement.Domain/Volo/Abp/PermissionManagement/PermissionManagementProvider.cs
  5. 6
      modules/permission-management/test/Volo.Abp.PermissionManagement.TestBase/Volo/Abp/PermissionManagement/TestPermissionManagementProvider.cs

4
modules/identity/src/Volo.Abp.PermissionManagement.Domain.Identity/Volo/Abp/PermissionManagement/Identity/RolePermissionManagementProvider.cs

@ -15,13 +15,11 @@ namespace Volo.Abp.PermissionManagement.Identity
public RolePermissionManagementProvider( public RolePermissionManagementProvider(
IPermissionGrantRepository permissionGrantRepository, IPermissionGrantRepository permissionGrantRepository,
IPermissionStore permissionStore,
IGuidGenerator guidGenerator, IGuidGenerator guidGenerator,
ICurrentTenant currentTenant, ICurrentTenant currentTenant,
IUserRoleFinder userRoleFinder) IUserRoleFinder userRoleFinder)
: base( : base(
permissionGrantRepository, permissionGrantRepository,
permissionStore,
guidGenerator, guidGenerator,
currentTenant) currentTenant)
{ {
@ -33,7 +31,7 @@ namespace Volo.Abp.PermissionManagement.Identity
if (providerName == Name) if (providerName == Name)
{ {
return new PermissionValueProviderGrantInfo( return new PermissionValueProviderGrantInfo(
await PermissionStore.IsGrantedAsync(name, providerName, providerKey), await PermissionGrantRepository.FindAsync(name, providerName, providerKey) != null,
providerKey providerKey
); );
} }

8
modules/identity/src/Volo.Abp.PermissionManagement.Domain.Identity/Volo/Abp/PermissionManagement/Identity/UserPermissionManagementProvider.cs

@ -9,17 +9,15 @@ namespace Volo.Abp.PermissionManagement.Identity
public override string Name => UserPermissionValueProvider.ProviderName; public override string Name => UserPermissionValueProvider.ProviderName;
public UserPermissionManagementProvider( public UserPermissionManagementProvider(
IPermissionGrantRepository permissionGrantRepository, IPermissionGrantRepository permissionGrantRepository,
IPermissionStore permissionStore,
IGuidGenerator guidGenerator, IGuidGenerator guidGenerator,
ICurrentTenant currentTenant) ICurrentTenant currentTenant)
: base( : base(
permissionGrantRepository, permissionGrantRepository,
permissionStore,
guidGenerator, guidGenerator,
currentTenant) currentTenant)
{ {
} }
} }
} }

2
modules/identityserver/src/Volo.Abp.PermissionManagement.Domain.IdentityServer/Volo/Abp/PermissionManagement/IdentityServer/ClientPermissionManagementProvider.cs

@ -11,12 +11,10 @@ namespace Volo.Abp.PermissionManagement.IdentityServer
public ClientPermissionManagementProvider( public ClientPermissionManagementProvider(
IPermissionGrantRepository permissionGrantRepository, IPermissionGrantRepository permissionGrantRepository,
IPermissionStore permissionStore,
IGuidGenerator guidGenerator, IGuidGenerator guidGenerator,
ICurrentTenant currentTenant) ICurrentTenant currentTenant)
: base( : base(
permissionGrantRepository, permissionGrantRepository,
permissionStore,
guidGenerator, guidGenerator,
currentTenant) currentTenant)
{ {

11
modules/permission-management/src/Volo.Abp.PermissionManagement.Domain/Volo/Abp/PermissionManagement/PermissionManagementProvider.cs

@ -1,5 +1,4 @@
using System.Threading.Tasks; using System.Threading.Tasks;
using Volo.Abp.Authorization.Permissions;
using Volo.Abp.Guids; using Volo.Abp.Guids;
using Volo.Abp.MultiTenancy; using Volo.Abp.MultiTenancy;
@ -11,24 +10,20 @@ namespace Volo.Abp.PermissionManagement
protected IPermissionGrantRepository PermissionGrantRepository { get; } protected IPermissionGrantRepository PermissionGrantRepository { get; }
protected IPermissionStore PermissionStore { get; }
protected IGuidGenerator GuidGenerator { get; } protected IGuidGenerator GuidGenerator { get; }
protected ICurrentTenant CurrentTenant { get; } protected ICurrentTenant CurrentTenant { get; }
protected PermissionManagementProvider( protected PermissionManagementProvider(
IPermissionGrantRepository permissionGrantRepository, IPermissionGrantRepository permissionGrantRepository,
IPermissionStore permissionStore,
IGuidGenerator guidGenerator, IGuidGenerator guidGenerator,
ICurrentTenant currentTenant) ICurrentTenant currentTenant)
{ {
PermissionGrantRepository = permissionGrantRepository; PermissionGrantRepository = permissionGrantRepository;
PermissionStore = permissionStore;
GuidGenerator = guidGenerator; GuidGenerator = guidGenerator;
CurrentTenant = currentTenant; CurrentTenant = currentTenant;
} }
public virtual async Task<PermissionValueProviderGrantInfo> CheckAsync(string name, string providerName, string providerKey) public virtual async Task<PermissionValueProviderGrantInfo> CheckAsync(string name, string providerName, string providerKey)
{ {
if (providerName != Name) if (providerName != Name)
@ -37,7 +32,7 @@ namespace Volo.Abp.PermissionManagement
} }
return new PermissionValueProviderGrantInfo( return new PermissionValueProviderGrantInfo(
await PermissionStore.IsGrantedAsync(name, providerName, providerKey), await PermissionGrantRepository.FindAsync(name, providerName, providerKey) != null,
providerKey providerKey
); );
} }
@ -79,4 +74,4 @@ namespace Volo.Abp.PermissionManagement
await PermissionGrantRepository.DeleteAsync(permissionGrant); await PermissionGrantRepository.DeleteAsync(permissionGrant);
} }
} }
} }

6
modules/permission-management/test/Volo.Abp.PermissionManagement.TestBase/Volo/Abp/PermissionManagement/TestPermissionManagementProvider.cs

@ -1,4 +1,6 @@
using Volo.Abp.Authorization.Permissions; using System;
using System.Collections.Generic;
using System.Text;
using Volo.Abp.Guids; using Volo.Abp.Guids;
using Volo.Abp.MultiTenancy; using Volo.Abp.MultiTenancy;
@ -10,12 +12,10 @@ namespace Volo.Abp.PermissionManagement
public TestPermissionManagementProvider( public TestPermissionManagementProvider(
IPermissionGrantRepository permissionGrantRepository, IPermissionGrantRepository permissionGrantRepository,
IPermissionStore permissionStore,
IGuidGenerator guidGenerator, IGuidGenerator guidGenerator,
ICurrentTenant currentTenant) ICurrentTenant currentTenant)
: base( : base(
permissionGrantRepository, permissionGrantRepository,
permissionStore,
guidGenerator, guidGenerator,
currentTenant) currentTenant)
{ {

Loading…
Cancel
Save