From 34e3b992840cd01a85149c3bfccc08ca11f5f478 Mon Sep 17 00:00:00 2001
From: Necati Meral <nm@lis-gmbh.com>
Date: Wed, 17 Jun 2020 18:27:14 +0200
Subject: [PATCH] Resolved code review issues by @liangshiw

---
 .../Volo/Abp/Application/Services/ICreateAppService.cs   | 5 +----
 .../Abp/Application/Services/ICreateUpdateAppService.cs  | 9 ++-------
 .../Volo/Abp/Application/Services/ICrudAppService.cs     | 5 +----
 .../Volo/Abp/Application/Services/IDeleteAppService.cs   | 5 +----
 .../Volo/Abp/Application/Services/IReadOnlyAppService.cs | 6 ++----
 .../Volo/Abp/Application/Services/IUpdateAppService.cs   | 5 +----
 6 files changed, 8 insertions(+), 27 deletions(-)

diff --git a/framework/src/Volo.Abp.Ddd.Application.Contracts/Volo/Abp/Application/Services/ICreateAppService.cs b/framework/src/Volo.Abp.Ddd.Application.Contracts/Volo/Abp/Application/Services/ICreateAppService.cs
index bd9a4f4620..a5d75b0b4b 100644
--- a/framework/src/Volo.Abp.Ddd.Application.Contracts/Volo/Abp/Application/Services/ICreateAppService.cs
+++ b/framework/src/Volo.Abp.Ddd.Application.Contracts/Volo/Abp/Application/Services/ICreateAppService.cs
@@ -1,7 +1,4 @@
-using System;
-using System.Collections.Generic;
-using System.Text;
-using System.Threading.Tasks;
+using System.Threading.Tasks;
 
 namespace Volo.Abp.Application.Services
 {
diff --git a/framework/src/Volo.Abp.Ddd.Application.Contracts/Volo/Abp/Application/Services/ICreateUpdateAppService.cs b/framework/src/Volo.Abp.Ddd.Application.Contracts/Volo/Abp/Application/Services/ICreateUpdateAppService.cs
index 22bf77ca96..ce3698405c 100644
--- a/framework/src/Volo.Abp.Ddd.Application.Contracts/Volo/Abp/Application/Services/ICreateUpdateAppService.cs
+++ b/framework/src/Volo.Abp.Ddd.Application.Contracts/Volo/Abp/Application/Services/ICreateUpdateAppService.cs
@@ -1,8 +1,4 @@
-using System;
-using System.Collections.Generic;
-using System.Text;
-
-namespace Volo.Abp.Application.Services
+namespace Volo.Abp.Application.Services
 {
     public interface ICreateUpdateAppService<TEntityDto, in TKey>
         : ICreateUpdateAppService<TEntityDto, TKey, TEntityDto, TEntityDto>
@@ -18,8 +14,7 @@ namespace Volo.Abp.Application.Services
 
     public interface ICreateUpdateAppService<TGetOutputDto, in TKey, in TCreateUpdateInput, in TUpdateInput>
         : ICreateAppService<TGetOutputDto, TCreateUpdateInput>,
-            IUpdateAppService<TGetOutputDto, TKey, TUpdateInput>,
-            IApplicationService
+            IUpdateAppService<TGetOutputDto, TKey, TUpdateInput>
     {
 
     }
diff --git a/framework/src/Volo.Abp.Ddd.Application.Contracts/Volo/Abp/Application/Services/ICrudAppService.cs b/framework/src/Volo.Abp.Ddd.Application.Contracts/Volo/Abp/Application/Services/ICrudAppService.cs
index b866ce0ed9..10f88db22a 100644
--- a/framework/src/Volo.Abp.Ddd.Application.Contracts/Volo/Abp/Application/Services/ICrudAppService.cs
+++ b/framework/src/Volo.Abp.Ddd.Application.Contracts/Volo/Abp/Application/Services/ICrudAppService.cs
@@ -1,5 +1,3 @@
-using System.Threading.Tasks;
-
 using Volo.Abp.Application.Dtos;
 
 namespace Volo.Abp.Application.Services
@@ -31,8 +29,7 @@ namespace Volo.Abp.Application.Services
     public interface ICrudAppService<TGetOutputDto, TGetListOutputDto, in TKey, in TGetListInput, in TCreateInput, in TUpdateInput>
         : IReadOnlyAppService<TGetOutputDto, TGetListOutputDto, TKey, TGetListInput>,
             ICreateUpdateAppService<TGetOutputDto, TKey, TCreateInput, TUpdateInput>,
-            IDeleteAppService<TKey>,
-            IApplicationService
+            IDeleteAppService<TKey>
     {
 
     }
diff --git a/framework/src/Volo.Abp.Ddd.Application.Contracts/Volo/Abp/Application/Services/IDeleteAppService.cs b/framework/src/Volo.Abp.Ddd.Application.Contracts/Volo/Abp/Application/Services/IDeleteAppService.cs
index 0a70e2a95e..50badcead9 100644
--- a/framework/src/Volo.Abp.Ddd.Application.Contracts/Volo/Abp/Application/Services/IDeleteAppService.cs
+++ b/framework/src/Volo.Abp.Ddd.Application.Contracts/Volo/Abp/Application/Services/IDeleteAppService.cs
@@ -1,7 +1,4 @@
-using System;
-using System.Collections.Generic;
-using System.Text;
-using System.Threading.Tasks;
+using System.Threading.Tasks;
 
 namespace Volo.Abp.Application.Services
 {
diff --git a/framework/src/Volo.Abp.Ddd.Application.Contracts/Volo/Abp/Application/Services/IReadOnlyAppService.cs b/framework/src/Volo.Abp.Ddd.Application.Contracts/Volo/Abp/Application/Services/IReadOnlyAppService.cs
index 2f4ad1b9c7..eb03faffe3 100644
--- a/framework/src/Volo.Abp.Ddd.Application.Contracts/Volo/Abp/Application/Services/IReadOnlyAppService.cs
+++ b/framework/src/Volo.Abp.Ddd.Application.Contracts/Volo/Abp/Application/Services/IReadOnlyAppService.cs
@@ -1,7 +1,4 @@
-using System;
-using System.Collections.Generic;
-using System.Text;
-using System.Threading.Tasks;
+using System.Threading.Tasks;
 
 using Volo.Abp.Application.Dtos;
 
@@ -20,6 +17,7 @@ namespace Volo.Abp.Application.Services
     }
 
     public interface IReadOnlyAppService<TGetOutputDto, TGetListOutputDto, in TKey, in TGetListInput>
+        : IApplicationService
     {
         Task<TGetOutputDto> GetAsync(TKey id);
 
diff --git a/framework/src/Volo.Abp.Ddd.Application.Contracts/Volo/Abp/Application/Services/IUpdateAppService.cs b/framework/src/Volo.Abp.Ddd.Application.Contracts/Volo/Abp/Application/Services/IUpdateAppService.cs
index 043050b170..c0904709bf 100644
--- a/framework/src/Volo.Abp.Ddd.Application.Contracts/Volo/Abp/Application/Services/IUpdateAppService.cs
+++ b/framework/src/Volo.Abp.Ddd.Application.Contracts/Volo/Abp/Application/Services/IUpdateAppService.cs
@@ -1,7 +1,4 @@
-using System;
-using System.Collections.Generic;
-using System.Text;
-using System.Threading.Tasks;
+using System.Threading.Tasks;
 
 namespace Volo.Abp.Application.Services
 {