Browse Source

Merge pull request #24093 from abpframework/TelemetryActivityEventBuilder

Change TelemetryActivityEventBuilder to transient dependency
pull/24114/head
Halil İbrahim Kalkan 3 months ago
committed by GitHub
parent
commit
3bfb63071c
No known key found for this signature in database GPG Key ID: B5690EEEBB952194
  1. 3
      framework/src/Volo.Abp.Core/Volo/Abp/AbpApplicationBase.cs
  2. 10
      framework/src/Volo.Abp.Core/Volo/Abp/Internal/Telemetry/Activity/Providers/TelemetryActivityEventBuilder.cs

3
framework/src/Volo.Abp.Core/Volo/Abp/AbpApplicationBase.cs

@ -185,8 +185,7 @@ public abstract class AbpApplicationBase : IAbpApplication
{ {
try try
{ {
using var scope = ServiceProvider.CreateScope(); var logger = Services.GetInitLogger<AbpApplicationBase>();
var logger = scope.ServiceProvider.GetRequiredService<ILogger<AbpApplicationBase>>();
logger.LogException(ex, LogLevel.Trace); logger.LogException(ex, LogLevel.Trace);
} }
catch catch

10
framework/src/Volo.Abp.Core/Volo/Abp/Internal/Telemetry/Activity/Providers/TelemetryActivityEventBuilder.cs

@ -8,7 +8,7 @@ using Volo.Abp.Internal.Telemetry.Constants;
namespace Volo.Abp.Internal.Telemetry.Activity.Providers; namespace Volo.Abp.Internal.Telemetry.Activity.Providers;
public class TelemetryActivityEventBuilder : ITelemetryActivityEventBuilder, ISingletonDependency public class TelemetryActivityEventBuilder : ITelemetryActivityEventBuilder, ITransientDependency
{ {
private readonly List<ITelemetryActivityEventEnricher> _activityEnrichers; private readonly List<ITelemetryActivityEventEnricher> _activityEnrichers;
@ -31,7 +31,7 @@ public class TelemetryActivityEventBuilder : ITelemetryActivityEventBuilder, ISi
{ {
//ignored //ignored
} }
if (context.IsTerminated) if (context.IsTerminated)
{ {
return null; return null;
@ -40,10 +40,10 @@ public class TelemetryActivityEventBuilder : ITelemetryActivityEventBuilder, ISi
return context.Current; return context.Current;
} }
private static bool FilterEnricher(ITelemetryActivityEventEnricher enricher) private static bool FilterEnricher(ITelemetryActivityEventEnricher enricher)
{ {
return ProxyHelper.GetUnProxiedType(enricher).Assembly.FullName!.StartsWith(TelemetryConsts.VoloNameSpaceFilter) && return ProxyHelper.GetUnProxiedType(enricher).Assembly.FullName!.StartsWith(TelemetryConsts.VoloNameSpaceFilter) &&
enricher is not IHasParentTelemetryActivityEventEnricher<TelemetryActivityEventEnricher>; enricher is not IHasParentTelemetryActivityEventEnricher<TelemetryActivityEventEnricher>;
} }
} }

Loading…
Cancel
Save