Merge pull request #19192 from takato1314/fix/19190_remove_obsolete

Remove legacy serialization feature `Exception.Exception(SerializationInfo, StreamingContext)` which is `obsolete`.

framework/src/Volo.Abp.BackgroundJobs.Abstractions/Volo/Abp/BackgroundJobs/BackgroundJobExecutionException.cs

@@ -1,9 +1,7 @@
 using System;
-using System.Runtime.Serialization;
 
 namespace Volo.Abp.BackgroundJobs;
 
-[Serializable]
 public class BackgroundJobExecutionException : AbpException
 {
     public string JobType { get; set; } = default!;
@@ -15,15 +13,6 @@ public class BackgroundJobExecutionException : AbpException
 
     }
 
-    /// <summary>
-    /// Creates a new <see cref="BackgroundJobExecutionException"/> object.
-    /// </summary>
-    public BackgroundJobExecutionException(SerializationInfo serializationInfo, StreamingContext context)
-        : base(serializationInfo, context)
-    {
-
-    }
-
     /// <summary>
     /// Creates a new <see cref="BackgroundJobExecutionException"/> object.
     /// </summary>

framework/src/Volo.Abp.BlobStoring/Volo/Abp/BlobStoring/BlobAlreadyExistsException.cs

@@ -1,5 +1,4 @@
 using System;
-using System.Runtime.Serialization;
 
 namespace Volo.Abp.BlobStoring;
 
@@ -21,10 +20,4 @@ public class BlobAlreadyExistsException : AbpException
     {
 
     }
-
-    public BlobAlreadyExistsException(SerializationInfo serializationInfo, StreamingContext context)
-        : base(serializationInfo, context)
-    {
-
-    }
 }

framework/src/Volo.Abp.Core/System/Collections/Generic/AbpDictionaryExtensions.cs

@@ -131,7 +131,7 @@ public static class AbpDictionaryExtensions
     }
 
     /// <summary>
-    /// Converts a <string,object> dictionary to dynamic object so added and removed at run
+    /// Converts a &lt;string,object&gt; dictionary to dynamic object so added and removed at run
     /// </summary>
     /// <param name="dictionary">The collection object</param>
     /// <returns>If value is correct, return ExpandoObject that represents an object</returns>

framework/src/Volo.Abp.Core/Volo/Abp/AbpException.cs

@@ -1,5 +1,4 @@
 using System;
-using System.Runtime.Serialization;
 
 namespace Volo.Abp;
 
@@ -24,10 +23,4 @@ public class AbpException : Exception
     {
 
     }
-
-    public AbpException(SerializationInfo serializationInfo, StreamingContext context)
-        : base(serializationInfo, context)
-    {
-
-    }
 }

framework/src/Volo.Abp.Core/Volo/Abp/AbpInitializationException.cs

@@ -1,5 +1,4 @@
 using System;
-using System.Runtime.Serialization;
 
 namespace Volo.Abp;
 
@@ -21,10 +20,4 @@ public class AbpInitializationException : AbpException
     {
 
     }
-
-    public AbpInitializationException(SerializationInfo serializationInfo, StreamingContext context)
-        : base(serializationInfo, context)
-    {
-
-    }
 }

framework/src/Volo.Abp.Core/Volo/Abp/AbpShutdownException.cs

@@ -1,5 +1,4 @@
 using System;
-using System.Runtime.Serialization;
 
 namespace Volo.Abp;
 
@@ -21,10 +20,4 @@ public class AbpShutdownException : AbpException
     {
 
     }
-
-    public AbpShutdownException(SerializationInfo serializationInfo, StreamingContext context)
-        : base(serializationInfo, context)
-    {
-
-    }
 }

framework/src/Volo.Abp.Core/Volo/Abp/BusinessException.cs

@@ -1,12 +1,10 @@
 using System;
-using System.Runtime.Serialization;
 using Microsoft.Extensions.Logging;
 using Volo.Abp.ExceptionHandling;
 using Volo.Abp.Logging;
 
 namespace Volo.Abp;
 
-[Serializable]
 public class BusinessException : Exception,
     IBusinessException,
     IHasErrorCode,
@@ -32,15 +30,6 @@ public class BusinessException : Exception,
         LogLevel = logLevel;
     }
 
-    /// <summary>
-    /// Constructor for serializing.
-    /// </summary>
-    public BusinessException(SerializationInfo serializationInfo, StreamingContext context)
-        : base(serializationInfo, context)
-    {
-
-    }
-
     public BusinessException WithData(string name, object value)
     {
         Data[name] = value;

framework/src/Volo.Abp.Core/Volo/Abp/IAbpApplicationWithExternalServiceProvider.cs

@@ -10,18 +10,18 @@ public interface IAbpApplicationWithExternalServiceProvider : IAbpApplication
     /// Sets the service provider, but not initializes the modules.
     /// </summary>
     void SetServiceProvider([NotNull] IServiceProvider serviceProvider);
-    
+
     /// <summary>
     /// Sets the service provider and initializes all the modules.
     /// If <see cref="SetServiceProvider"/> was called before, the same
-    /// <see cref="serviceProvider"/> instance should be passed to this method.
+    /// <paramref name="serviceProvider"/> instance should be passed to this method.
     /// </summary>
     Task InitializeAsync([NotNull] IServiceProvider serviceProvider);
 
     /// <summary>
     /// Sets the service provider and initializes all the modules.
     /// If <see cref="SetServiceProvider"/> was called before, the same
-    /// <see cref="serviceProvider"/> instance should be passed to this method.
+    /// <paramref name="serviceProvider"/> instance should be passed to this method.
     /// </summary>
     void Initialize([NotNull] IServiceProvider serviceProvider);
 }

framework/src/Volo.Abp.Core/Volo/Abp/UserFriendlyException.cs

@@ -1,5 +1,4 @@
 using System;
-using System.Runtime.Serialization;
 using Microsoft.Extensions.Logging;
 
 namespace Volo.Abp;
@@ -7,7 +6,6 @@ namespace Volo.Abp;
 /// <summary>
 /// This exception type is directly shown to the user.
 /// </summary>
-[Serializable]
 public class UserFriendlyException : BusinessException, IUserFriendlyException
 {
     public UserFriendlyException(
@@ -25,13 +23,4 @@ public class UserFriendlyException : BusinessException, IUserFriendlyException
     {
         Details = details;
     }
-
-    /// <summary>
-    /// Constructor for serializing.
-    /// </summary>
-    public UserFriendlyException(SerializationInfo serializationInfo, StreamingContext context)
-        : base(serializationInfo, context)
-    {
-
-    }
 }

framework/src/Volo.Abp.ExceptionHandling/Volo/Abp/Http/Client/AbpRemoteCallException.cs

@@ -1,10 +1,8 @@
 using System;
-using System.Runtime.Serialization;
 using Volo.Abp.ExceptionHandling;
 
 namespace Volo.Abp.Http.Client;
 
-[Serializable]
 public class AbpRemoteCallException : AbpException, IHasErrorCode, IHasErrorDetails, IHasHttpStatusCode
 {
     public int HttpStatusCode { get; set; }
@@ -26,12 +24,6 @@ public class AbpRemoteCallException : AbpException, IHasErrorCode, IHasErrorDeta
 
     }
 
-    public AbpRemoteCallException(SerializationInfo serializationInfo, StreamingContext context)
-        : base(serializationInfo, context)
-    {
-
-    }
-
     public AbpRemoteCallException(RemoteServiceErrorInfo error, Exception? innerException = null)
         : base(error.Message, innerException)
     {

framework/src/Volo.Abp.Minify/Volo/Abp/Minify/NUglify/NUglifyException.cs

@@ -1,6 +1,5 @@
 using System;
 using System.Collections.Generic;
-using System.Runtime.Serialization;
 using NUglify;
 
 namespace Volo.Abp.Minify.NUglify;
@@ -20,13 +19,4 @@ public class NUglifyException : AbpException
     {
 
     }
-
-    /// <summary>
-    /// Constructor for serializing.
-    /// </summary>
-    public NUglifyException(SerializationInfo serializationInfo, StreamingContext context)
-        : base(serializationInfo, context)
-    {
-
-    }
 }

framework/src/Volo.Abp.Security/Volo/Abp/Authorization/AbpAuthorizationException.cs

@@ -1,5 +1,4 @@
 using System;
-using System.Runtime.Serialization;
 using Microsoft.Extensions.Logging;
 using Volo.Abp.ExceptionHandling;
 using Volo.Abp.Logging;
@@ -9,7 +8,6 @@ namespace Volo.Abp.Authorization;
 /// <summary>
 /// This exception is thrown on an unauthorized request.
 /// </summary>
-[Serializable]
 public class AbpAuthorizationException : AbpException, IHasLogLevel, IHasErrorCode
 {
     /// <summary>
@@ -31,15 +29,6 @@ public class AbpAuthorizationException : AbpException, IHasLogLevel, IHasErrorCo
         LogLevel = LogLevel.Warning;
     }
 
-    /// <summary>
-    /// Creates a new <see cref="AbpAuthorizationException"/> object.
-    /// </summary>
-    public AbpAuthorizationException(SerializationInfo serializationInfo, StreamingContext context)
-        : base(serializationInfo, context)
-    {
-
-    }
-
     /// <summary>
     /// Creates a new <see cref="AbpAuthorizationException"/> object.
     /// </summary>

framework/src/Volo.Abp.Validation.Abstractions/Volo/Abp/Validation/AbpValidationException.cs

@@ -2,7 +2,6 @@
 using System.Collections.Generic;
 using System.ComponentModel.DataAnnotations;
 using System.Linq;
-using System.Runtime.Serialization;
 using System.Text;
 using Microsoft.Extensions.Logging;
 using Volo.Abp.Logging;
@@ -12,7 +11,6 @@ namespace Volo.Abp.Validation;
 /// <summary>
 /// This exception type is used to throws validation exceptions.
 /// </summary>
-[Serializable]
 public class AbpValidationException : AbpException,
     IHasLogLevel,
     IHasValidationErrors,
@@ -38,16 +36,6 @@ public class AbpValidationException : AbpException,
         LogLevel = LogLevel.Warning;
     }
 
-    /// <summary>
-    /// Constructor for serializing.
-    /// </summary>
-    public AbpValidationException(SerializationInfo serializationInfo, StreamingContext context)
-        : base(serializationInfo, context)
-    {
-        ValidationErrors = new List<ValidationResult>();
-        LogLevel = LogLevel.Warning;
-    }
-
     /// <summary>
     /// Constructor.
     /// </summary>

framework/test/Volo.Abp.Imaging.ImageSharp.Tests/Volo/Abp/Imaging/ImageSharpImageCompressor_Tests.cs

@@ -1,6 +1,9 @@
 using System.IO;
 using System.Threading.Tasks;
+using Microsoft.Extensions.DependencyInjection;
 using Shouldly;
+using SixLabors.ImageSharp.Formats.Jpeg;
+using SixLabors.ImageSharp.Formats.Webp;
 using Xunit;
 
 namespace Volo.Abp.Imaging;
@@ -8,10 +11,29 @@ namespace Volo.Abp.Imaging;
 public class ImageSharpImageCompressor_Tests : AbpImagingImageSharpTestBase
 {
     public IImageCompressor ImageCompressor { get; }
+
     public ImageSharpImageCompressor_Tests()
     {
         ImageCompressor = GetRequiredService<IImageCompressor>();
     }
+
+    protected override void AfterAddApplication(IServiceCollection services)
+    {
+        services.Configure<ImageSharpCompressOptions>(options =>
+        {
+            options.JpegEncoder = new JpegEncoder
+            {
+                Quality = 50
+            };
+            options.WebpEncoder = new WebpEncoder
+            {
+                Quality = 50
+            };
+        });
+
+        base.AfterAddApplication(services);
+    }
+
     [Fact]
     public async Task Should_Compress_Jpg()
     {
@@ -59,21 +81,21 @@ public class ImageSharpImageCompressor_Tests : AbpImagingImageSharpTestBase
     {
         await using var jpegImage = ImageFileHelper.GetJpgTestFileStream();
         var byteArr = await jpegImage.GetAllBytesAsync();
-        
+
         var compressedImage1 = await ImageCompressor.CompressAsync(jpegImage);
         var compressedImage2 = await ImageCompressor.CompressAsync(byteArr);
-        
+
         compressedImage1.ShouldNotBeNull();
         compressedImage1.State.ShouldBe(ImageProcessState.Done);
-        
+
         compressedImage2.ShouldNotBeNull();
         compressedImage2.State.ShouldBe(ImageProcessState.Done);
-        
+
         compressedImage1.Result.Length.ShouldBeLessThan(jpegImage.Length);
         compressedImage2.Result.LongLength.ShouldBeLessThan(jpegImage.Length);
-        
+
         compressedImage1.Result.Length.ShouldBe(compressedImage2.Result.LongLength);
-        
+
         compressedImage1.Result.Dispose();
     }
-}
+}

modules/cms-kit/src/Volo.CmsKit.Domain/Volo/CmsKit/Blogs/BlogPostSlugAlreadyExistException.cs

@@ -1,16 +1,10 @@
 using System;
-using System.Runtime.Serialization;
 using Volo.Abp;
 
 namespace Volo.CmsKit.Blogs;
 
 public class BlogPostSlugAlreadyExistException : BusinessException
 {
-    public BlogPostSlugAlreadyExistException(SerializationInfo serializationInfo, StreamingContext context)
-        : base(serializationInfo, context)
-    {
-    }
-
     public BlogPostSlugAlreadyExistException(Guid blogId, string slug)
     {
         Slug = slug;

modules/cms-kit/src/Volo.CmsKit.Domain/Volo/CmsKit/Blogs/BlogSlugAlreadyExistException.cs

@@ -1,10 +1,7 @@
-using System;
-using System.Runtime.Serialization;
-using Volo.Abp;
+using Volo.Abp;
 
 namespace Volo.CmsKit.Blogs;
 
-[Serializable]
 public class BlogSlugAlreadyExistException : BusinessException
 {
     public BlogSlugAlreadyExistException(string slug)
@@ -12,9 +9,4 @@ public class BlogSlugAlreadyExistException : BusinessException
     {
         WithData(nameof(Blog.Slug), slug);
     }
-
-    public BlogSlugAlreadyExistException(SerializationInfo serializationInfo, StreamingContext context)
-        : base(serializationInfo, context)
-    {
-    }
 }

modules/cms-kit/src/Volo.CmsKit.Domain/Volo/CmsKit/Comments/EntityNotCommentableException.cs

@@ -1,20 +1,9 @@
-using System;
-using System.Collections.Generic;
-using System.Linq;
-using System.Runtime.Serialization;
-using System.Text;
-using System.Threading.Tasks;
-using Volo.Abp;
+using Volo.Abp;
 
 namespace Volo.CmsKit.Comments;
 
-[Serializable]
 public class EntityNotCommentableException : BusinessException
 {
-    public EntityNotCommentableException(SerializationInfo serializationInfo, StreamingContext context) : base(serializationInfo, context)
-    {
-    }
-
     public EntityNotCommentableException(string entityType)
     {
         Code = CmsKitErrorCodes.Comments.EntityNotCommentable;

modules/cms-kit/src/Volo.CmsKit.Domain/Volo/CmsKit/MediaDescriptors/EntityCantHaveMediaException.cs

@@ -1,14 +1,9 @@
-using System.Runtime.Serialization;
-using Volo.Abp;
+using Volo.Abp;
 
 namespace Volo.CmsKit.MediaDescriptors;
 
 public class EntityCantHaveMediaException : BusinessException
 {
-    public EntityCantHaveMediaException(SerializationInfo serializationInfo, StreamingContext context) : base(serializationInfo, context)
-    {
-    }
-
     public EntityCantHaveMediaException(string entityType)
       : base(code: CmsKitErrorCodes.MediaDescriptors.EntityTypeDoesntExist)
     {

modules/cms-kit/src/Volo.CmsKit.Domain/Volo/CmsKit/MediaDescriptors/InvalidMediaDescriptorNameException.cs

@@ -1,11 +1,8 @@
-using System;
-using System.Runtime.Serialization;
-using JetBrains.Annotations;
+using JetBrains.Annotations;
 using Volo.Abp;
 
 namespace Volo.CmsKit.MediaDescriptors;
 
-[Serializable]
 public class InvalidMediaDescriptorNameException : BusinessException
 {
     public InvalidMediaDescriptorNameException([NotNull] string name)
@@ -13,10 +10,4 @@ public class InvalidMediaDescriptorNameException : BusinessException
         Code = CmsKitErrorCodes.MediaDescriptors.InvalidName;
         WithData(nameof(MediaDescriptor.Name), name);
     }
-
-    public InvalidMediaDescriptorNameException(SerializationInfo serializationInfo, StreamingContext context)
-        : base(serializationInfo, context)
-    {
-
-    }
 }

modules/cms-kit/src/Volo.CmsKit.Domain/Volo/CmsKit/Pages/MultipleHomePageException.cs

@@ -1,23 +1,11 @@
-using System;
-using System.Collections.Generic;
-using System.Linq;
-using System.Runtime.Serialization;
-using System.Text;
-using System.Threading.Tasks;
-using Volo.Abp;
+using Volo.Abp;
 
 namespace Volo.CmsKit.Domain.Volo.CmsKit.Pages;
 
-[Serializable]
 public class MultipleHomePageException : BusinessException
 {
 	public MultipleHomePageException()
 	{
 		Code = CmsKitErrorCodes.Pages.MultipleHomePage;
 	}
-	
-	public MultipleHomePageException(SerializationInfo serializationInfo, StreamingContext context)
-		: base(serializationInfo, context)
-	{
-	}
 }

modules/cms-kit/src/Volo.CmsKit.Domain/Volo/CmsKit/Pages/PageSlugAlreadyExistsException.cs

@@ -1,11 +1,8 @@
-using System;
-using System.Runtime.Serialization;
-using JetBrains.Annotations;
+using JetBrains.Annotations;
 using Volo.Abp;
 
 namespace Volo.CmsKit.Pages;
 
-[Serializable]
 public class PageSlugAlreadyExistsException : BusinessException
 {
     public PageSlugAlreadyExistsException([NotNull] string slug)
@@ -13,10 +10,4 @@ public class PageSlugAlreadyExistsException : BusinessException
         Code = CmsKitErrorCodes.Pages.SlugAlreadyExist;
         WithData(nameof(Page.Slug), slug);
     }
-
-    public PageSlugAlreadyExistsException(SerializationInfo serializationInfo, StreamingContext context)
-        : base(serializationInfo, context)
-    {
-
-    }
 }

modules/cms-kit/src/Volo.CmsKit.Domain/Volo/CmsKit/Ratings/EntityCantHaveRatingException.cs

@@ -1,15 +1,10 @@
 using JetBrains.Annotations;
-using System.Runtime.Serialization;
 using Volo.Abp;
 
 namespace Volo.CmsKit.Ratings;
 
 public class EntityCantHaveRatingException : BusinessException
 {
-    public EntityCantHaveRatingException(SerializationInfo serializationInfo, StreamingContext context) : base(serializationInfo, context)
-    {
-    }
-
     public EntityCantHaveRatingException([NotNull] string entityType)
     {
         Code = CmsKitErrorCodes.Ratings.EntityCantHaveRating;

modules/cms-kit/src/Volo.CmsKit.Domain/Volo/CmsKit/Reactions/EntityCantHaveReactionException.cs

@@ -1,16 +1,10 @@
-
-using JetBrains.Annotations;
-using System.Runtime.Serialization;
+using JetBrains.Annotations;
 using Volo.Abp;
 
 namespace Volo.CmsKit.Reactions;
 
 public class EntityCantHaveReactionException : BusinessException
 {
-    public EntityCantHaveReactionException(SerializationInfo serializationInfo, StreamingContext context) : base(serializationInfo, context)
-    {
-    }
-
     public EntityCantHaveReactionException([NotNull] string entityType)
     {
         EntityType = Check.NotNullOrEmpty(entityType, nameof(entityType));

modules/cms-kit/src/Volo.CmsKit.Domain/Volo/CmsKit/Tags/EntityNotTaggableException.cs

@@ -1,16 +1,9 @@
-using System;
-using System.Runtime.Serialization;
-using Volo.Abp;
+using Volo.Abp;
 
 namespace Volo.CmsKit.Tags;
 
-[Serializable]
 public class EntityNotTaggableException : BusinessException
 {
-    public EntityNotTaggableException(SerializationInfo serializationInfo, StreamingContext context) : base(serializationInfo, context)
-    {
-    }
-
     public EntityNotTaggableException(string entityType)
     {
         Code = CmsKitErrorCodes.Tags.EntityNotTaggable;

modules/docs/src/Volo.Docs.Domain.Shared/Volo/Docs/DocumentNotFoundException.cs

@@ -1,20 +1,11 @@
-using System;
-using System.Runtime.Serialization;
-using Volo.Abp;
+using Volo.Abp;
 
 namespace Volo.Docs
 {
-    [Serializable]
     public class DocumentNotFoundException : BusinessException
     {
         public string DocumentUrl { get; set; }
 
-        public DocumentNotFoundException(SerializationInfo serializationInfo, StreamingContext context)
-            : base(serializationInfo, context)
-        {
-
-        }
-
         public DocumentNotFoundException(string documentUrl)
         {
             DocumentUrl = documentUrl;

modules/docs/src/Volo.Docs.Domain.Shared/Volo/Docs/ResourceNotFoundException.cs

@@ -1,20 +1,11 @@
-using System;
-using System.Runtime.Serialization;
-using Volo.Abp;
+using Volo.Abp;
 
 namespace Volo.Docs
 {
-    [Serializable]
     public class ResourceNotFoundException : BusinessException
     {
         public string ResourceName { get; set; }
 
-        public ResourceNotFoundException(SerializationInfo serializationInfo, StreamingContext context)
-            : base(serializationInfo, context)
-        {
-
-        }
-
         public ResourceNotFoundException(string resourceName)
         {
             ResourceName = resourceName;

modules/docs/src/Volo.Docs.HttpApi/Volo/Docs/Documents/DocsDocumentController.cs

@@ -1,5 +1,6 @@
 using System.Collections.Generic;
 using System.Threading.Tasks;
+using Asp.Versioning;
 using Microsoft.AspNetCore.Mvc;
 using Asp.Versioning;
 using Volo.Abp;

modules/docs/src/Volo.Docs.HttpApi/Volo/Docs/Projects/DocsProjectController.cs

@@ -1,4 +1,5 @@
 using System.Threading.Tasks;
+using Asp.Versioning;
 using Microsoft.AspNetCore.Mvc;
 using Asp.Versioning;
 using Volo.Abp;

modules/docs/src/Volo.Docs.Web/Areas/Documents/DocumentResourceController.cs

@@ -1,5 +1,6 @@
 using System;
 using System.Threading.Tasks;
+using Asp.Versioning;
 using Microsoft.AspNetCore.Mvc;
 using Asp.Versioning;
 using Volo.Abp;

modules/identity/src/Volo.Abp.Identity.Domain/Volo/Abp/Identity/AbpIdentityResultException.cs

@@ -1,7 +1,5 @@
-using System;
-using System.Collections.Generic;
+using System.Collections.Generic;
 using System.Linq;
-using System.Runtime.Serialization;
 using JetBrains.Annotations;
 using Microsoft.AspNetCore.Identity;
 using Microsoft.Extensions.Localization;
@@ -11,7 +9,6 @@ using Volo.Abp.Localization;
 
 namespace Volo.Abp.Identity;
 
-[Serializable]
 public class AbpIdentityResultException : BusinessException, ILocalizeErrorMessage
 {
     public IdentityResult IdentityResult { get; }
@@ -24,12 +21,6 @@ public class AbpIdentityResultException : BusinessException, ILocalizeErrorMessa
         IdentityResult = Check.NotNull(identityResult, nameof(identityResult));
     }
 
-    public AbpIdentityResultException(SerializationInfo serializationInfo, StreamingContext context)
-        : base(serializationInfo, context)
-    {
-
-    }
-
     public virtual string LocalizeMessage(LocalizationContext context)
     {
         var localizer = context.LocalizerFactory.Create<IdentityResource>();