From 43e7365e226bbd946f4d54500564b3d58e7fcfd2 Mon Sep 17 00:00:00 2001
From: maliming <malimings@gmail.com>
Date: Fri, 20 Mar 2026 15:24:55 +0800
Subject: [PATCH] fix: Streamline job deletion and enhance exception handling
 in TickerQ background worker manager

---
 .../QuartzDynamicBackgroundWorkerManager.cs   |  9 +++----
 .../TickerQDynamicBackgroundWorkerManager.cs  | 27 ++++++++++++++-----
 2 files changed, 24 insertions(+), 12 deletions(-)

diff --git a/framework/src/Volo.Abp.BackgroundWorkers.Quartz/Volo/Abp/BackgroundWorkers/Quartz/QuartzDynamicBackgroundWorkerManager.cs b/framework/src/Volo.Abp.BackgroundWorkers.Quartz/Volo/Abp/BackgroundWorkers/Quartz/QuartzDynamicBackgroundWorkerManager.cs
index 57fdda79eb..7ff3f85a1d 100644
--- a/framework/src/Volo.Abp.BackgroundWorkers.Quartz/Volo/Abp/BackgroundWorkers/Quartz/QuartzDynamicBackgroundWorkerManager.cs
+++ b/framework/src/Volo.Abp.BackgroundWorkers.Quartz/Volo/Abp/BackgroundWorkers/Quartz/QuartzDynamicBackgroundWorkerManager.cs
@@ -71,13 +71,10 @@ public class QuartzDynamicBackgroundWorkerManager : IDynamicBackgroundWorkerMana
         }
 
         var jobKey = new JobKey($"DynamicWorker:{workerName}");
-        var deleted = await Scheduler.DeleteJob(jobKey, cancellationToken);
-        if (deleted)
-        {
-            HandlerRegistry.Unregister(workerName);
-        }
+        await Scheduler.DeleteJob(jobKey, cancellationToken);
+        HandlerRegistry.Unregister(workerName);
 
-        return deleted;
+        return true;
     }
 
     public virtual async Task<bool> UpdateScheduleAsync(
diff --git a/framework/src/Volo.Abp.BackgroundWorkers.TickerQ/Volo/Abp/BackgroundWorkers/TickerQ/TickerQDynamicBackgroundWorkerManager.cs b/framework/src/Volo.Abp.BackgroundWorkers.TickerQ/Volo/Abp/BackgroundWorkers/TickerQ/TickerQDynamicBackgroundWorkerManager.cs
index e5409b1b9a..f4850777dd 100644
--- a/framework/src/Volo.Abp.BackgroundWorkers.TickerQ/Volo/Abp/BackgroundWorkers/TickerQ/TickerQDynamicBackgroundWorkerManager.cs
+++ b/framework/src/Volo.Abp.BackgroundWorkers.TickerQ/Volo/Abp/BackgroundWorkers/TickerQ/TickerQDynamicBackgroundWorkerManager.cs
@@ -1,12 +1,14 @@
 using System;
 using System.Threading;
 using System.Threading.Tasks;
+using Microsoft.Extensions.DependencyInjection;
 using Microsoft.Extensions.Logging;
 using Microsoft.Extensions.Logging.Abstractions;
 using TickerQ.Utilities.Entities;
 using TickerQ.Utilities.Enums;
 using TickerQ.Utilities.Interfaces.Managers;
 using Volo.Abp.DependencyInjection;
+using Volo.Abp.ExceptionHandling;
 using Volo.Abp.TickerQ;
 
 namespace Volo.Abp.BackgroundWorkers.TickerQ;
@@ -57,9 +59,19 @@ public class TickerQDynamicBackgroundWorkerManager : IDynamicBackgroundWorkerMan
                     return;
                 }
 
-                await registeredHandler(
-                    new DynamicBackgroundWorkerExecutionContext(workerName, serviceProvider),
-                    tickerCancellationToken);
+                try
+                {
+                    await registeredHandler(
+                        new DynamicBackgroundWorkerExecutionContext(workerName, serviceProvider),
+                        tickerCancellationToken);
+                }
+                catch (Exception ex)
+                {
+                    await serviceProvider.GetRequiredService<IExceptionNotifier>()
+                        .NotifyAsync(new ExceptionNotificationContext(ex));
+
+                    throw;
+                }
             }, 0);
 
         AbpTickerQBackgroundWorkersProvider.BackgroundWorkers[functionName] = new AbpTickerQCronBackgroundWorker
@@ -92,9 +104,12 @@ public class TickerQDynamicBackgroundWorkerManager : IDynamicBackgroundWorkerMan
         AbpTickerQBackgroundWorkersProvider.BackgroundWorkers.Remove(functionName);
         HandlerRegistry.Unregister(workerName);
 
-        // Note: ICronTickerManager<T> does not provide a remove API.
-        // The handler is unregistered above, so any persisted cron entry will
-        // find a null handler and skip execution silently.
+        // ICronTickerManager<T> does not provide a remove API, so the persisted
+        // cron entry will remain in storage. The handler is unregistered above,
+        // so the entry will find a null handler and skip execution silently.
+        Logger.LogWarning(
+            "Dynamic worker '{WorkerName}' removed from memory, but the persisted TickerQ cron entry may remain in storage.",
+            workerName);
 
         return Task.FromResult(true);
     }