Refactor and notes on code review.

src/Volo.Abp.Authorization/Volo/Abp/Authorization/Permissions/PermissionChecker.cs

@@ -34,8 +34,7 @@ namespace Volo.Abp.Authorization.Permissions
                 true
             );
         }
-
-
+        
         public Task<PermissionGrantInfo> CheckAsync(string name)
         {
             var permission = PermissionDefinitionManager.Get(name);

src/Volo.Abp.Permissions.Domain/Volo/Abp/Permissions/IPermissionManagementProvider.cs

@@ -11,6 +11,8 @@ namespace Volo.Abp.Permissions
 
         Task<PermissionValueProviderGrantInfo> CheckAsync([NotNull] string name, [NotNull] string providerName, [NotNull] string providerKey);
 
+        //TODO: Instead of GrantAsync/RevokeAsync add SetAsync
+
         Task GrantAsync([NotNull] string name, [NotNull] string providerKey);
 
         Task RevokeAsync([NotNull] string name, [NotNull] string providerKey);

src/Volo.Abp.Permissions.Domain/Volo/Abp/Permissions/PermissionManager.cs

@@ -70,19 +70,18 @@ namespace Volo.Abp.Permissions
                 return;
             }
 
+            var provider = ManagementProviders.FirstOrDefault(m => m.Name == providerName);
+            if (provider == null)
+            {
+                throw new AbpException("Unknown permission management provider: " + providerName);
+            }
+
             if (currentGrantInfo.IsGranted == false)
             {
-                var provider = ManagementProviders.FirstOrDefault(m => m.Name == providerName);
                 await provider.GrantAsync(permissionName, providerKey);
             }
             else
             {
-                if (currentGrantInfo.Providers.All(p => p.Name != providerName))
-                {
-                    return;
-                }
-
-                var provider = ManagementProviders.FirstOrDefault(m => m.Name == providerName);
                 await provider.RevokeAsync(permissionName, providerKey);
             }
         }