From 26742af89db780bbcde2ec28a13dbf279757de98 Mon Sep 17 00:00:00 2001
From: liangshiwei <liangshiw@outlook.com>
Date: Fri, 20 May 2022 18:04:44 +0800
Subject: [PATCH 1/5] Add unit test for the Check

---
 .../Volo/Abp/Check_Tests.cs                   | 119 ++++++++++++++++++
 1 file changed, 119 insertions(+)
 create mode 100644 framework/test/Volo.Abp.Core.Tests/Volo/Abp/Check_Tests.cs

diff --git a/framework/test/Volo.Abp.Core.Tests/Volo/Abp/Check_Tests.cs b/framework/test/Volo.Abp.Core.Tests/Volo/Abp/Check_Tests.cs
new file mode 100644
index 0000000000..58467fabb5
--- /dev/null
+++ b/framework/test/Volo.Abp.Core.Tests/Volo/Abp/Check_Tests.cs
@@ -0,0 +1,119 @@
+using System;
+using System.Collections.Generic;
+using Shouldly;
+using Xunit;
+
+namespace Volo.Abp;
+
+public class Check_Tests
+{
+    [Fact]
+    public void NotNull_Test()
+    {
+        Check.NotNull("test", nameof(NotNull_Test)).ShouldBe("test");
+        Check.NotNull(string.Empty, nameof(NotNull_Test)).ShouldBe(string.Empty);
+        Check.NotNull("test", nameof(NotNull_Test), maxLength: 4, minLength: 0).ShouldBe("test");
+
+        Assert.Throws<ArgumentNullException>(() => Check.NotNull<object>(null, nameof(NotNull_Test)));
+        Assert.Throws<ArgumentException>(() => Check.NotNull(null, nameof(NotNull_Test)));
+        Assert.Throws<ArgumentException>(() => Check.NotNull("test", nameof(NotNull_Test), maxLength: 3));
+        Assert.Throws<ArgumentException>(() => Check.NotNull("test", nameof(NotNull_Test), minLength: 5));
+    }
+
+    [Fact]
+    public void NotNullOrWhiteSpace_Test()
+    {
+        Check.NotNullOrWhiteSpace("test", nameof(NotNullOrWhiteSpace_Test)).ShouldBe("test");
+        Check.NotNullOrWhiteSpace("test", nameof(NotNullOrWhiteSpace_Test), maxLength: 4, minLength: 0).ShouldBe("test");
+
+        Assert.Throws<ArgumentException>(() => Check.NotNullOrWhiteSpace(null, nameof(NotNullOrWhiteSpace_Test)));
+        Assert.Throws<ArgumentException>(() => Check.NotNullOrWhiteSpace(string.Empty, nameof(NotNullOrWhiteSpace_Test)));
+        Assert.Throws<ArgumentException>(() => Check.NotNullOrWhiteSpace("test", nameof(NotNullOrWhiteSpace_Test), maxLength: 3));
+        Assert.Throws<ArgumentException>(() => Check.NotNullOrWhiteSpace("test", nameof(NotNullOrWhiteSpace_Test), minLength: 5));
+    }
+
+    [Fact]
+    public void NotNullOrEmpty_Test()
+    {
+        Check.NotNullOrEmpty("test", nameof(NotNullOrEmpty_Test)).ShouldBe("test");
+        Check.NotNullOrEmpty("test", nameof(NotNullOrEmpty_Test), maxLength: 4, minLength: 0).ShouldBe("test");
+        Check.NotNullOrEmpty(new List<string>{"test"}, nameof(NotNullOrEmpty_Test));
+        
+        Assert.Throws<ArgumentException>(() => Check.NotNullOrEmpty(null, nameof(NotNullOrEmpty_Test)));
+        Assert.Throws<ArgumentException>(() => Check.NotNullOrEmpty(string.Empty, nameof(NotNullOrEmpty_Test)));
+        Assert.Throws<ArgumentException>(() => Check.NotNullOrEmpty("test", nameof(NotNullOrEmpty_Test), maxLength: 3));
+        Assert.Throws<ArgumentException>(() => Check.NotNullOrEmpty("test", nameof(NotNullOrEmpty_Test), minLength: 5));
+        Assert.Throws<ArgumentException>(() => Check.NotNullOrEmpty(new List<string>(), nameof(NotNullOrEmpty_Test)));
+    }
+
+    [Fact]
+    public void AssignableTo_Test()
+    {
+        Check.AssignableTo<object>(typeof(string), nameof(AssignableTo_Test)).ShouldBe(typeof(string));
+        Check.AssignableTo<Parent>(typeof(Child), nameof(AssignableTo_Test)).ShouldBe(typeof(Child));
+        Check.AssignableTo<Child>(typeof(Child2), nameof(AssignableTo_Test)).ShouldBe(typeof(Child2));
+        Check.AssignableTo<Parent>(typeof(Child2), nameof(AssignableTo_Test)).ShouldBe(typeof(Child2));
+        
+        Assert.Throws<ArgumentException>(() => Check.AssignableTo<Child>(typeof(Parent), nameof(AssignableTo_Test)));
+        Assert.Throws<ArgumentException>(() => Check.AssignableTo<Child2>(typeof(Child), nameof(AssignableTo_Test)));
+        Assert.Throws<ArgumentException>(() => Check.AssignableTo<Child2>(typeof(Parent), nameof(AssignableTo_Test)));
+    }
+
+    [Fact]
+    public void Length_Test()
+    {
+        Check.Length("test", nameof(Length_Test), maxLength: 4).ShouldBe("test");
+        Check.Length("test", nameof(Length_Test), maxLength: 5).ShouldBe("test");
+        Check.Length("test", nameof(Length_Test), maxLength:4, minLength: 0).ShouldBe("test");
+        Check.Length("test", nameof(Length_Test), maxLength:4, minLength: 4).ShouldBe("test");
+        
+        Assert.Throws<ArgumentException>(() => Check.Length("test", nameof(Length_Test), maxLength: 0));
+        Assert.Throws<ArgumentException>(() => Check.Length("test", nameof(Length_Test), maxLength: 3));
+        Assert.Throws<ArgumentException>(() => Check.Length("test", nameof(Length_Test), maxLength: 4, minLength: 5));
+    }
+
+    [Fact]
+    public void Positive_Test()
+    {
+        Check.Positive(1.To<Int16>(), nameof(Positive_Test)).ShouldBe(1.To<Int16>());
+        Check.Positive(1.To<Int32>(), nameof(Positive_Test)).ShouldBe(1.To<Int32>());
+        Check.Positive(1.To<Int64>(), nameof(Positive_Test)).ShouldBe(1.To<Int64>());
+        
+        Assert.Throws<ArgumentException>(() => Check.Positive(0.To<Int16>(), nameof(Positive_Test)));
+        Assert.Throws<ArgumentException>(() => Check.Positive(0.To<Int32>(), nameof(Positive_Test)));
+        Assert.Throws<ArgumentException>(() => Check.Positive(0.To<Int64>(), nameof(Positive_Test)));
+        Assert.Throws<ArgumentException>(() => Check.Positive(-1.To<Int16>(), nameof(Positive_Test)));
+        Assert.Throws<ArgumentException>(() => Check.Positive(-1.To<Int32>(), nameof(Positive_Test)));
+        Assert.Throws<ArgumentException>(() => Check.Positive(-1.To<Int64>(), nameof(Positive_Test)));
+    }
+
+    [Fact]
+    public void Range_Test()
+    {
+        Check.Range(1.To<Int16>(), nameof(Range_Test), minimumValue: 1.To<Int16>(), maximumValue: 10.To<Int16>()).ShouldBe(1.To<Int16>());
+        Check.Range(1.To<Int32>(), nameof(Range_Test), minimumValue: 1.To<Int32>(), maximumValue: 10.To<Int32>()).ShouldBe(1.To<Int32>());
+        Check.Range(1.To<Int64>(), nameof(Range_Test), minimumValue: 1.To<Int64>(), maximumValue: 10.To<Int64>()).ShouldBe(1.To<Int64>());
+        
+        Assert.Throws<ArgumentException>(() => Check.Range(0.To<Int16>(), nameof(Range_Test), minimumValue: 1.To<Int16>(), maximumValue: 10.To<Int16>()));
+        Assert.Throws<ArgumentException>(() => Check.Range(0.To<Int32>(), nameof(Range_Test), minimumValue: 1.To<Int32>(), maximumValue: 10.To<Int32>()));
+        Assert.Throws<ArgumentException>(() => Check.Range(0.To<Int64>(), nameof(Range_Test), minimumValue: 1.To<Int64>(), maximumValue: 10.To<Int64>()));
+        Assert.Throws<ArgumentException>(() => Check.Range(11.To<Int16>(), nameof(Range_Test), minimumValue: 1.To<Int16>(), maximumValue: 10.To<Int16>()));
+        Assert.Throws<ArgumentException>(() => Check.Range(11.To<Int32>(), nameof(Range_Test), minimumValue: 1.To<Int32>(), maximumValue: 10.To<Int32>()));
+        Assert.Throws<ArgumentException>(() => Check.Range(11.To<Int64>(), nameof(Range_Test), minimumValue: 1.To<Int64>(), maximumValue: 10.To<Int64>()));
+    }
+    
+    class Parent
+    {
+        
+    }
+    
+    class Child: Parent
+    {
+        
+    }
+
+    class Child2: Child
+    {
+        
+    }
+}
\ No newline at end of file

From b7a2189f992bd83fa4de02a278a0fa35c5307af3 Mon Sep 17 00:00:00 2001
From: liangshiwei <liangshiw@outlook.com>
Date: Fri, 20 May 2022 18:10:54 +0800
Subject: [PATCH 2/5] Update Check_Tests.cs

---
 .../Volo/Abp/Check_Tests.cs                    | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

diff --git a/framework/test/Volo.Abp.Core.Tests/Volo/Abp/Check_Tests.cs b/framework/test/Volo.Abp.Core.Tests/Volo/Abp/Check_Tests.cs
index 58467fabb5..48a579c820 100644
--- a/framework/test/Volo.Abp.Core.Tests/Volo/Abp/Check_Tests.cs
+++ b/framework/test/Volo.Abp.Core.Tests/Volo/Abp/Check_Tests.cs
@@ -78,13 +78,22 @@ public class Check_Tests
         Check.Positive(1.To<Int16>(), nameof(Positive_Test)).ShouldBe(1.To<Int16>());
         Check.Positive(1.To<Int32>(), nameof(Positive_Test)).ShouldBe(1.To<Int32>());
         Check.Positive(1.To<Int64>(), nameof(Positive_Test)).ShouldBe(1.To<Int64>());
+        Check.Positive(Decimal.One, nameof(Positive_Test)).ShouldBe(Decimal.One);
+        Check.Positive(1.0f, nameof(Positive_Test)).ShouldBe(1.0f);
+        Check.Positive(1.0, nameof(Positive_Test)).ShouldBe(1.0);
         
         Assert.Throws<ArgumentException>(() => Check.Positive(0.To<Int16>(), nameof(Positive_Test)));
         Assert.Throws<ArgumentException>(() => Check.Positive(0.To<Int32>(), nameof(Positive_Test)));
         Assert.Throws<ArgumentException>(() => Check.Positive(0.To<Int64>(), nameof(Positive_Test)));
+        Assert.Throws<ArgumentException>(() => Check.Positive(Decimal.Zero, nameof(Positive_Test)));
+        Assert.Throws<ArgumentException>(() => Check.Positive(0.0f, nameof(Positive_Test)));
+        Assert.Throws<ArgumentException>(() => Check.Positive(0.0, nameof(Positive_Test)));
         Assert.Throws<ArgumentException>(() => Check.Positive(-1.To<Int16>(), nameof(Positive_Test)));
         Assert.Throws<ArgumentException>(() => Check.Positive(-1.To<Int32>(), nameof(Positive_Test)));
         Assert.Throws<ArgumentException>(() => Check.Positive(-1.To<Int64>(), nameof(Positive_Test)));
+        Assert.Throws<ArgumentException>(() => Check.Positive(-Decimal.One, nameof(Positive_Test)));
+        Assert.Throws<ArgumentException>(() => Check.Positive(-1.0f, nameof(Positive_Test)));
+        Assert.Throws<ArgumentException>(() => Check.Positive(-1.0, nameof(Positive_Test)));
     }
 
     [Fact]
@@ -93,13 +102,22 @@ public class Check_Tests
         Check.Range(1.To<Int16>(), nameof(Range_Test), minimumValue: 1.To<Int16>(), maximumValue: 10.To<Int16>()).ShouldBe(1.To<Int16>());
         Check.Range(1.To<Int32>(), nameof(Range_Test), minimumValue: 1.To<Int32>(), maximumValue: 10.To<Int32>()).ShouldBe(1.To<Int32>());
         Check.Range(1.To<Int64>(), nameof(Range_Test), minimumValue: 1.To<Int64>(), maximumValue: 10.To<Int64>()).ShouldBe(1.To<Int64>());
+        Check.Range(Decimal.One, nameof(Range_Test), minimumValue: Decimal.One, maximumValue: 10.To<Decimal>()).ShouldBe(Decimal.One);
+        Check.Range(1.0f, nameof(Range_Test), minimumValue: 1.0f, maximumValue: 10.0f).ShouldBe(1.0f);
+        Check.Range(1.0, nameof(Range_Test), minimumValue: 1.0, maximumValue: 10.0).ShouldBe(1.0);
         
         Assert.Throws<ArgumentException>(() => Check.Range(0.To<Int16>(), nameof(Range_Test), minimumValue: 1.To<Int16>(), maximumValue: 10.To<Int16>()));
         Assert.Throws<ArgumentException>(() => Check.Range(0.To<Int32>(), nameof(Range_Test), minimumValue: 1.To<Int32>(), maximumValue: 10.To<Int32>()));
         Assert.Throws<ArgumentException>(() => Check.Range(0.To<Int64>(), nameof(Range_Test), minimumValue: 1.To<Int64>(), maximumValue: 10.To<Int64>()));
+        Assert.Throws<ArgumentException>(() => Check.Range(Decimal.Zero, nameof(Range_Test), minimumValue: Decimal.One, maximumValue: 10.To<Decimal>()));
+        Assert.Throws<ArgumentException>(() => Check.Range(0.0f, nameof(Range_Test), minimumValue: 1.0f, maximumValue: 10.0f));
+        Assert.Throws<ArgumentException>(() => Check.Range(0.0, nameof(Range_Test), minimumValue: 1.0, maximumValue: 10.0));
         Assert.Throws<ArgumentException>(() => Check.Range(11.To<Int16>(), nameof(Range_Test), minimumValue: 1.To<Int16>(), maximumValue: 10.To<Int16>()));
         Assert.Throws<ArgumentException>(() => Check.Range(11.To<Int32>(), nameof(Range_Test), minimumValue: 1.To<Int32>(), maximumValue: 10.To<Int32>()));
         Assert.Throws<ArgumentException>(() => Check.Range(11.To<Int64>(), nameof(Range_Test), minimumValue: 1.To<Int64>(), maximumValue: 10.To<Int64>()));
+        Assert.Throws<ArgumentException>(() => Check.Range(11.To<Decimal>(), nameof(Range_Test), minimumValue: Decimal.One, maximumValue: 10.To<Decimal>()));
+        Assert.Throws<ArgumentException>(() => Check.Range(11.0f, nameof(Range_Test), minimumValue: 1.0f, maximumValue: 10.0f));
+        Assert.Throws<ArgumentException>(() => Check.Range(11.0, nameof(Range_Test), minimumValue: 1.0, maximumValue: 10.0));
     }
     
     class Parent

From 2e08429cc42369e70750e366b20dbef2d3bd5de8 Mon Sep 17 00:00:00 2001
From: Yunus Emre Kalkan <emre.kalkan@volosoft.com>
Date: Fri, 20 May 2022 15:43:30 +0300
Subject: [PATCH 3/5] Cli: Support for nested </Template-Remove> conditions

---
 .../Files/FileEntryExtensions.cs              | 30 +++++++++++++++----
 1 file changed, 25 insertions(+), 5 deletions(-)

diff --git a/framework/src/Volo.Abp.Cli.Core/Volo/Abp/Cli/ProjectBuilding/Files/FileEntryExtensions.cs b/framework/src/Volo.Abp.Cli.Core/Volo/Abp/Cli/ProjectBuilding/Files/FileEntryExtensions.cs
index 8543ffb1ac..b5edcd5d54 100644
--- a/framework/src/Volo.Abp.Cli.Core/Volo/Abp/Cli/ProjectBuilding/Files/FileEntryExtensions.cs
+++ b/framework/src/Volo.Abp.Cli.Core/Volo/Abp/Cli/ProjectBuilding/Files/FileEntryExtensions.cs
@@ -6,6 +6,8 @@ namespace Volo.Abp.Cli.ProjectBuilding.Files;
 
 public static class FileEntryExtensions
 {
+    private static int _maximumRecursionCount  = 20;
+    
     public static FileEntry ReplaceText(this FileEntry file, string oldText, string newText)
     {
         file.NormalizeLineEndings();
@@ -20,7 +22,7 @@ public static class FileEntryExtensions
 
     public static void RemoveTemplateCodeMarkers(this FileEntry file)
     {
-        if (!file.Content.Contains("</TEMPLATE-REMOVE>"))
+        if (!file.Content.Contains("<TEMPLATE-REMOVE") && !file.Content.Contains("</TEMPLATE-REMOVE>") )
         {
             return;
         }
@@ -49,9 +51,9 @@ public static class FileEntryExtensions
         file.SetLines(newLines);
     }
 
-    private static void RemoveMarkedTemplateCode(this FileEntry file, List<string> symbols)
+    private static void RemoveMarkedTemplateCode(this FileEntry file, List<string> symbols, int recursionCount = 0)
     {
-        if (!file.Content.Contains("</TEMPLATE-REMOVE>"))
+        if (!file.Content.Contains("<TEMPLATE-REMOVE") || recursionCount > _maximumRecursionCount)
         {
             return;
         }
@@ -97,9 +99,25 @@ public static class FileEntryExtensions
                     continue;
                 }
 
-                while (i < lines.Length && !lines[i].Contains("</TEMPLATE-REMOVE>"))
+                var innerConditionCount = 0;
+                
+                while (i < lines.Length)
                 {
-                    ++i;
+                    i++;
+                    
+                    if (lines[i].Contains("<TEMPLATE-REMOVE"))
+                    {
+                        innerConditionCount++;
+                    }
+                    else if (lines[i].Contains("</TEMPLATE-REMOVE>"))
+                    {
+                        if (innerConditionCount < 1)
+                        {
+                            break;
+                        }
+                        
+                        innerConditionCount--;
+                    }
                 }
 
                 if (lines[i+1].Contains("<TEMPLATE-REMOVE"))
@@ -117,6 +135,8 @@ public static class FileEntryExtensions
         }
 
         file.SetLines(newLines);
+
+        RemoveMarkedTemplateCode(file, symbols, recursionCount + 1);
     }
 
     private static TemplateRemoveMarkerParseResult ParseTemplateRemoveMarker(string marker)

From 4e2e062bd4c26e121acc60b6607a8e230ffb2b78 Mon Sep 17 00:00:00 2001
From: Yunus Emre Kalkan <emre.kalkan@volosoft.com>
Date: Fri, 20 May 2022 17:53:51 +0300
Subject: [PATCH 4/5] Cli: Improve <TEMPLATE-REMOVE>

---
 .../Abp/Cli/ProjectBuilding/Files/FileEntryExtensions.cs     | 5 +++--
 .../Abp/Cli/ProjectBuilding/Templates/App/AppTemplateBase.cs | 1 +
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/framework/src/Volo.Abp.Cli.Core/Volo/Abp/Cli/ProjectBuilding/Files/FileEntryExtensions.cs b/framework/src/Volo.Abp.Cli.Core/Volo/Abp/Cli/ProjectBuilding/Files/FileEntryExtensions.cs
index b5edcd5d54..a5085f83a9 100644
--- a/framework/src/Volo.Abp.Cli.Core/Volo/Abp/Cli/ProjectBuilding/Files/FileEntryExtensions.cs
+++ b/framework/src/Volo.Abp.Cli.Core/Volo/Abp/Cli/ProjectBuilding/Files/FileEntryExtensions.cs
@@ -39,9 +39,9 @@ public static class FileEntryExtensions
             {
                 //TODO: What if we use inline like: <TEMPLATE-REMOVE IF-NOT="..."> some-code </TEMPLATE-REMOVE>
                 //TODO: This logic skips the code in that case. Should handle it
-                ++i;
+                continue;
             }
-
+            
             if (i < lines.Length)
             {
                 newLines.Add(lines[i]);
@@ -146,6 +146,7 @@ public static class FileEntryExtensions
         var condition = marker.Trim()
             .RemovePreFix("//").Trim()
             .RemovePreFix("@*").Trim()
+            .RemovePreFix("#").Trim()
             .RemovePreFix("<!--").Trim()
             .RemovePreFix("<TEMPLATE-REMOVE").Trim()
             .RemovePostFix("*@").Trim()
diff --git a/framework/src/Volo.Abp.Cli.Core/Volo/Abp/Cli/ProjectBuilding/Templates/App/AppTemplateBase.cs b/framework/src/Volo.Abp.Cli.Core/Volo/Abp/Cli/ProjectBuilding/Templates/App/AppTemplateBase.cs
index 6a0b532135..c94783fa0f 100644
--- a/framework/src/Volo.Abp.Cli.Core/Volo/Abp/Cli/ProjectBuilding/Templates/App/AppTemplateBase.cs
+++ b/framework/src/Volo.Abp.Cli.Core/Volo/Abp/Cli/ProjectBuilding/Templates/App/AppTemplateBase.cs
@@ -37,6 +37,7 @@ public abstract class AppTemplateBase : TemplateInfo
         RandomizeSslPorts(context, steps);
         RandomizeStringEncryption(context, steps);
         UpdateNuGetConfig(context, steps);
+        ConfigureDockerFiles(context, steps);
         ChangeConnectionString(context, steps);
         CleanupFolderHierarchy(context, steps);
 

From 255a529e1f4a0626c8f2dbb82c471f5b3deb09ed Mon Sep 17 00:00:00 2001
From: liangshiwei <liangshiw@outlook.com>
Date: Sat, 21 May 2022 09:37:57 +0800
Subject: [PATCH 5/5] Rnhance SwaggerUIBundle

---
 .../Volo.Abp.Swashbuckle/wwwroot/swagger/ui/abp.swagger.js  | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/framework/src/Volo.Abp.Swashbuckle/wwwroot/swagger/ui/abp.swagger.js b/framework/src/Volo.Abp.Swashbuckle/wwwroot/swagger/ui/abp.swagger.js
index 0649b3c7fb..249f75ebb0 100644
--- a/framework/src/Volo.Abp.Swashbuckle/wwwroot/swagger/ui/abp.swagger.js
+++ b/framework/src/Volo.Abp.Swashbuckle/wwwroot/swagger/ui/abp.swagger.js
@@ -8,6 +8,8 @@ var abp = abp || {};
         var firstRequest = true;
         abp.appPath = configObject.baseUrl || abp.appPath;
 
+        var requestInterceptor = configObject.requestInterceptor;
+        
         configObject.requestInterceptor = async function (request) {
 
             if(request.url.includes(excludeUrl[1])){
@@ -26,6 +28,10 @@ var abp = abp || {};
             if (antiForgeryToken) {
                 request.headers[abp.security.antiForgery.tokenHeaderName] = antiForgeryToken;
             }
+            
+            if(requestInterceptor){
+                requestInterceptor(request);
+            }
             return request;
         };